Undefined index #date_format in date_popup_process_date()/date_popup_date_granularity()/, date_popup.module

I also have this issue with the 7.x-1.x-alpha2 version (with different line numbers). When adding a date field to a content type the date popup appears with no problem. This error occurs when I try to add a date field to a form in a custom module. The date format is defined in the module as '#date_format' => 'm/d/Y'. When I do a dump of the arrays passed to the module I can see why the index is not working. I tried fixing it by changing the reference from $element['#date_format'] to $element['element']['#date_format'] which resolves the error, but then brings up a ton of other errors in the module.

+1, I'm going to try to look into it further this weekend. If anyone has a patch I'd be glad to test.

It looks like date_format isn't always set and that's triggering this notice (it's not technically an error and won't actually break anything, just annoying :) ).

The attached patch simply checks that the date_format array index is set before trying to access it.

- Scott

I get this error on a panel that contains a pane with a view (no dates though).

* Notice: Undefined index: additional fields in date_field_views_data_alter() (line 252 of /home/clients/websites/***/public_html/afaf/sites/all/modules/date/date_views/date_views.module).
* Warning: array_merge() [function.array-merge]: Argument #1 is not an array in date_field_views_data_alter() (line 252 of /home/clients/websites/***/public_html/afaf/sites/all/modules/date/date_views/date_views.module).
* Notice: Undefined index: additional fields in date_field_views_data_alter() (line 252 of /home/clients/websites/***/public_html/afaf/sites/all/modules/date/date_views/date_views.module).
* Warning: array_merge() [function.array-merge]: Argument #1 is not an array in date_field_views_data_alter() (line 252 of /home/clients/websites/***/public_html/afaf/sites/all/modules/date/date_views/date_views.module).

The patch in #3 seems to work. The error no longer displays.

Spoke too soon. I cleared caches, but it seems to always come back when I navigate away from the panel and click on the panel page's menu item again. Then I hit the browser "refresh" (firefox) and it disappears.

@sborsody, was it the FF or drupal cache you cleared. I just applied this patch and it seems to have resolved the issue I was experiencing. I might suggest adding a couple lines to the patch to do similar checks for time which it doesn't have. This isn't an issue for me since I am just dealing with dates but this might what is causing your issue.

@hadsie, thanks for the patch still testing but looks good so far.

...title was too vague. This one makes the issue much easier to search and find.

@bmasgistro

What I meant above was Drupal cache. I see this error also on the edit page of a view that filters on a node type that contains a date popup field. When I clear the Drupal cache, the error shows. Then I hit refresh on FF and the error disappears. Then I can browse to another page and browse back to the view edit page that had the error and no error shows up. When I clear the Drupal cache again, the error returns.

It could be like you said, that I'm seeing the error still due to the patch not checking for time. The content type in question is using datetime.

Try this patch. I made this one against the D7 dev release and not the alpha (was hoping the dev had this fixed).

I installed the dev release and applied your updated patch. Thanks. Haven't seen the error since.

I'm sorry, what exactly do I need to install to fix this? Do I install the whole dev module (I've got alpha 2) now and then patch it?

Thanks,

Paragon

@Paragon: short answer: yes and yes.

Long one: in order to test patches for various issues, install the version of the module the patch refers to (where available these are usually the dev versions - here it is 7.x-1.x-dev and you can tell this from the issue's summary), then patch it with the latest patch provided (here the one from #10). Once you test, report back with success or not. Once the issue is marked as "closed (fixed)", you can use the latest dev without the patch, but you have to wait 12 hours before downloading the latest dev (in order to give the bot time to build the new version that includes the patch's changes).

Great, klonos, thank you so much. Does that apply to all module patches on drupal.org in general?

I've tried this out and it seems to be working now. I'm not entirely clear on why/how the error started coming up in the first place, though, but I have been so far unable to reproduce it.

Paragon

Does that apply to all module patches on drupal.org in general?

...not to all. I'd say to most. You see...

- for one not all projects (modules/themes) have dev versions. It's up to their maintainer(s).
- a patch might take too long to be tested and approved and in the meantime a new version of the module/theme might become available. That's when we say that a patch needs a 're-roll' against the latest version. Even then though you can try to patch the files manually (if the patch command fails).

...I'm not entirely clear on why/how the error started coming up in the first place, though,

...no need to know mate, but if you do, then try reading what Scott says in post #3 ;)

...but I have been so far unable to reproduce it.

...I take it you mean after applying the patch. Right? That's good news. It justifies why this issue's status is set to 'RTBC' ;)

PS: I'd suggest we stop this generic talk about patches in this issue though Daniel because we are taking it off-topic. Please follow the links I provided and use the site's search feature on the top of each drupal.org page ;)

I just got the error again today. I went to my home page and it showed up. Seems very sporadic, though.

Edit: So far, it comes consistently for me when I save a view, and it disappears when I refresh the browser.

Paragon

...a few things to try:

- empty your browser's cache and see if you still get the error.
- check if it happens in various browsers.
- clear your drupal/server-side cache (either use this url: http://your.site.here/admin_menu/flush-cache?destination=none or go to Administration -› Configuration -› Development -› Performance and click the 'Clear all caches' button).

I have not seen the error since #12. I'm still running 7.x-1.x-dev (2011-Feb-24).

There have been a ton of changes to both Date and Calendar since this was posted. I don't need reports that this works, I need confirmation if something is still broken on the latest code (dev versions of Date, Calendar, Views, and CTools).

I don't want to commit a change to hide something that should not be missing, I want to see if it is still missing.

Date 7.x-1.x is unsupported.
This issue should be verified in the latest version of Date (7.x-2.x-dev) and re-opened if still valid.

Thanks

Still exists in 7.x-2.x-dev, even after flushing all caches:

Notice: Undefined index: #date_format in date_popup_process_date() (line 238 of C:\******\sites\all\modules\contrib\date\date_popup\date_popup.module).
Notice: Undefined index: #date_format in date_popup_date_granularity() (line 172 of C:\******\sites\all\modules\contrib\date\date_popup\date_popup.module).

To reproduce, create a form with a date-element:

$form['optional']['birthday'] = array(
    '#type' => 'date', 
    '#title' => t('Birthday'),
);

The error shows up on the page with the form after refreshing the page.

Could not avoid the error on any drupal 7/date 7 combination. Applied datepop_20110306.patch to date-7.x-2.x-dev on Drupal 7.x-dev and I cannot reproduce the error.

patch from hadsie

#24 works fine for me thx

@Sborsody, the errors you report in #4 bear no resemblence to the error in the original issue. I don't see how there can be a relationship.

@adriaanm, the element type[#date] is not handled by the date popup module, that is a core element, can't see how that can be an issue.

I am still trying to find a way to reproduce the issue. The '#date_format' is created in the element_info, it should never be empty.

We had someone do a D6-D7 migration, that's how we started getting these errors.

#24 works for me

This error appears because the function date_popup_process_date is seen as a default process function for theme('date', ...) calls, i.e. for elements that have '#theme" = 'date', i.e. for normal date elements ('#type' = 'date'), not date_popup elements.

So any patch that uses conditions to prevent the warning from appearing is misleading, the function should be renamed! Not sure what should/could be the name, but I guess that date_popup_process_date_popup might do, though that will serve as default process handler for calls to theme('date_popup', ...)... Not sure if that is intended. if not, try date_popup_element_process_date_part (and date_popup_element_process_time_part as that will have the same issue if there is theme hook defined for 'time')

FYI: The logic that rebuilds the theme and searches for process and preprocess handlers can be found in file includes/theme.inc, function _theme_process_registry(), and the code that looks like:

            $prefixes += module_list();

            ...

            if (function_exists($prefix . '_' . $phase . '_' . $hook)) {
              $info[$phase_key][] = $prefix . '_' . $phase . '_' . $hook;
            }

#24 patch works for me too. although it may be a temporary fix, at least it removed the error for now.

subscribing...

Using the latest dev version (6/28/2011) I get the same error(s)

Notice: Undefined index: #date_format in date_popup_process_date() (line 249 of /home/content/21/7420121/html/sites/all/modules/date/date_popup/date_popup.module).
Notice: Undefined index: #date_format in date_popup_date_granularity() (line 176 of /home/content/21/7420121/html/sites/all/modules/date/date_popup/date_popup.module).
Notice: Undefined index: #date_format in date_popup_process_date() (line 249 of /home/content/21/7420121/html/sites/all/modules/date/date_popup/date_popup.module).
Notice: Undefined index: #date_format in date_popup_date_granularity() (line 176 of /home/content/21/7420121/html/sites/all/modules/date/date_popup/date_popup.module).

This is on a page that doesn't even have a 'date' field on it (?).

I've attached a screen snapshot.

Good detective work fietserwin! I'm not sure I would have figured that out. I just committed a change to rename the functions.