Closed (fixed)
Project:
Project
Version:
4.7.x-2.x-dev
Component:
Miscellaneous
Priority:
Minor
Category:
Task
Assigned:
Reporter:
Created:
22 Dec 2006 at 18:10 UTC
Updated:
5 Jan 2007 at 19:30 UTC
Jump to comment: Most recent file
in reviewing the 5.x port (http://drupal.org/node/99759) chx pointed out a line that was wrapped in t() which has no translatable parts. ;)
$link = l(t('%name (%count)', array('%name' => $term->name, '%count' => $term->count)), check_url("$path/$term->tid"));
furthermore, l() validates both its args (check_plain() on the title, check_url() on the link) unless you go out of your way to specify TRUE for the last argument ($html).
so, this just needs to be:
$link = l($term->name .' ('. $term->count .')', $path/$term->tid);
can i get an amen? ;)
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | project_bogus_t.patch_1.txt | 847 bytes | dww |
| project_bogus_t.patch.txt | 845 bytes | dww |
Comments
Comment #1
heine commentedamen.
Comment #2
heine commentedNeeds quotes: $path/$term->tid
Comment #3
dwwComment #4
heine commentedamen II.
Comment #5
dwwcommitted to HEAD, DRUPAL-4-7--2 and DRUPAL-4-7.
thanks, heine. ;)
Comment #6
(not verified) commented