Posted by chx on November 26, 2006 at 10:08am
| Project: | Project |
| Version: | x.y.z |
| Component: | Projects |
| Category: | task |
| Priority: | critical |
| Assigned: | dww |
| Status: | closed (fixed) |
Issue Summary
It's a beginning...
| Attachment | Size | Status | Test result | Operations |
|---|---|---|---|---|
| project_5_0.patch | 5.03 KB | Ignored: Check issue status. | None | None |
Comments
#1
And the info file.
#2
version = VERSIONin a .info file is only for core.contribs should use:
version = "$Name$".also, this is obviously not done yet, so "needs review" is a little misleading. ;)
but, thanks for getting this started!
-derek
#3
it's CNR because I would like people to tell what's broken still :)
#4
chx: give me a break... your patch is 95% broken, how on earth can you claim it doesn't "need work"? ;)
anyway, i mostly finished this task on my flight home from madison just now. i need to sleep, so i'm not going to extract what i did and post it as a patch here, but no one else should work on porting project or project_release for now. it's basically done, and just needs more testing. i'll post a patch-in-progress here ASAP. part of the problem is i need to merge everything from DRUPAL-4-7--2 branch since the 4.7.x-2.0 release, but i'm not quite ready for a 4.7.x-2.1 release. that'll happen Real Soon(tm), too. then we can cleanly patch against HEAD.
cheers,
-derek
#5
Now why didn't I come here first and read that ;)
Oh well, here's my version of the port to Drupal 5 anyway, it may be of some use. As with the cvs.module port, I don't have a full set-up to test everything so careful review would be advised :)
#6
:( oh no, that duplication of effort was exactly what i was hoping to avoid by my email to the infra team as soon as i got back connected to the net last night. alas. and, someone else just emailed me via my contact tab that they started a patch, too. *sigh* oh well, such is the inevitable outcome of my taking so long to get this done.
i'll definitely look at your patch and compare with my changes. either way, i'll give you shared credit in the commits. ;)
thanks,
-derek
p.s. unlike chx's pathetic attempt, this patch from AjK is finally "CNR"-worthy. ;) (just kidding chx, i still love you... i'm only making fun).
#7
I'm the guy that sent you the email. I've got it working, but would rather wait for your update though. I have some other dependent code that I'm in the process of upgrading. There were several changes that I had to make that I wasn't completely comfortable with. One in particular was the handling of forms. It appears to be a little different usage of 'post' now.
Another issue that I found was the commented out section(s) regarding the fileapi. The release form in the version I had, currently doesn't do anything with the entry field. Has there been a patch to address this? The comment basically says waiting for final fileapi.
thanks,
Scott
#8
Setting back to "code needs work" as I think my patch is duff (good job dww has done one too!). Read this issue comment to understand why I think my work on this is wasted: http://drupal.org/node/103956#comment-168201
#9
here it is. i'm pretty sure this is everything essential. there are a few fixes in this patch that should probably be split out and backported to 4.7.x-2 for immediate deployment on d.o:
however, for now, i'm just including all of the above in the full patch. there are also a few optional 5.x porting things that i did *not* do. this patch is basically the minimum changes to get project + project_release to work at all. there's additional cleanup/functionality possible via:
none of those are critical for the d.o upgrade, so i'm not planning to work on them at this time. they can be handled in separate issues when the need arises. i want to get this reviewed/tested and committed to HEAD ASAP so we can get cvs.module tested and committed (http://drupal.org/node/101150) and move on to the project_issue.module port (http://drupal.org/node/103956).
cheers,
-derek
#10
new patch after i committed some minor code cleanup stuff to HEAD and other branches...
#11
missed a spot that was touching
$_POST['edit']and fixing the version in the project.info file again. ;)#12
i ended up committing project.info to HEAD to test http://drupal.org/node/104217, so here's a new patch that doesn't include that.
#13
after discussion w/ merlinofchaos in IRC, we decided it was best to use a new /admin/project block for all the project-related admin pages (settings for project, project_release, project_issue and cvs, plus the cvs accounts and cvs repositories pages).
#14
left a little debugging output in the last patch.
#15
i noticed the release node add form is broken if you don't define any API compatibility taxonomy terms. this could just be a bug in general, unrelated to the port, but i wanted to set this back to needs work for now. it doesn't really effect the d.o upgrade (since we clearly use this taxonomy) but it'd be worth investigating and fixing.
#16
yay! (sort of) -- the bug mentioned in my previous comment exists in 4.7.x-2.*, too. it's not specific to the 5.x port, it's just broken in the underlying code. ;) http://drupal.org/node/104683. setting this back to needs review, since the port itself isn't what's breaking this.
#17
after committing #104837 to HEAD, the old patch didn't apply cleanly anymore.
#18
forgot to port package-release-nodes to the new t(). doesn't seem to be anything else in the API change that effects that script.
#19
committed to HEAD and installed on s.d.o (to make it easier for others to test).
i'm still leaving this issue as "needs review", since i'd appreciate more reviews and testing...
thanks,
-derek
#20
i'm going to give up on people reviewing these porting patches, so i'm going to mark them as fixed now.
#21