Closed (fixed)
Project:
Project
Version:
5.x-1.x-dev
Component:
Releases
Priority:
Critical
Category:
Bug report
Assigned:
Reporter:
Created:
28 Dec 2006 at 06:59 UTC
Updated:
19 Jan 2007 at 23:01 UTC
Jump to comment: Most recent file
on s.d.o right now, only users with "administer projects" permissions can create new release nodes that have a "Drupal Core compatibility" taxonomy term associated with them. :( this majorly cripples the functionality of the release system in a few important ways, hence critical.
i'm pretty sure i know what's going wrong, but i haven't actually looked into the code yet.
i've verified the problem does *not* exist on a 4.7.x-2.* test site, and it's not happening on d.o, so this is just a bug in HEAD, caused by the 5.x port: http://drupal.org/node/99759.
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | project_release_taxonomy_D5.patch_4.txt | 5.85 KB | dww |
| #7 | project_release_taxonomy_D5.patch_3.txt | 5.72 KB | dww |
| #5 | project_release_taxonomy_D5.patch_2.txt | 3.73 KB | dww |
| #2 | project_release_taxonomy_D5.patch_1.txt | 4.07 KB | dww |
| #1 | project_release_taxonomy_D5.patch_0.txt | 1.07 KB | dww |
Comments
Comment #1
dwwyup, it's another case of the new taxonomy array (http://drupal.org/node/24023) confusing our code. see http://drupal.org/node/101150#comment-168755 for how i solved it in cvs.module. i should probably move
_cvs_get_option_from_taxo()out of cvs.module and into project.module asproject_get_option_from_taxonomy(), since the only times cvs.module uses it are incvs_alter_project_release_formwhich can only happen if project + project_release are enabled, anyway. i'm thinking project is better than project_release, since this bug might surface in other places in project's special-case code for taxonomies. this way, everyone could benefit from the sameproject_get_option_from_taxonomy()code. a quick hack in my local workspace just directly calling_cvs_get_option_from_taxo()in the right way solves the bug. see attached (hack, needs work) patch.Comment #2
dwwsomething like this.
Comment #3
dwwnow installed on s.d.o. seems to work to add release nodes as a user without "Administer projects" perms.
hunmonk, care to test/confirm? ;)
Comment #4
dwwhrm, although in related news, the "Categories" fieldset itself has disappeared in this case. not sure why. :( still works on d.o, so it must be something about the D5 port... however, before i dig into that, anything else "needs work" in here? ;)
thanks,
-derek
Comment #5
dwwok, the lack of fieldset is by-design from the new D5 UI. if there's only 1 selector in the taxonomy, there's no fieldset.
here's a new patch assuming that http://drupal.org/node/24023#comment-171433 gets committed to core. wishful thinking perhaps... ;) if not, we're back to patch #2 above.
Comment #6
dwwsince http://drupal.org/node/24023#comment-171441 got committed, this is now ready. committed to HEAD and installed on s.d.o.
Comment #7
dwwif http://drupal.org/node/24023#comment-171782 gets committed, we need to fix our usage of form_get_option_key()
Comment #8
dwwthat function will probably change name to form_get_options(). we'll need a new patch in here.
Comment #9
dwwhttp://drupal.org/node/24023#comment-174110 was committed, so here's the new patch for this.
Comment #10
dwwtested on s.d.o with the help of some kind souls in IRC. committed to HEAD and installed (for real) on s.d.o.
Comment #11
(not verified) commented