Drupal 5.x support

Just tried it with 5.0 - and I think the moderation system has changed with Drupal 5. There is no link for "New revisions in moderation."

Here is the patch code required to install it. Its a small start - but it looks like this module will need some work.

The whole moderation system has been removed from core in Drupal 5! Instead you can use the contributed "modr8" module (http://drupal.org/project/modr8).

Please note as well that after a discussion of more than a year, a patch by drumm got into core, changing the behaviour when approved content gets edited (see: http://drupal.org/node/38451).

We will need to reconsider how things should work in the future...

Regards, Pancho

subscribing...

This module sounds great, but I've upgraded to 5.1 on all my sites now...

I've started a port, though it may take some time... I have been dreading working on this because there are a lot of things that happened in the 5.x release cycle that, although they make perfect sense for 90%+ of websites out there, make this trickier to do now.

Thanks a lot for the patch, jimmy! I've combined your changes into mine and committed it. More details at the 5.x port issue. I marked this one as a duplicate, since that's the main issue where 5.x stuff is being discussed.

I kept the "revision in moderation" option inside the node_options_$type array as we discussed on IRC.

I removed hook_help() and the log stuff entirely, as we don't need that anymore in 5.x.

I didn't bring over the settings page, mainly because I don't think the 'admin shouldn't get revisions sent to queue' thing should be a setting, really.. that's how the module should just work... We should base it on permissions.

Let's discuss that part further over in http://drupal.org/node/113830.

I committed an initial batch of changes to the HEAD branch. Thanks to cbutera for kicking it off, and jimmygoon for making a TON of progress!! All the menus and checkboxes and stuff should be at their normal places now.

Module currently does not work yet. Known issues:

a) Nodes keep popping out of revision control mode. This is a core bug.
b) Possibly because of a), the whole "leave the old thing there while new revision sits in moderation" (you know, the whole point of the module? ;)) isn't working either.

I'm spent, so will try looking at this again tomorrow.

LOL oops. :) Wrong issue.

!?

Ok, I guess I'm more tired than I thought. ;)

#5 is a reply to the wrong issue, I meant. :P

Ok, the module actually appears to work just fine with that patch above... and won't work at all without it. :( I've marked it critical, so hopefully it'll go into Drupal 5.2. :(

There's one exception: there's no way (with this module alone) to make the first revision go into moderation. The "In moderation queue" checkbox was removed in Drupal 5.

So I'm probably going to make it so that when you enable "revisions in moderation", both "revision" and "moderation" functionalities are auto-enabled for the node. I could add the checkbox back, but modr8 already does that and I don't want to fight with it over who gets to set it. ;)

Also, edit tab is fubar.

"edit this revision" I meant.

Ok. edit link is fixed.

I've decided the following:

a) This module doesn't care about the node's state before its first revision is made; use modr8 or even just set the node to unpublished by default.
b) There's enough call for this module that I'm going to make a development 5.x release for it now, although there may still be bugs. I'll put in huge blinking bold letters or something that the patch from that other issue needs to be applied for this to work. I spent some time figuring out how I could make the module work around that limitation, and only ended up with a headache. :P I'll lobby to get it into 5.2.

So, marking this issue fixed now. If there are follow-up problems, please post them as other issues.