Support for taxonomy_menu module URLS in translation.module

Patch looks ok. But can't we use the same 'translation_taxonomy_tids' for both taxonomy and taxonomy_menu ?

I don't know if the patch provided is for 4.7.x, but for sure it doesn't work for 5.x.

I had the same problem and following the hints from this patch I made the translation module work with taxonomy menu this way:

Modify the function translation_url this way:

function translation_url($url, $lang) {
  global $i18n_langpath;
  // If !url get from original request
  if (!$url) {
    $url = _i18n_get_original_path();
  }
  // If url has lang_prefix, remove it
  i18n_get_lang_prefix($url, true);
  // are we looking at a node?
  if (preg_match("/^(node\/)([0-9]*)$/",$url,$matches)) {
    if ($nid = translation_node_nid($matches[2], $lang)) {
      $url = "node/$nid";
    }
  }
  // or a taxonomy term
  elseif (preg_match("/^(taxonomy\/term\/)([^\/]*)(.*)$/",$url,$matches)) {//or at a taxonomy-listing?
    if ($str_tids = translation_taxonomy_tids($matches[2], $lang)) {
      $url = "taxonomy/term/$str_tids". $matches[3];
    }
  }
 <strong> // or a taxonomy_menu link
  elseif (preg_match("/^(taxonomy_menu\/)(.*)$/",$url,$matches)) {
    $tids = explode ("/", $matches[2]);
    $vid = array_shift($tids);    
    if ($str_tids = translation_taxonomy_menu_tids($tids, $lang)) {
      $url = "taxonomy_menu/$vid/$str_tids";
      }
  }</strong>
  return $url;
}

Where $tids is the array that holds VOCABULARY_ID/TERM1_ID/TERM2_ID. $vid is the ID of Vocabulary that we have to strip off the chain of taxonomy terms.

2) Then, add the translation_taxonomy_menu_tids function

/**
 *Returns an url for the translated taxonomy_menu listing, if exists 
 *
 *  $tids: array of term ids at the tail end of a taxonomy_menu URL
*/ 
function translation_taxonomy_menu_tids($tids, $lang) {

$translated_tids = array();
$separator = "/";
foreach ($tids as $tid)
{
  
  if ($translated_tid = translation_term_tid($tid, $lang)) {
      $translated_tids[] = $translated_tid;
    }
}


if (!empty($translated_tids[0]))
{
  return implode($separator, $translated_tids);
}
else
{
  return implode($separator, $tids);
}
}

This function looks different than the one provided in the patch, since it uses the translation_term_tid rather than translation_node_nid function to translate the chain of terms.

I made it work in a simple environment with VOCABULARY/TERM (no nested taxonomy).

Could someone make further test about this and provide an official patch?

Thank you,

Paolo.

Errata Corrige

In the first code chunk above I mentioned to put the changed code between STRONG tags... but...

Anyway the correct code is that:

 // or a taxonomy_menu link
  elseif (preg_match("/^(taxonomy_menu\/)(.*)$/",$url,$matches)) {
    $tids = explode ("/", $matches[2]);
    $vid = array_shift($tids);   
    if ($str_tids = translation_taxonomy_menu_tids($tids, $lang)) {
      $url = "taxonomy_menu/$vid/$str_tids";
      }
  }

Sorry guys...

I just post a back port of this code for version 4.7 here. Please apply it to that version too for others to enjoy. Works correctly with multilevel taxonomies.

For version 4.7 the same code is inserted in function translation_url as proposed by pulpzebra :

// or a taxonomy_menu link
  elseif (preg_match("/^(taxonomy_menu\/)(.*)$/",$url,$matches)) {
    $tids = explode ("/", $matches[2]);
    $vid = array_shift($tids);   
    if ($str_tids = translation_taxonomy_menu_tids($tids, $lang)) {
      $url = "taxonomy_menu/$vid/$str_tids";
      }
  }

The function translation_taxonomy_menu_tids is different however. In 4.7 the function translation_taxonomy_tids doesn't seem to exist yet, so I just used translation_term_get_translations instead:

/**
*  Returns an url for the translated taxonomy_menu listing, if exists 
*
*  $nids: array of node ids at the tail end of a taxonomy_menu URL
*/
function translation_taxonomy_menu_tids($tids, $lang) {

$translated_tids = array();
$separator = "/";
foreach ($tids as $tid)
{
 
  if ($translated_tid = translation_term_get_translations(array('tid' =>$tid))) {
      $translated_tids[] = $translated_tid[$lang]->tid;
    }
}


if (!empty($translated_tids[0]))
{
  return implode($separator, $translated_tids);
}
else
{
  return implode($separator, $tids);
}
}

Sorry, but no time to create a patch now. I just attached the modified module.

In comment http://drupal.org/node/108070#comment-280343 I don't understant the preg_match...

(preg_match("/^(taxonomy_menu\/)(.*)$/",$url,$matches))

Perhaps it's me but why the "^" operator (négation)? Whe search the "taxonomy_menu" chain... no?
I think this is more correct:

(preg_match("/(taxonomy_menu\/)(.*)$/",$url,$matches))

No?

Thank you, guys, you are my salvation! I needed a functioning multilingual menu for my site www.esperanto.info and the other solutions, e. g. translating menu items through string translation, just didn't cut it. I'm now using pulpzebra's solution in a nested taxonomy setting and it works great. Thanks so much! Could somebody add this to the next official release?

Now the only thing that I'd like to see with regard to taxonomies in the menu is that they automatically jump to the article if somebody clicks on a taxonomy menu item/category with only one article in it, while still listing every article if there are several. This would add to usability imho. Unfortunately even as a PHP programmer I'm utterly lost in Drupalese code, but I'm ready to pay $50 to whoever can implement this little extra, ideally as something you can switch on or off somewhere in the admin settings. If you're interested in taking on the task, contact me at yutian.mei@gmail.com .

Judith

I don't like to apply a patch without understanding what is happening. It seems to be something Judith likes, and probably I would like it as well, but please explain in different words what this patch is solving. (I haven't started making the translated menus yet, but I do know how the use strings for translation works).

Subscribing,
greetings,
Martijn

I am too am trying to override the urls that taxonomy_menu produces and this thread was the closest thing I could find I'm sorry for the outdated response.

It changes forum urls such as

drupalSite.com/forum/17

with a 'category' url such as

drupalSite.com/1/2/17

I want to switch 'category' with 'forum' in the path and strip the 1/2/ so that the output matches the original url again.

Thank you for your insight.

Hello?

Aaaaaaaah!

Is anybody still here.

Hi,
I did exactly this! You can change category to forum on admin/settings/taxonomy_menu for taxonomy_menu.
You can strip the 1/2 with custom_url_rewrite in your settings.php.
Is this enough info to get you going?

greetings,
Martijn

Only critical bug fixes for 5.x.