when i first added the setting that restricts which projects can edit their cvs repository (http://drupal.org/node/59504) i didn't think of just making it per-user, not per-project, and using the 'administer projects' permission instead. just using the permission makes much more sense, removes a potentially confusing setting, and reduces the # of settings that have to be parsed/loaded on every page. ;) the new release system makes heavy use of 'administer projects' permissions, so this seems like a natural fit.
i'll be rolling a patch for this soon. stay tuned.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | cvs_repo_alter_by_permission.patch_1.txt | 4.39 KB | dww |
| #1 | cvs_repo_alter_by_permission.patch.txt | 4.26 KB | dww |
Comments
Comment #1
dwwtested locally as both project admin and regular user. tested editing existing projects and creating new projects. everything works as expected. while i was at it, i added some additional validation just to be extra careful.
Comment #2
dwwmodified to use
variable_del()at killes's suggestion.Comment #3
AjK commentedApplies clean to fresh HEAD co. I don't have a full "scratch" test env to run this on but I can say a) it didn't break any of the existing test projects / repos stuff I already had set-up and b) works fine when adding new stuff. :)
Comment #4
dwwcommitted to HEAD and DRUPAL-4-7--2 (i don't want to change this stuff in the stable 4.7.x-1.* series).
thanks for the review AjK!
Comment #5
(not verified) commented