[D6] Nodeorder Field

Hello, Nor4a. You need to create a sandbox project, and provide the link here.

A better status.

One more thought, since this extends nodeorder it would be great to get one of the nodeorder maintainers to comment here.

Reviewing

There is nothing in the repository but a .info file.

Nothing to review.

You can remove the $Id$, as we no longer use those.

You can remove the version string from the info file. The packaging system is responsible for that.

You should remove the copyright and license information:

 * Copyright 2011 Normunds Puzo, IDYNAMIC, Ltd.
 *    
 * Licensed under the GNU Public License

I'd like to see all functions documented.

But it basically looks like it will be OK. I didn't try it out.

When you've fixed these things, put it in "needs review"

Updating priority according to the new project application priority guidelines. The application's priority should be set back to normal once a reviewer responds to your application and the application review process has continued.

I was going to call it good, but was too annoyed by the non-function headers to do so. Please fix some things.

1. Please remove the copyright statement. Please see http://drupal.org/licensing/faq

2. When I asked for function headers I didn't mean useless machine-generated uncommented headers like this

 * Helper function to load and show the node siblings in taxonomy
 *
 * @param unknown_type $tid
 * @param unknown_type $nid
 * @param unknown_type $order
 * @return unknown

Please see http://drupal.org/node/1354#functions (and read that whole page).

I'll try to pay attention when this gets put back to needs review. Sorry to bounce you back again, but those function headers just need to be done well.
I meant headers that commented what the

The applicant has been contacted to ask if the application is abandoned.

Getting started with an automated review:

It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.
Review of the master branch:

• README.txt is missing, see the guidelines for in-project documentation.
• Remove "version" from the info file, it will be added by drupal.org packaging automatically.
• Drupal Code Sniffer has found some code style issues (please check the Drupal coding standards). See http://ventral.org/pareview/httpgitdrupalorgsandboxnor4a1090980git.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. Get a review bonus and we will come back to your application sooner.

It would be great if your commit messages have more detail then "x" ;-).
(Also see Commit messages - providing history and credit.)

Please take a moment to make your project page follow tips for a great project page.
Also make your README.txt follow the guidelines for in-project documentation.

Dunno about d6 & cck but I think the hook_install(), uninstall(), enable() and desable() stuff should be in a .install file

check_plain(t('Changed order in %term! ', array('%term' => $term->name))) : '')
t() already check_plains $term->name by %/@ you don't have to do that twice.

in some places your concatenating the strings of hell, could you put some linebreaks in to get this more structured?

1. Agreeing with #12, these copyright lines should be removed from the readme file
2. Please provide some basic installation and usage instructions into your readme (also have a look at typical readme styles and structures: http://drupal.org/node/447604)
3. .js, .module: make the comments follow coding style standarts and use /*[multiple lines]*/ or //
4. .install: /**remove these single spaces at the beginning to correct indentation
5. begin all comments uppercase and end them with fullstop, !, ?
6. $matches[check_plain($r->title) . ' [Nr:' . $r->weight_in_tid . ']'], I'm pretty sure that you don't have to check_plain() the keys of the $matches array. (see user_autocomplete())

As I only have a very limited knowledge of d6 and cck I got to stop here, sorry.

regards

We do really need more hands in the application queue and highly recommend to get a review bonus so we can come back to your application sooner.

hi... i have installed this module with nodeorder module. you can see my attachments where in node create page (field_view.png) the field is not formatted according to this module .
let me know if I missed some settings.

even if i change select options to "before" or "After" the field is not displaying only field help text is showing. "Previous element", "Current sequence" and "Next element" are still showing no value.

Hi, I have installed this module with nodeorder module, and following comment #23 and #25,

• module settings works fine,
• but now, if i change select options to "before" or "After", autocomplete option shows, but isn't working (I have a lot of content, and two other autocomplete fields in the node that works), see my attachment.

Closing due to lack of activity. Feel free to reopen if you are still working on this application.