I have a colorable theme that cannot be changed when I enable this module

Good to know; I'll check it out in a couple of days

Has to do with the order of the $vars['css'] and drupal_get_css() array merge. This patch has been committed. A better solution might be figured out in the future.

This is still not working properly with the color module and the theme Pixture Reloaded. When the colors are changed on the theme settings page it does not change throughout the site. The only page that correctly changes to the new colors is the Advagg administration settings page.

@BullMoose
Can I get the output from an advagg debug watchdog entry? Be logged in as user 1 and hit a page with ?advagg-debug=1; go to the watchdog (admin/reports/dblog) and copy the that entry into a file and attach it here. Thanks!

Thanks for the response! The debug message is attached.

I see the issue. Regression came from this commit #1172684-18: Not compatible with LESS CSS Preprocessor. I switched $css_func and $css_var around when calling advagg_merge_array(). I'm guessing I did that for a reason so I need to have a color module processor function that will replace sites/all/themes/pixture_reloaded/style.css (from $css_func) with sites/default/files/color/pixture_reloaded-ade91d69/style.css from (from $css_var ).

Color module uses this for its path: file_directory_path() . '/color' so using this I can start to replicate what is in the _color_page_alter() function and do the replacement.

Can you test this patch? And if it doesn't work, could you attach another debug output so I can get this working for you?

I'm having the same basic problem.. compounded by the use of Domain Access. So all of my domains end up having the same 'default' color scheme. I turned off all of the settings relating to CSS in hopes the module would still work with Javascript but I still get the same color. Uncheck the 'Enable Advanced Aggregation', refresh my screen, and the colors go back to their correct values.

I imagine the fix for this issue will fix things for me as well. I can test and such if needed.

Test #8

I applied the patch, verified it was applied, cleared Drupal caches, and rebuilt the AdvAgg cache but it didn't seem to make any difference for me. I still get default colors with AdvAgg enabled, immediately switches to correct colors when I disable and refresh.

I will try to get you some debug text. And keep in mind I have Domain Access going and that may make it even more complicated. Thanks.

Here is the debug text:

See the issue. strpos should be used instead of substr. Error due to me copying the advagg_css_array_fixer() function as a starting point and not switching it out. Attached patch should fix the issue.

Tested patch from lucky #13 and it works gloriously! I really appreciate such a quick turnaround on that bug fix. Bravo!

Woohoo! That worked for me also. They need a 'buy maintainer a beer' buttons on here. Thanks for getting on that so quickly. Very helpful.

Crap.. didn't mean to change it to 'needs work'. Sorry about that. Changing back.

*sigh* It looks like it's working on our default domain but the other domains are staying on the default color. I think it's only an issue when combined with Domain Access. I'm not sure it would be worth a lot of work for a pretty unusual use case.

If you are itching to fix AdvAgg when combined with Domain Access let me know and I can do the testing, etc. Thanks.

@FunkMonkey
Send me a debug dump from one of the sites using domain access :)

Here ya go. Thanks!

domain_theme_set_variables() is what's changing it. Doing this the "correct" way is going to be a pain so I think this patch will work for 99% of the use cases.

Can you test this?

That seemed to do the trick! I'm doing some more testing but so far it looks good. Wish I had some of your mad skillz and could figure this stuff out better for myself :) but thank you.

#20 has been committed.