[D7] Adminer

I've taken a quick look at your code. It's ok, but there are some issues with formatting (4 spaces instead of 2).
Use Coder module to see your code formatting problems.

I also have some concerns on 'use adminer without login' feature.
can you please explain how it works? it's important to be 100% sure that it's not a security issue.

See our repository usage policy, specifically "DO NOT include code from a non-Drupal project in the repository."

Looks like a lot of the files that are easily downloadable from http://www.adminer.org/ are included in the Git sandbox repository.These should be removed from the module, and instead provide instructions to users to download them. The libraries API offers a way to do this that many projects use.

Closing, feel free to re-open if this was a mistake.

You need to set the status to "needs review" if you want to get a review. See also http://drupal.org/node/532400

We are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)

Hello,

It looks good. I noticed a couple of lines that are way over 80 characters and could have been broken down, but I don't see that being an issue.
I would only recommend you to create a branch and set it as default.

http://drupal.org/node/1127732
http://drupal.org/node/1659588

Regards,
Caio

Minor coding standard issues or git branch naming problems are not application blockers.

Hi, I have installed all the plugins as you mentioned, but I have got an error.
You have encrypted code in adminer.3.4.0.php so it is hard to say why, I'm getting this error.

In order to help users that just installed the module please provide:
A configure link (in adminer.info):
configure = admin/config/development/adminer/settings
A help function (in adminer.module):

<?php
/**
 * Implements hook_help(). 
 */
function adminer_help($path, $arg) {
  switch ($path) {
    case 'admin/help#adminer':
      // Return a line-break version of the module README.txt
      return _filter_autop(file_get_contents( dirname(__FILE__) . "/README.txt"));
      break;
  }
}
?>

Hey everyone,

I have just reviewed this module code (my first review ever) and here are the results:

1. It works. At least on my test installation - so if it doesn't work under any other specific requirements I feel it should be resolved through the issue queue and it is definitely not a showstopper for this module to get "full project" status.
2. Licensing - no issues with it, all the downloadable code has been removed, LICENSE.TXT is not included in the git repository.
3. Module duplication issue - I haven' t been able to find any similar project.
4. Module is utilizing Drupal API where appropriate, all the strings are localized(t() function usage) and hook_menu 'title' doesn't use t() which is a sign to me that the developer knows what he is doing.
5. Security - didn't see any concerns here, module provides permissions to control who can use it.
6. Code is following Drupal coding standards and is clear and understandable, it took me about 15 minutes to get what every line does, even the magic adminer_object() function ;)

Here are some minor enhancements:

1. Add description to the Adminer menu item so it is shown on the "Configuration" page ("admin/configure").
2. Add description to permissions.

These are definitely not the showstoppers, so I'm marking it as "reviewed and tested by the community".

Side note: after approving and closing this one we need to close another application review from the same developer (http://drupal.org/node/1676282) - appears that he just didn't notice the rule that there should be only one application review per user open at the same time.

Thanks
AndyB

Thanks for your contribution!

chx has updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.