I have used flickr filter without size parameter for a long time in D6. For example [flickr-photo:id=230452326]. It's been good until D7. Is it possible to make it works also in D7?

For now I have added to flickr_filter.module the line 'if(!isset($config['size'])) $config['size']= "-";'. (Before line 77)

CommentFileSizeAuthor
#13 extend_also_to_sets-1104610-13.patch880 byteslolandese
#10 default_size_D6-1104610-10.patch2.17 KBlolandese
#4 default-size-1104610-4.patch2.56 KBlolandese

Comments

dantz’s picture

dantz commented

If I dont give a size the image will be displayed but I'll get a notification like

Notice: Undefined index: size in flickr_filter_callback_photo() (Line 77 of /var/www/virtual/PATH/html/sites/all/modules/flickr/filter/flickr_filter.module).

lolandese’s picture

lolandese commented

The patch at http://drupal.org/node/1440918 solves the issue and adds some other image sizes as well.

lolandese’s picture

lolandese commented

Check out the latest dev. It still doesn't solve the error message, therefore leaving this active.

lolandese’s picture

lolandese commented
Status: Active » Needs review
StatusFileSize
new default-size-1104610-4.patch2.56 KB

The attached patch:

  • uses a default size if the size parameter is omitted
  • lets you choose a default size on the settings page.

Please test. If satisfying we will commit.

Remember:

  • Apply the patch against GIT
  • Download the patch to your working directory. Apply the patch with the following command: git apply -v [patchname.patch]
lolandese’s picture

lolandese commented
Status: Needs review » Reviewed & tested by the community

Tested. Works well.

lolandese’s picture

lolandese commented
Status: Reviewed & tested by the community » Fixed

Committed. http://drupal.org/commitlog/commit/2102/86d93e6e2fd8f81c3e707041bd26ccad...

Thanks.

vegancheesesteak’s picture

vegancheesesteak commented

Tested on my upgraded install. Works well. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

lolandese’s picture

lolandese commented
Version: 7.x-1.x-dev » 6.x-1.x-dev
Issue summary: View changes
Status: Closed (fixed) » Patch (to be ported)

Backport to D6.

lolandese’s picture

lolandese commented
Status: Patch (to be ported) » Needs review
StatusFileSize
new default_size_D6-1104610-10.patch2.17 KB

Ported to D6.

lolandese’s picture

lolandese commented

TO DO: The added variable should be removed on uninstall.

lolandese’s picture

lolandese commented
Version: 6.x-1.x-dev » 7.x-1.x-dev

D7 patch attached that:

  • Added uninstall to remove defined variable 'flickr_default_size'.
  • Extended to photosets so a size can be omitted on them as well.
lolandese’s picture

lolandese commented
StatusFileSize
new extend_also_to_sets-1104610-13.patch880 bytes
lolandese’s picture

lolandese commented
Status: Needs review » Fixed

Committed. See http://drupalcode.org/project/flickr.git/commitdiff/442ef9e.

lolandese’s picture

lolandese commented
Version: 7.x-1.x-dev » 6.x-1.x-dev

Commit for D6 see http://drupalcode.org/project/flickr.git/commitdiff/b7485d6.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.