Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
I have used flickr filter without size parameter for a long time in D6. For example [flickr-photo:id=230452326]. It's been good until D7. Is it possible to make it works also in D7?
For now I have added to flickr_filter.module the line 'if(!isset($config['size'])) $config['size']= "-";'. (Before line 77)
Comment | File | Size | Author |
---|---|---|---|
#13 | extend_also_to_sets-1104610-13.patch | 880 bytes | lolandese |
#10 | default_size_D6-1104610-10.patch | 2.17 KB | lolandese |
#4 | default-size-1104610-4.patch | 2.56 KB | lolandese |
Comments
Comment #1
dantz CreditAttribution: dantz commentedIf I dont give a size the image will be displayed but I'll get a notification like
Notice: Undefined index: size in flickr_filter_callback_photo() (Line 77 of /var/www/virtual/PATH/html/sites/all/modules/flickr/filter/flickr_filter.module).
Comment #2
lolandese CreditAttribution: lolandese commentedThe patch at http://drupal.org/node/1440918 solves the issue and adds some other image sizes as well.
Comment #3
lolandese CreditAttribution: lolandese commentedCheck out the latest dev. It still doesn't solve the error message, therefore leaving this active.
Comment #4
lolandese CreditAttribution: lolandese commentedThe attached patch:
Please test. If satisfying we will commit.
Remember:
git apply -v [patchname.patch]
Comment #5
lolandese CreditAttribution: lolandese commentedTested. Works well.
Comment #6
lolandese CreditAttribution: lolandese commentedCommitted. http://drupal.org/commitlog/commit/2102/86d93e6e2fd8f81c3e707041bd26ccad...
Thanks.
Comment #7
vegancheesesteak CreditAttribution: vegancheesesteak commentedTested on my upgraded install. Works well. Thanks!
Comment #9
lolandese CreditAttribution: lolandese commentedBackport to D6.
Comment #10
lolandese CreditAttribution: lolandese commentedPorted to D6.
Comment #11
lolandese CreditAttribution: lolandese commentedTO DO: The added variable should be removed on uninstall.
Comment #12
lolandese CreditAttribution: lolandese commentedD7 patch attached that:
Comment #13
lolandese CreditAttribution: lolandese commentedComment #14
lolandese CreditAttribution: lolandese commentedCommitted. See http://drupalcode.org/project/flickr.git/commitdiff/442ef9e.
Comment #15
lolandese CreditAttribution: lolandese commentedCommit for D6 see http://drupalcode.org/project/flickr.git/commitdiff/b7485d6.