I've basically gone to the flickr field part of the module with a chainsaw and not much of the original code is left (if any).

I've tried to clean things up and make it so that the module makes more sense with the changes made to D7 in relation to Fields.

My main requirement was to insert a photoset where x photos were displayed from that photoset. But I've carried single photo support through with the updates.

It's my first stab at it this afternoon, and I'll probably improve the formatter side of things going forward so (like primary photoset photo only).

Feel free to take a look and tell me what you think. If you want to give me GIT access then I'm happy to commit bits to this branch of the module now and then as needed. I won't have time to look at things outside of D7 and the field submodule however.

Cheers

CommentFileSizeAuthor
#6 switch_instead_of_elseif-1128612-6.patch2.9 KBlolandese
#2 patch_commit_314f662b6873.patch55.38 KBjdelaune
#1 patch_commit_4c6ed8668421.patch29.13 KBjdelaune

Comments

jdelaune’s picture

jdelaune commented
StatusFileSize
new patch_commit_4c6ed8668421.patch29.13 KB

And here's that attachment...

jdelaune’s picture

jdelaune commented
Status: Active » Needs review
StatusFileSize
new patch_commit_314f662b6873.patch55.38 KB

More recent update which uses Flickr API for core API functionality. Put a patch in their queue #1129950: Upgrade phpFlickr to 3.1.

Some of the helper functions I stuck in flickrfield could move into a more central flickr library if needed or maybe even into Flickr API.

BenK’s picture

BenK commented

Subscribing

lolandese’s picture

lolandese commented

Planned to have a look at this. Any updates meanwhile?

Thanks.

physiotek’s picture

physiotek commented

thanks for this submodule this is what i was looking for.
but i have two points:
1. there seems to be no lightbox support for this submodule am i right?
2. i think it would be much simpler for single picture to paste the whole link instead of having to sort the user and the picture id.
thanks,
pht3k

lolandese’s picture

lolandese commented
Issue summary: View changes
StatusFileSize
new switch_instead_of_elseif-1128612-6.patch2.9 KB

Rerolling and breaking down into smaller parts to understand what the code changes try to obtain.

Attached patch replaces a couple of if .. elseif statements with switch .. case to improve code readability.

Would be pretty safe to commit.

lolandese’s picture

lolandese commented

http://drupalcode.org/project/flickr.git/commitdiff/fc3a4a0

Leaving status 'Needs review' for the rest of the original patch.

Thanks.

  • Commit fc3a4a0 on 7.x-1.x authored by jdelaune, committed by lolandese: 
    Issue #1128612 by jdelaune: Using switch instead of elseif statements.
lolandese’s picture

lolandese commented
Component: flickr_field » flickrfield