In regards to #11 & #12 on http://drupal.org/node/1115438, it looks like if you use the dev media release, the folder structure changes such that module_load_include() on line 292 of media_browser_plus.module fails to load the include that contains the media_browser_build_media_item() function. See the attached screen shot.

I have a fix and patch coming along shortly, as pointing to media's inlcude directory fixes the problem.

CommentFileSizeAuthor
#12 mediabrowserplus-1139210-12.patch13.22 KBdiscipolo
#11 mediabrowser_dev6-1139210-11.patch0 bytesdiscipolo
#7 media_dev_restructure-1139210-7.patch1.78 KBmpgeek
#4 media_restructure-1143292-5.patch1.78 KBmpgeek
#1 media_strucure_dependency-1139210-1.patch724 bytesmpgeek
mbp_pre_patch.jpg119.49 KBmpgeek

Comments

mpgeek’s picture

mpgeek commented
Status: Active » Needs work
StatusFileSize
new media_strucure_dependency-1139210-1.patch724 bytes

Here is a patch to Sebastian's version of media browser plus on git (https://github.com/Buesing-Sebastian/Drupal---Media-Browser-Plus). This allows media folders to work when using media-7.x-1.x-dev. Not sure if patching to a dev version of a module dependency is in the realm of best practice.

Sebastian.Buesing’s picture

Sebastian.Buesing commented

There is at least one more similiar include like this that is broken. I encounterd it today too and will add a patch tomorrow. ;-)

makli’s picture

makli commented

I get the following error when I choose a media file in the browser and click on the "edit"-button:
Fatal error: Call to undefined function media_page_multiedit() in .../sites/all/modules/media_browser_plus/media_browser_plus.pages.inc on line 21

mpgeek’s picture

mpgeek commented
Status: Needs work » Needs review
StatusFileSize
new media_restructure-1143292-5.patch1.78 KB

Here's what I've done to make it work....

1. Use the curent dev release of Media (media-7.x-1.x-dev) available from the project page:
http://drupal.org/project/media

2. Use the master branch of Media Browser Plus git from this repo:
https://github.com/Buesing-Sebastian/Drupal---Media-Browser-Plus

Note that this is NOT the branch on d.o, and that according to Sebastian, work is being done to merge these two versions into one stable release. Please correct me if I am wrong.

3. Apply the patch attached to this comment. Note that this patch supersedes the patch located at http://drupal.org/node/1139210, as this patch includes that patch.

Also note that it is possible that issues remain, but at least media mangement is getting closer to stable.

If I had any leverage, I would utilize it to get the interested parties to work on getting Sebastian's external version at least into a dev branch here on d.o.

james.elliott’s picture

james.elliott commented

There is a dev branch of the folders work. It's here http://drupal.org/node/952172/git-instructions/folders

mpgeek’s picture

mpgeek commented

Ah, thanks for the correction, James. Totally new to git on d.o. In any case, it appears that version also needs the patch for it to work with the dev branch of media.

mpgeek’s picture

mpgeek commented
StatusFileSize
new media_dev_restructure-1139210-7.patch1.78 KB

Here is the patch for the folders branch. Sorry about the confusion.

yareckon’s picture

yareckon commented

sub

sanderjp’s picture

sanderjp commented

Subscribe.

Please tell me how to get this working! :'(
I've tried a number of combinations of Media dev and beta4 with Media Browser Plus (the one on the project page, also Sebastian's git version) and nothing works. Either I get the ajax 500 error enabling media browser plus (with Sebastian's version), or all kinds of errors of non-objects (using media-beta4).

I'm wondering if it is possible to release a version that is known to work with a certain media version (preferably beta4)?
Thanks for the good work anyways!

effulgentsia’s picture

effulgentsia commented

@sanderjp: Media Browser Plus beta2, Media beta4, and Media Gallery (optional) beta5 (just released) all work with each other as far as we know. If this combination is causing errors for you, please open a new issue with details. Thanks.

discipolo’s picture

discipolo commented
StatusFileSize
new mediabrowser_dev6-1139210-11.patch0 bytes

here is my attempt at making it work with the current media git checkout of the folders branch.

basically changed the nonexistant functions:
media_load
media_save

and replaced instances of 'media' entities with 'file'

discipolo’s picture

discipolo commented
StatusFileSize
new mediabrowserplus-1139210-12.patch13.22 KB

...
edit: this patch does too much:

$media_entities = file_load_multiple($fids);
in function media_browser_plus_submit is correct. (not $media_entities = media_multi_load)

phai’s picture

phai commented

I'm seeing many people are working on this module creating its own revisions, and someone is trying to merge them (please correct me if it's wrong)...
So my question is: why you don't create a Media_Browser_Plus_2 project under drupal.org starting from this one?
So the work'll be coordinated from the group and Drupal users can obtain a new official project.

betoscopio’s picture

betoscopio
Primary language Spanish
commented

I'm using the folders brach from git on d.o., with media-1.x-dev and media-1.x-beta5, but getting the same error:

Notice: Trying to get property of non-object in _media_browser_plus_folder_list() (line 1038 in media_browser_plus.module).

I see a dialog when i click on "Library" with the message:
"Error getting media."

I have tried with patches #7 and #12, none seems to work in this case.
Am I missing something?

Thanks for your work.

discipolo’s picture

discipolo commented

try http://drupal.org/node/1115438#comment-4616548
its newer

betoscopio’s picture

betoscopio
Primary language Spanish
commented

Thanks discipolo, finally i'm seeing the new intereface, that is a step forward in what i was doing, but i still have problems, posting more info on referenced issue.

ParisLiakos’s picture

ParisLiakos commented
Status: Needs review » Closed (fixed)