Closed (outdated)
Project:
Views Slideshow
Version:
7.x-3.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Anonymous (not verified)
Created:
2 May 2011 at 11:49 UTC
Updated:
9 Feb 2018 at 02:10 UTC
Jump to comment: Most recent
Comments
Comment #1
Monzer Emam commentedThink it's a bug as js script code is already there but not registered.
Anyway by adding the following code to file "views_slideshow.module"
method "function views_slideshow_views_slideshow_widget_info"
it worked for me.
Comment #2
metalinspired commentedIt works. Thank you. You missed one closing bracket :)
Heres the corrected code:
Comment #3
Monzer Emam commentedWhat a shame, don't know how that happened I did copy & past from my code, anyway thanks @metalinspired.
Comment #4
RumpledElf commentedI'm guessing this is the bug that doesn't make the currently active slide on the pager change as the image cycles?
Comment #5
metalinspired commentedYou are right :)
Comment #6
BernieCram commentedHi,
I am using 7x-3.0-Alpha1 and this fixed the active class on my pager. I am using numbers pulled from global:view result counter. Thanks for the code Monzer Emam and metalinspired.
Is there something else which needs to be done to flag this to go into the next version of the module?
Cheers
Bernie
Comment #7
humansky commentedWas able to verify, comment #2 worked for me as well
Comment #8
redndahead commentedI'm showing it working in my test instance. The change in #2 is not necessary and really the wrong way to handle this. The pager handles it's own routing. Are you using the latest development release?
Comment #9
redndahead commentedJust in case it wasn't clear. It is working with just using the latest dev release.
Comment #10
humansky commentedI tested on alpha1 release. I'm glad to hear it is fixed on the dev branch, so on the next release, my code will be overwritten.
Comment #11
redndahead commentedComment #12
BernieCram commentedMy active class issues have been fixed by applying a patch found in this issue http://drupal.org/node/1128930
thanks redndahead
B
Note that the patch has now been added to the dev version, update to latest dev release and active should be working.
Comment #13
Anonymous (not verified) commented@#12 that patch from #4 in that thread indeed was the solution.
Comment #14
georgemastro commentedmany thanks to #2
Comment #16
leisurman commentedIf you installed Views Slideshow Xtra, remove it. activeSlide a started to work for me. I can see it switching in firebug.
Comment #17
mustanggb commentedChecking the 7.x-3.x-dev on 2011-Dec-30 this fix (#2) is not present
Comment #18
BernieCram commentedNo it won't be present as indicated in comment #8, see drupal.org/node/1128930 for the issue which was fixed.
B
Comment #19
mustanggb commented#1128930: If you have a header and bottom pager, they have the same id. has been in dev for a long time and I only have 1 widget in total (a bottom pager) so I don't see how it is relevant to this issue
The active class is still not appearing unless #2 is used, other proposals of how to do this "properly" are welcome
Comment #20
mustanggb commentedOn second investigation I think my issue has been solved thus: http://drupal.org/node/1426156#comment-5574332
Comment #21
BernieCram commented@akamustang, I was just trying to point out that the module maintainer had not wanted to fix the issue in the way suggested in this thread and so you will never see this issue in the change log. Great that your problem is fixed. :)
B
Comment #23
kristen polThis still isn't working. I'm using:
* Views Slideshow 7.x-3.0+18-dev
* jCarousel 7.x-2.6
I've tried various suggestions including #2 but nothing is working to get any kind of *active* class on the pager item.
Since there has been no work on VS since 2012-Apr-24, I'm not feeling confident about finding a fix, but maybe someone has something else they'd like to suggest ;)
Comment #24
kristen polI have a workaround for this issue:
1) Install the json2.js in libraries/json to get the advanced options via the VS settings
2) Click on the Slideshow settings in your view
3) Find the "jQuery Cycle Custom Options" section
4) In "Advanced Options", choose "pager"
5) Add this text into the textbox:
ul.jcarousel-list
6) Click "Update Advanced Option" to add the option
7) Click Apply button
8) Save your view
Once this is done, you will get a class "activeSlide" applied to the "li" elements, e.g. li.activeSlide.
You will *also* end up seeing some numbered links under the pager as well like:
I hid them with CSS like:
Perhaps there is a better way to do this, but it is working for me so I will call it a day! ;)
Comment #25
kumkum29 commentedHello,
it does not work on my site.
I installed the library json2.js. In the Slideshow settings I selected "activePagerClass" and in the textbox I add the class of my divs "views-slideshow-controls-bottom" or "views-slideshow-pager-item-field." But, I don't see the "activeSlide" class in the code of my page.
I'm using version 7.x-3.0 Slideshows +18- dev.
Thanks for your help.
Comment #26
nickdickinsonwilde