call-time pass-by-reference has been deprecated in drupal_load()

THis is confusing, because the error is showing up in one of Drupal's functions, not one of this modules.

Could you try the dev version? There was a call-time pass-by-reference error that may have been fixed in a different place...

Ricky

The dev version fixes this.
If you continue getting the error after clearing your cache, then it is another module generating the error.

These two other modules have the same problem:
http://drupal.org/project/uuid
http://drupal.org/project/sharethis

The dev version worked for me too. Thanks
[benjamin@mountbatten.net]

I can confirm the dev version worked for me too.

Confirmed this is fixed in the latest dev.... might I suggest tagging a new 7.x release?!

Anyways, closing this as its fixed.

I have to do this.. I'm reopening and setting to critical until a new stable release is out.. this bug has gotten me multiple different times on multiple sites.

I saw this problem for the first time today when I tried running a custom module developed on Drupal 6 in a Drupal 7 implementation.
I had made no changes to the code other than to update the .info files to say core = 7.x.

I discovered that you can get the message even if the code isn't executed; it only needs to be parsed.
The following code will produce the message.

Include file called ro.inc contains

<?php 
function actpbra( &$byref ) { }
function actpbrc( &$byref) {  actpbra( &$byref ); }

Main file contains

error_reporting( E_DEPRECATED );
require_once( "ro.inc" );

The conditions you need to satisfy to get the message are:

• pass a parameter by reference - as in the call to actpbra() from actpbrc()
• the 'error' in the code being included from a separate file
• Error reporting set to include E_DEPRECATED prior to the inclusion of the file containing the bad code

The problem is fixed by removing the & on the call to the function that has declared its parameter as being passed by reference.

In this simple example I've not managed to reproduce the apparently incorrect reporting of the message as if it came from the main file... but I'm working on it.

Based on the above, http://drupal.org/node/1166504#comment-5843292, the unwanted & is on line 605 of collapse_text.module
changing it from

    array_walk_recursive($variables['page'], '_collapse_text_preprocess_page_walk_callback', &$found);

to

 array_walk_recursive($variables['page'], '_collapse_text_preprocess_page_walk_callback', $found);

eliminates the message.
This appears to be simpler than the dev fix ... but I haven't checked if the code actually works.

I've found out why I couldn't get the message to be reported from the wrong place #1166504-10: call-time pass-by-reference has been deprecated in drupal_load()
and have now raised an issue suggesting an improvement to Drupal error reporting code. #1525400: Improve problem determination for 'Call-time pass-by-reference has been deprecated' by changing _drupal_error_handler_real()

here is the patch for the fix listed in #11

btw, this error is a result of using php 5.3; which is when this use was deprecated

either fix breaks it for me at dreamhost running php 5.3. Is there another way to suppress the error?

thanks.

I got the same problem and it's gone by stopping the beta modules for my case it was "Publish button modules"
is there in other solution !!?

I'm new to drupal and I've noticed multiple times the suggestion to use the dev version of a module in response to some issue. I was wondering how safe that is on a production site. Does it vary by module? Or is it only OK to use the dev version when a stable release for the same drupal version exists? Also if you use the dev version does your module get updated when a new update is made to the stable release?

thanks in advance

Well i think no one use dev version when other stable one available . also updating issue if it occur might be solved in the stable version so never use dev when stable is available

@ liquidcms

here is the patch for the fix listed in #11

Your patch isn't working. I think you took out the wrong '&'

Your patch removes the '&' from line 614: function _collapse_text_preprocess_page_walk_callback ($val, $key, &$found) {

Which is not the same line as the fix in #11.

Just manually do it at line 605

OK i guess I misunderstood this. You need to take out both '&'s in order for the error to disappear.

So use both #11 and #13. Neither works on its own.

After the latest Drupal core update, this error appeared. It only disappeared after de-activating Collapse Text Module.
The previous messages are not clear.

We tried removing extra character "&" preceding $found on the two instances as indicated without success.

Can anyone confirm a fix for the error?

HI! I'm about to put up a simpler solution and create a release node for a new version. I'm just going to always include the .js file. The amount of trouble that trying to dynamically add the collapse.js file has caused is more than the feature is worth.

Thnku so much cpelham. ur solution worked for me