Delete orphaned field_collection_item entities when they are (programatically) removed from the host entity

Good catch.

When one uses the delete callback of the formatter, the delete is probably going to be issues twice. But as the delete_multiple issues an entity_load on the ids, I guess that shouldn't harm.

+  // Create a bare-bones entity so that we can load its previous values.
+  $original = entity_create_stub_entity($entity_type, array($id, $vid, $bundle));
+  field_attach_load($entity_type, array($id => $original), FIELD_LOAD_CURRENT, array('field_id' => $field['id']));

Why not just use $entity->original?

sub

Is it safe to say that this patch will not help with any pre-existing corrupted nodes? I applied tha ptch and i do not seem to (so far) be able to get the issue to return. However, the nodes which i could not edit before i still can not edit.

a bit more editing for my node and i have still been able to corrupt it and again get:

EntityMalformedException: Missing bundle property on entity of type field_collection_item. in entity_extract_ids() (line 7389 of /home/admin/public_html/mit/includes/common.inc).

not sure what i did that broke the node; will keep testing

i think i was able to still corrupt the node when i cloned the node (#1304214: Doesn't clone properly) and then removed items

subscribe

I'm getting still getting this issue after the patch. When deleting a FieldCollectionItemEntity directly, the reference in the node's collection field remains and triggers an EntityMalformedException.

I thought I would be able to just use
$field_collection_item->delete();
or

  if ($ids = field_collection_field_item_to_ids($node->field_my_field[LANGUAGE_NONE)) {
    entity_delete_multiple('field_collection_item', $ids);
  }

But because of the stale references in the collection field that triggers :
"EntityMalformedException: Missing bundle property on entity of type field_collection_item. in entity_extract_ids() (line 7389..."

I can avoid this by manually removing the collectionfield item from the collection field like

  unset($node->field_my_field[LANGUAGE_NONE]);
  field_attach_update('node', $node);

But shouldn't that be done automatically?

Subscribing... wasn't yet able to reproduce the error yet.

I've got this problem as well and made the following obervation - maybe someone else is able to work his magic with this hint:

So I've got a node I cannot edit anymore, receiving the error:

EntityMalformedException: Missing bundle property on entity of type field_collection_item. in entity_extract_ids() (line 7405 of /srv/www/htdocs/iav.com/data/includes/common.inc).

Now the node id is 8034 and the field_collection_item for that content type is field_global_video. So I checked the database-field: field_data_field_global_video, looked up the line of the entity_id 8034 and found the value 192 in the field: field_global_video_value.

So with the 192 in mind I went over to the field_collection_item table but couldn't find any item_id 192. Since I know that this should be a field_global_video in my case, I just inserted the line manually via PHPMyAdmin.

INSERT INTO `tablename`.`field_collection_item` (`item_id`, `field_name`) VALUES ('192', 'field_global_video');

And voila... the node is editable again. Now this is certainly not a solution, but maybe a hint.

Hi, i have many orphaned field collections items.
Does this patch remove all previous orphaned items ? Or does this patch works only when removing field collection items after installing this patch?

Same question as @TD44 . Does this patch remove all previous orphaned items ? Or does this patch works only when removing field collection items after installing this patch?

I have orphaned field collection items that I can't figure out how to find/see, nor how to delete. Would love to have the answer to @TD44's question! Anyone?

To start, you can use a query like this one to see the orphaned field collection items :

SELECT item_id
FROM
field_collection_item field_collection_item
LEFT JOIN field_data_field_sample field_data_field_sample ON field_collection_item.item_id = field_data_field_sample.field_sample_value
LEFT JOIN node field_sample_field_collection_item ON field_data_field_sample.entity_id = field_sample_field_collection_item.nid
WHERE (( (field_sample_field_collection_item.nid IS NULL ) ))

Then, you can export the result to a comma separated list like this :

$orphaned_ids = array(1,2,3,4,5,6);

And you can delete all the orphaned field collection items with a call to function entity_delete_multiple() like this :

entity_delete_multiple('field_collection_item', $orphaned_ids);

Deleted