Delete/Edit term returns 'Page Not Found'
jupiterchild - February 14, 2007 - 13:03
| Project: | Taxonomy Batch Operations |
| Version: | 5.x-1.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | critical |
| Assigned: | TBarregren |
| Status: | closed |
Description
Drupal v5.0
Select terms to delete with check box, either (individually or as a batch), click delete, this returns a 'Page Not Found' and the item(s) remain undeleted.
#1
Delete and edit have the wrong link
on lines 117,118 you are missing the "content" in the path like this
'#value' => l(t('edit'), "admin/content/taxonomy/edit/term/$term->tid", array(), $destination) . ' | ' .l(t('delete'), "admin/content/taxonomy/delete/term/$term->tid", array(), $destination),
#2
also on line 261 missing "content" like this
return "admin/content/taxonomy/delete/terms/".implode($tids, ',');#3
The fix works fine. Thanks kongeo.
Very useful module, saves a lot of time.
#4
The fix works, here is the patch for the fix.
#5
thank you for this post
with well over 150 terms and assigning content to them all day.
When I went to the terms area ...... to edit a typo,
I'm sure a loud........ "ah oh" --- could be heard across 3 counties.
thanks again
I appened 'Edit' to the post title - I hope no one is offened - as it was both features - I thought appending it might save the maintainer a post or two.
#6
+1
#7
Thanks for patch I needed to delete 14 pages of terms. Saved a lot of time
#8
Thanks for a great module.
Wish the patch be committed to dev version, then I can download.
#9
you can always open the patch file , remove the lines of code that begin with - and add the code the begins with +, if you don't want to learn how to patch a file on your local machine.
#10
thanks for the update! and excellent module.
patch has been applied and module is working perfectly with applied patch.
I thought that some patch could be committed faster based on code changes.
#11
patch works for me, too. Thanks for helping!
#12
any reason for the patch not going into mainline?
#13
Yes, please commit this.
#14
And this should be considered a critical bug since the module is completely unusable without this patch.
#15
Yes, please commit this cause it's a Great module!
Wanted feature: be redirected to the vocabulary terms' list after a batch operation on it.
#16
You mean something like this?
#17
Exactly! Thanks
#18
This is one of four patches that should be committed as soon as possible IMHO. In waiting for that to happen, I have made a bundle of these four patches to simplify the patching. See http://drupal.org/node/166037.
#19
I tried the patches.
They failed.
Perhaps the problem was at my end. I appreciate the efforts of everyone. But this module should be fixed and a new version released.
It would be greatly appreciated.
thanks
#20
To apply the patch in #18 above, just open an terminal and paste following:
wget -q -O - http://ftp.drupal.org/files/projects/taxonomy_batch_operations-5.x-1.x-d... | tar zxvwget -q -O - http://drupal.org/files/issues/taxonomy_batch_operations-5.x-1.x-dev-bun... | patch -p0
I just tried it, and it works as expected.
#21
thanks to everyone who contributed patches; applying the bundle worked like a charm, and i can now stop sweating over messed up categories in my new drupal installation. ghods, i love open source.
#22
I tried the bundle patch as well. It fixed the delete issue but I have attempted to add terms since then and it is simply adding a single term "A". Either the multiple add didn't work before or there is some other issue.
#23
Ignore that previous post. DOH! Had a code page issue with a paste of terms. Patch works!
#24
Hello-
I have read everything and donloaded GNU patch for windows and cannot seem to figure out how to apply this patch, I have shared hosting and I am totally lost any input would be so great. I also downloaded SSH but would rather do a diff patch on windows and then upload it via FTP
#25
Those contribs should be implemented into a new stable release to make it easy. Who's in charge? ;-)
Drawk, do you need to delegate? If ever they agree, would you allow (for example) TBarregren, pleochroic or whoiskevin to make such a release?
In my case, it would be an honor. But it could not be before October.
And, first of all, I would first need to know the rules for releasing a new version of a module. Any link to a HOW-TO would be appreciated!
Greetings everyone here, Arsène
#26
+1 ;-)
Drawk, I will be happy to commit the patches if you are willing to grant me CVS access to Taxonomy Batch Operations.
#27
TBarregren, I will grant you CVS access and drop you a note. Thanks for the offer.
I've been sidelined by personal issues and swamped with client work, haven't had the time to responsibly maintain this module. A hand would be greatly appreciated.
There are also still some features from the 4.7 release that haven't yet made it into the 5.x dev release.
#28
Just attempted to apply the patch, but it did not fix the problem. I am looking forward to this being committed, once life becomes a bit more reasonable for all involved. Thanks!
Maria
#29
Thanks buddies, patching on Mac OS X works great!
Just wish this be commited soon, and why not including this patch (while I'm nt sure it really works)
#30
Also I find it useful to return to the "insert group" form after inserting several terms, For this to work, scroll down to the last line in the module,
Find:
return 'admin/content/taxonomy';And replace by:
return $_GET['destination'];#31
@nanou: Please file a separate issue for your feature request. This issue is about the problem described at the top and the patch in #4.
#32
*ahem* commit
But seriously, this ought to be committed. I'd do some responsible maintainence if given commit (this is a useful mod).
#33
I still see the May 2007 version, so I made the tarball myself with the patch mentioned above to save some trivial work for others. It really works! Thanks for the wonderful module and all the patches.
#34
Thank you xjs. I installed it. I'll let you know if I come accross some problems myself.
#35
This is a critical patch!
I discovered the wrong paths (before reading this) after downloading and installing this module on 19/1/2007. But many people will not look at the source code of the module if they do have this problem
This is NOT OK that this patch has not been committed yet, since the original issue refers to 14 February 2007
Taxonomy Batch operations is an important module - if you need this functionality, you need it badly! Potentially it is useful for many more people and it is critical that this module be updated.
Furthermore, Drupal is advancing in leaps and bounds and "Taxonomy" is still one of the major strengths as well as a often critically misunderstood element of Drupal. Propertly implementing a useful taxonomy on large sites may involve hundreds or even thousands of hierarchical items. We need the tools to implement and manage those taxonomies! For that reason it is critical that this module receives attention and ongoing development.
What is the problem? Lack of maintainers?
#36
I agree that there should be some particular attention about taxonomy related features and therefore modules. Yet I cannot offer to check the code myself, unfortunately.
A few issues/features (around 4 as far as I remember) have been undergoing quick developments for a few months and would deserve a place in a new stable release of the taxonomy_batch_operations.module, as long as they be stable themselves.
I wish we'll have some answers to the previous post (118983#35) from casperl soon....
#37
I have committed the patch bundle, and released a stable version 1.0.
#38
I just want to say Waouuuu! Thank you!!! I'll let you know if I come accross troubles... Of course I don't want them!!!
#39
Between us Swedes, let me just say: gôtt mos! Thanks!
#40
Automatically closed -- issue fixed for two weeks with no activity.