Posted by smithkyle1992 on July 8, 2011 at 2:40am
36 followers
| Project: | Views Slideshow |
| Version: | 7.x-3.x-dev |
| Component: | Cycle |
| Category: | bug report |
| Priority: | critical |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
Hi all,
All the tutorials i've read lead me to this site to download jquery.cycle.all.min.js:
http://malsup.com/jquery/cycle/
However from there i can only get jquery.cycle.all.js - it's missing the .min which doesn't seem to actually work...
Any thoughts?
Comments
#1
subscribe
#2
Ran into the same issue. Found a minified version at http://code.google.com/p/vungtaufishingport/source/browse/trunk/modules/...
So far, so good.
#3
That version that critical mash posted doesn't work for me - I just get all my images appear one after anouther down the page.
#4
don't suppose anyone could upload the working version they are using on their site?
#5
One quick solution is to copy the plugin from the Drupal 6 version.
#6
i have this one..downloaded about 10 days ago.
just rename it to jquery.cycle.all.min.js
#7
The one posted by rootatwx doesn't work for me either. I still get the same error: " You need to install the jQuery cycle plugin. Create a directory in sites/all/libraries called jquery.cycle, and then copy jquery.cycle.all.min.js into it. Latest version tested: 2.99
You can find the plugin at http://malsup.com/jquery/cycle/download.html." Even though jquery.cycle.all.min.js is in sites/all/libraries. Is there a way to force it or direct it to the file location manually?
#8
Simply renaming the jquery.cycle.all.js file to jquery.cycle.all.min.js will do the trick. I do not believe a minified version is necessary with Drupal's 'Aggregate JavaScript files' performance option (someone please correct me if I am wrong).
@asauterChicago,
Sounds like you are skipping the step of creating the jquery.cycle folder. Could you please verify that you have in fact placed the jquery.cycle.all.min.js inside a jquery.cycle folder inside the libraries folder? Your path from the Drupal root should look like:
sites/all/libraries/jquery.cycle/jquery.cycle.all.min.jsCheers,
Antoine
#9
Actually drupal aggregation doesnt minify afaik..but still.
minified or not,its the same code to the machine ^^
#10
Subscribe
#11
subscribe
#12
Yeah, you can just rename the file and the warning notice disappears.
Perhaps just a small patch to the module to use the non-minified version (as looking at the project at github there is no default minified version anyway).
ps. I can't do this at the moment as am at work but will look later.
#13
sub
#14
You can also use one of the packages to minimize the javascript code . I used the YUI compressor and for the outuput file give it the name of jquery.cycle.all.min.js
#15
Looks like a great module: can't wait to get it rolling. BUT:
I have this path:
/var/aegir/platforms/d7smallsite-222/sites/all/libraries/jquery.cycle/jquery.cycle.min.js
All perms are 775
And I've tried:
- Running the full .js, but renamed to min.js (as at #8)
- Using the min.js from #2 and #8
And still get the warning message AND no slideshow.
Thanks to the responders so far: would appreciate any further guidance here!
#16
It would appear that the author of jQuery.cycle has stopped hosting the minified version of the plugin.
The real issue is that views slideshow can't guess what the filename the JS plugin will be. Unfortunately there is not much we can do about the 3rd party changing filenames or removing files from the server.
Here is a patch that will first attempt to load a file that goes by the name: jquery.cycle.all.min.js.
If it does not exist, it will try: jquery.cycle.all.js (the name of the un-minified version that currently exists on the server).
Note that the module doesn't actually care whether the javascript plugin has been minified or not, or even whether the minified version has "min" in its filename.
#17
thegreat,
There was a syntax error on line 11 of your patch. Attached is the updated and fixed patch.
Thanks,
R.
#18
rerolled robin's patch against views_slideshow-7.x-3.x
#19
Subscribing.
#20
Hi guys,
I tried all the posted solutions and none of them works! I tried also the patchs (the 2 last posted ones) and I get an error in the line command :
can't find file to patch at input line 5Perhaps you should have used the -p or --strip option?
The text leading up to this was:
--------------------------
|diff --git contrib/views_slideshow_cycle/views_slideshow_cycle.module contrib/views_slideshow_cycle/views_slideshow_cycle.module
|index 29483bd..cbbc855 100644
|--- contrib/views_slideshow_cycle/views_slideshow_cycle.module
|+++ contrib/views_slideshow_cycle/views_slideshow_cycle.module
--------------------------
File to patch:
as you can see it's prompting the file, it doesn't work even though I type the right path..
Please help!
#21
This is a duplicate of #1214290: jquery.cycle.all.min.js recommended, but not officially available (Fixed) where a work around for using the non minified version has already been committed.
#22
My bad, #1214290: jquery.cycle.all.min.js recommended, but not officially available (Fixed) was committed to Views Slideshow: Dynamic Display Block.
That issue took the same approach to fix this as the patch here in #18. However #18 was missing the warning message on the view edit form. So I've moved the logic to find the cycle path into its own function and used it on the view edit form and for the drupal_add_js() call in hook_init().
#23
Updated patch, only removed the empty() check as the _views_slideshow_cycle_library_path() function returns FLASE on failure.
#24
And here is the patch for 7.x-3.x.
Regards,
David
#25
#26
Renaming the file to add the .min worked for me. Thank you!
#27
@David Stosik thanks for the re-roll. If it's working for you can you mark this as RTBC?
#28
thanks @David Stosik and @fenstrat it works!
#29
#30
Just checked the jquery cycle site and there is a full version and a lite version now available. The files have the following names:
Full version:
jquery.cycle.all.js
Lite version:
jquery.cycle.lite.js
Which version is now recommended to use with this module?
#31
The patch in #25 works great if using the full jquery cycle plugin (https://raw.github.com/malsup/cycle/master/jquery.cycle.all.js).
The patch, however, doesn't yet detect the "lite" jquery cycle version (https://raw.github.com/malsup/cycle/master/jquery.cycle.lite.js). Should it support that as well?
Thanks,
Ben
#32
Hej Hej,
I have try to patch the first time. I have create a folder (test) and paste the original file and the patch file. After that I opened my terminal (Ubuntu) and change to the folder test. Then I use this:
patch -p1 < 1212484-24-views_slideshow_cycle_library_path.patch
after I press Enter I become the following message:
hasel@hasel-VirtualBox:~/alkohol/patch$ patch -p1 < 1212484-24-views_slideshow_cycle_library_path.patchpatching file contrib/views_slideshow_cycle/views_slideshow_cycle.module
Hunk #1 FAILED at 12.
Hunk #2 FAILED at 74.
2 out of 2 hunks FAILED -- saving rejects to file contrib/views_slideshow_cycle/views_slideshow_cycle.module.rej
patching file contrib/views_slideshow_cycle/views_slideshow_cycle.views_slideshow.inc
Hunk #1 FAILED at 69.
1 out of 1 hunk FAILED -- saving rejects to file contrib/views_slideshow_cycle/views_slideshow_cycle.views_slideshow.inc.rej
hasel@hasel-VirtualBox:~/alkohol/patch$
can you help me to solve this? sorry for my bad english i hope it will be better :-)
kind regards
drew
#33
Lite version is not a minimized version. It has less features And may be, I guess, less compatible with Views Slideshow. :)
#34
This also worked for me! And I made sure that the permissions were 755 too :)
#35
Yeah I'd agree with @David Stosik, there is no need to support the Lite version.
The patch in #23 is RTBC for 6.x as is the patch in #25 for 7.x
@drew29 the patch is made with Git and must be applied with Git. See the "Applying a patch" section of http://drupal.org/patch/apply
#36
Looks good to me.
#37
GIven that there is a consensus this patch is working as advertised, can we get a maintainer to commit this?
--Ben
#38
#39
This has been committed. Thank you everyone for your help!
#40
Thanks redndahead!
#41
Automatically closed -- issue fixed for 2 weeks with no activity.
#42
I am having this exact same problem
the module says, You need to install the jQuery cycle plugin ...
I have uploaded the file to the correct directory, /sites/libraries/jquery.cycle/jquery.cycle.all.js
CHMOD to 777, just to make sure .. and still having this error message. I have no idea how to apply the patch, if there is a patch necessary.
any ideas?
#43
you have the newest dev version?
#44
ach so, nope
will try the dev version.
#45
Not working.
I stopped the modules, uninstalled them, cleaned my cached. Deleted the views_slideshow folder from my modules directory. I then extracted the dev version of views slideshow, activated the modules .. and still same problem.
You need to install the jQuery cycle plugin. Create a directory in sites/all/libraries called jquery.cycle, and then copy jquery.cycle.all.min.js or jquery.cycle.all.js into it. You can find the plugin at http://malsup.com/jquery/cycle.
#46
it's working now .. don't ask my why, as I have no clue.
#47
hi, please tell me how. thanks
#48
Hi,
I am really stuck. I'm encountering a similar problem as detailed in #32.
First off, I tried simply renaming jquery.cycle.all.js to jquery.cycle.all.min.js and placing it in ...libraries/jquery.cycle but I still received the error message.
I then located this tutorial (http://www.werockyourweb.com/patching-drupal-modules-in-windows) on how to apply a patch to a module, and I followed it accordingly using Cygwin.
I entered in the following command and it returned the accompanying error
patch views_slideshow_cycle.module < 1212484-24-views_slideshow_cycle_library_path.patchpatching file views_slideshow_cycle.module
Hunk #1 FAILED at 12.
Hunk #2 succeeded at 75 (offset 2 lines).
1 out of 2 hunks FAILED -- saving rejects to file views_slideshow_cycle.module.rej
can't find file to patch at input line 57
Perhaps you should have used the -p or --strip option?
The text leading up to this was:
--------------------------
|diff --git a/contrib/views_slideshow_cycle/views_slideshow_cycle.views_slideshow.inc b/contrib/views_slideshow_cycle/views_slideshow_cycle.views_slideshow.inc
|index c6f03ab..7641bfd 100644
|--- a/contrib/views_slideshow_cycle/views_slideshow_cycle.views_slideshow.inc
|+++ b/contrib/views_slideshow_cycle/views_slideshow_cycle.views_slideshow.inc
--------------------------
I am really stuck. I really want to get this to work. I'm considering abandoning this module and using Views jQFX Nivo Slider instead. I would be grateful for any assistance. Thanks.
#49
#50
@starbucksguy There is no need to apply this patch, it was committed here in #39 and is part of views_slideshow 7.x-3.0.
Make sure the plugin file is placed in sites/all/libraries/jquery.cycle/jquery.cycle.all.js
#51
fenstrat -- Thank you for your reply and the information about the patch. I am using views_slideshow 7.x-3.0 and I have confirmed that the plugin file is located in the appropriate location. I have tried both sites/all/libraries/jquery.cycle/jquery.cycle.all.js and sites/all/libraries/jquery.cycle/jquery.cycle.all.min.js but I receive the same error.
The error states: You need to install the jQuery cycle plugin. Create a directory in sites/all/libraries called jquery.cycle, and then copy jquery.cycle.all.min.js or jquery.cycle.all.js into it. You can find the plugin at http://malsup.com/jquery/cycle.
My slides are not advancing.
I have attached appropriate screen shots. I would be glad to provide any additional configuration information that might lead to a resolution of this problem. Thanks.
#52
I removed the error. I downloaded the file from https://github.com/malsup/cycle and not http://malsup.com/jquery/cycle -- the github file worked.
#53
I fixed it. It works now.
#54
Thank you..
#55
Hi!
You need to install the jQuery cycle plugin. Create a directory in sites/all/libraries called jquery.cycle, and then copy jquery.cycle.all.min.js or jquery.cycle.all.js into it. You can find the plugin at http://malsup.com/jquery/cycle.
I'm trying to implement slideshow on Drupal 7.17. But i'm facing this error and at the same time my slideshow is not working i had already created the directory as suggested by this error and also the file (jquery.cycle.all.js) but still things are not working. Can you guys help me out.
Thanks in advance.
#56
@sezysoyuz The answer is in #52.
#57
Thanks, the github file works. I had the same problem as last one, but it was my fault: the libraries folder was not in all, but in sites. Typical duh!
Thanks for the plugin