File manager

I conducted an initial review of this project.

Licensing: Did not find any non-GPL code.
Module duplication: I think this is going to be an issue for this project. The Media module is currently a big push to be a unified solution for file management. Could you take a look at this and see if there's a way you can work with Media module?

Overall the code looks good. The waiting time for a full project review can be 4 -6 weeks. You can help to reduce the waiting time by contributing to the code review process. Please visit http://groups.drupal.org/code-review for details on how to participate.

I appreciate that the focus of your project is quite a bit different from Media module. Actually what I asked was if your project could work with Media module, as opposed to being an alternative. Your screenshots look really good, and I like what you've done, but I think you could still have a problem with duplication issues, because there are a bunch of file managers already. See http://groups.drupal.org/node/20291. The fact that most of them don't have a D7 version yet doesn't necessarily solve the duplication issue for you.

I think the application should go forward, but there's no guarantee this won't be raised again.

I was thinking about this a little, and I think this would be a better project if it could work with Media module. You would automatically have a much larger potential user base, and that would solve the duplication issue for you. I'm not saying that your project won't be approved unless you do this, but I definitely encourage you to look into it.

I'm not suggesting that your project merge with Media module and lose its identity. The module duplication issue is not clear cut, its a judgment call. In this case it needs some careful consideration. This is a quote from the Media module FAQ

Currently there are hundreds of modules that deal with files and multimedia, which has led to an enormous amount of duplicate code and conflicting implementations. Consequently, it has prevented multimedia and file module maintainers from coordinating more closely, and has created a huge overhead for maintaining Drupal’s multimedia and file capabilities. The multiplicity of modules also contributes to the confusion experienced by Drupal users who are choosing the modules to use for their site, and makes it difficult for developers to figure out how best to contribute to multimedia and file module development.

All I'm suggesting is that your project might have more value as part of a unified effort. It doesn't appear to be a problem of duplication with Media module, but there is the perception that there's a lot of file manager type code out there that needs to be considered.

I agree with ccardea. Please focus your efforts. If the module is similar to http://drupal.org/project/file_maintenance then speak with the maintainer malc0mn and request to become the D7 version maintainer.

Hmm.. That is frustrating. I've updated the issue. I cannot locate additional contact information for malc0mn.

It is a bit of crossposting, but I'll reply here as well.

I'm happy to make jox D7 branch maintainer. Just added him to the file_maintenance project.

Apologies for the delay.

mlc.

Great, so we can close this. Create a new issue if you want to promote other projects.

IMHO, "Display files that are in the filesystem but not in the database." is a major benefit. It looks like the file_maintenance module does not do that.

@NancyDru This project can't be promoted, because the best option was to merge it with File Maintenance. Jox was added as a maintainer of File Maintenance, so hopefully soon we'll see a D7 version of File Maintenance using Jox's code.

@jox I had the same difficultly when it was requested that my project app be merged with another project app. After a long wait, we were both given Project Promote. In your case you've been added as a maintainer of an existing project, so there isn't justification to confer Project Promote. You'll have better luck getting Project Promote with a different module.

Jox, I know exactly how you feel. My code from Block Direct View completely replaced the original code in Internal Nodes(http://drupal.org/project/internal_nodes), but only mjpa was originally given Project Promote. I was annoyed about it and demotivated. Weeks later, mjpa was talking on IRC to tim.plunket and he changed my application to Fixed (http://drupal.org/node/1146410)

A lot of the "bureaucracy" is caused by the size of the project application queue. There is simply too much to review and it is all volunteer work. IMHO, also, many Applications should never have been submitted in the first place (not yours! ;) ). There are current discussions about changing the process: http://groups.drupal.org/node/180444 I'm sure you have ideas to add at this point...

I was told "If you need to promote another project in the future, please open a new application and reference these so we can do it faster next time." I can change this issue status back, but I don't know how much it will help considering it really should have been merged with the other module in the first place. So, the next best thing: contact me when you post a new application, and I'll review it ASAP.

@Jox: I understand the feeling. I already have more than 20 modules, but I too would be required to jump through these hoops. Before I write any module, I search to see if there's anything similar enough to provide patches. Unfortunately, not all project pages take searching into account and occasionally I miss something that would have worked. Then I get the "similar module" messages from someone. It can be quite frustrating.

As eosrei suggests, maybe talking to that module maintainer will get him to back you for a new project, or even be willing to merge into yours. Can't hurt to try.

@jox: although subscribed to this thread, didn't receive any mails. Prolly because it's closed.

In my humble opinion: rename it to file_maintenance, add it to the repository @ file_maintenance and do a release? We can then go for a backport to D6?

Cheers,

mlc.

Added note that it's for D7.