Limit forum selection list to current group's forums

See comments 20 and 21 here: http://drupal.org/node/121822. You'll see in the file attached to 21 that I mention that I disabled the audience selection. Your scenario validates this decision. Note that admins (and others with permission) can still make a post public. I haven't checked how public posts are seen by outsiders, but perhaps in this case, the audience selection should be put back for admins. Then both groups A and B could see the post, right? I don't recall off of the top of my head, but I may have left in the audience selection at least for user id 1. If not, maybe we could leave the audience selector in, but unset its value if public isn't also checked or if the forum to which we're posting doesn't match.

Thoughts anyone?

And if you like what you see in my patch, campaign to get it added to CVS.

Darren> Unfortunately, the same code to fix: http://drupal.org/node/122340, also fixes this. This is because 'Limit forum selection list to current group's forums' is a group context and query problem, just as 'Hide group forums from non-members' is. If OG_forum knows which OG it should be working with, it can limit the list of forums to the current group. Likewise, it can hide forums if it knows that the forum belongs to a group other than one the user is subscribed to. As for the db query, again, the same query that reduces what the user can see at the top www.yoursite.com/forum level, also works at each sublevel, down to the topic and both 'hides info from non-members' and 'limits listings to current group'.

I did a similar test and posted it.
http://drupal.org/node/126008

Actually any non-member can post to any forum of any group. With this behavior, any practical use of the module is questionable.

Could you elaborate? By non-member, do you mean anonymous user, or authenticated user? In what manner are they posting to the forum? Does the group still show up in the dropdown selection? How is the user getting to the forum topic post in the first place? Are they a member of one group, but posting to another? Were the groups they can see/post to created before or after the patch was applied?

I think there may be an issue with group forums showing up at the /forum listing. It seems at first look like they are those created before the latest patch is applied. This implies to me that maybe some database entry wasn't completed correctly. Otherwise my clever SQL query that filters the listing may not be as clever as I thought. However, I've added numerous new groups with varying names after applying the patch and none of those have shown up on this listing. After deleting old groups, their forums don't show up either. So as far as I can tell, all groups (and their forums) created after the patch work as advertised. If anyone can help nail down what the difference between groups and their forums before and after the patch, that would be helpful. Perhaps the routine that updates existing OGs isn't working?

In relation to the above, if the user can't see the forum at the /forum listing, it shouldn't show up in the dropdown either, so if there is some OTHER way that posts are being made to illegal forums, I'd like to know.

Thanks.

The new 2.x version fixes users posting to groups they don't belong to. What could be done further is to allow the site admin the option to restrict posts to the group the post originated from. Using the existing setup, hiding or disabling the drop down would do the trick as it currently auto-selects the forum the user is in. This would require that a user go to the forum they wish to post in.

Alternatively, if you admins prefer, we could just reduce the drop down options to the forums in the group. This would allow a user to browse to a group's forums and from anywhere within them, post to any forum in that group. Is this the preferred behavior?

I am all for removing the Forum select drop-down box. I use it on one occasion, when moving forum post from one forum to a new forum. But I don't see why general users need this drop-down select box. I think it just makes things more confusing

I agree, but I'm willing to give others functionality they'd like if it doesn't break what I need. I don't think that the audience selector should be used in forums either. That adds even more user-confusion to the mix.

I'll leave this active in case anyone wants to comment. But unless I get a few people that really want this feature, it'll go bye-bye at some point.

see http://drupal.org/node/156661 for a related discussion. I'm closing this one in favor of that combined issue.