Hello All!
When I upgrade galleriffic to 7.x-1.0, slide image changed position.
I think that problem in css.
Screenshot in attachment.
Sorry for my English))

Comments

Lula’s picture

Hi
Had the same issue for a little while but realised that my Ctools wasn't the latest version. Simply updating Ctools to the 7.x-1.0-rc1 release fixed the problem.
Hope this helps!

jawi’s picture

Same sort of problem here:

http://smulfun.nl/galerij/bruidstaarten

The image wrapper is placed outside the caption with it's image desk (attachment_1).
When I looked at the module and it's template files I can't find that the image wrapper is placed in a specific div.

Is there a clean way to set the image wrapper in the right place?

When I change the css file, and comment-out the top; 0px, this helps placing the image down, but the image still isn't in it's wrapper.
Also with the standard Bartik theme the image is outside it's caption (attachment_2).

views_galleriffic_default.css

#galleriffic span.image-wrapper {
/*top: 0; */
width: 100%;
position: absolute;
}

installed modules

  • Views Galleriffic 7.x-1.x-dev (2011-aug-08)
  • Chaos tool suite (ctools) 7.x-1.x-dev (2011-sep-05)
  • views_galleriffic_gallery 7.x-1.0
  • Views 7.x-3.x-dev (2011-sep-03)

Using the latest versions of above called modules didn't solve the problem.
Any help is welcome :-)

Great tutorial!

http://drupal.org/node/758724

Great module!

http://aaroncouch.info/sites/default/files/fserver/views_galleriffic_gal...

hongquan’s picture

To fix this, change

#galleriffic span.image-wrapper {
    position: absolute;
    top: 0;
    width: 100%;
}

to

#galleriffic span.image-wrapper {
    position: relative;
    top: 0;
    width: 100%;
}

in the mentioned-above CSS.

gmclelland’s picture

I had to make a lot of changes to the default.css to simplify the code. Here is a patch if anyone wants to test it. Note: this is minimally tested.

gmclelland’s picture

Previous patch had white space errors. Here is a new patch.

hongquan’s picture

Hi gmclelland,
I tried your patch with this command
git apply views_galleriffic-fix-image-position-1246634_1.patch
but nothing happened.

I tried another way:
Remove the "a/" and "b/" before the filenames in the patch file, then use this command
patch -p0 -i views_galleriffic-fix-image-position-1246634_1.patch
but it said:

patching file css/views_galleriffic_default.css
Hunk #2 FAILED at 43.
Hunk #3 FAILED at 109.
2 out of 3 hunks FAILED -- saving rejects to file css/views_galleriffic_default.css.rej
patching file views-galleriffic-view.tpl.php
gmclelland’s picture

I'm using 7.x-1.0 with the patch in a drush make file.

projects[views_galleriffic][version] = 1.0
projects[views_galleriffic][subdir] = contrib
; fix image position - http://drupal.org/node/1246634#comment-5669898
projects[views_galleriffic][patch][] = http://drupal.org/files/views_galleriffic-fix-image-position-1246634_1.p...

This works for me.

skizzo’s picture

@hongquan: from sites/all/modules/views_galleriffic you could just run "patch -p1"
patch -p1 < views_galleriffic-fix-image-position-1246634_1.patch
Works for me. No need to remove the "a/" and "b/". Thx gmclelland.

skizzo’s picture

Version: 7.x-1.0 » 7.x-1.x-dev
Component: User interface » Code
Assigned: mih4i1 » Unassigned
Category: support » bug
xiong2004’s picture

How do we go about patching the CSS file? Could someone please load his/her CSS file that is working properly for him/her here?

acouch’s picture

Status: Active » Fixed

I just pushed an updated default css file that removes some of the width settings based on comment #5. This will be in the dev version for now. Didn't make it into the 1.1 release.

acouch’s picture

I should note I tested this on Chrome, FF, and IE 7 and IE8

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.