You recently added a submit function to flatten the array on the menu edit page, but there's also a submit function needed on the node edit page.

I took the same function, but as the structure is different I had to modify it slightly

CommentFileSizeAuthor
#10 hs_menu-1272538-10.zip1.18 KBRefineo
#10 hs_menu-1272538-10.patch3.12 KBRefineo
#9 hs_menu-1272538-2and12.zip2.48 KBRefineo
#2 node_submit-1272538-2.patch1.03 KBrv0
nodesubmit.patch1.13 KBrv0

Comments

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs review » Needs work

hs_menu_menu_edit_item_form_submit() is only meant for the menu_edit_item_form. That's why it's called that way. Please create a separate #submit callback.

Also, please comply with the Drupal coding standards.

rv0’s picture

rv0 commented
Status: Needs work » Needs review
StatusFileSize
new node_submit-1272538-2.patch1.03 KB

Try this one ;)

martichka5’s picture

martichka5 commented
Status: Needs review » Reviewed & tested by the community

The above patch fixes the issue for me.

iancawthorne’s picture

iancawthorne commented

Same here. #2 fixes the issue of saving on a node edit form for me.

izkreny’s picture

izkreny commented

#2 is working for me too (against 7.x-3.0-alpha5) and fixes errors reported @ #1360696: Hierarchical Select Menu triggering bug in Core - Menu issue.

BUT, it's not working in combination with also (personally) much needed fix from #1271386: Hierarchical Select Menu should respect menu_options (#12).

rv0, can you pwetty pwease commit this two RTBC patches to dev, if Wim is busy? ;)

Or give some hint how to merge those two patches easily?

Thx.

rv0’s picture

rv0 commented

@mariomaric
I do not have commit access.

The patches are very simple, if both collide, you should apply them manually (open patch file, look at code ;) )

rv0’s picture

rv0 commented
Priority: Normal » Critical

well..

m4olivei’s picture

m4olivei
he/him
Primary language English
Location Grimsby, ON
commented

Would love to see this commited!

Refineo’s picture

Refineo commented
Assigned: Unassigned » Refineo
Status: Reviewed & tested by the community » Needs work
StatusFileSize
new hs_menu-1272538-2and12.zip2.48 KB

I applied both patches #2 and #12 manually.

I attach the corrected hs_menu.module file.
I will prepare a new patch as well but someone needs to test it and to commit later on.

Refineo’s picture

Refineo commented
Assigned: Refineo » Unassigned
Status: Needs work » Needs review
StatusFileSize
new hs_menu-1272538-10.patch3.12 KB
new hs_menu-1272538-10.zip1.18 KB

Here is the new patch as in #9.
Please review. Thanks !

Refineo’s picture

Refineo commented
Issue tags: +Needs tests

Needs tests

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs review » Fixed

Finally committed: http://drupalcode.org/project/hierarchical_select.git/commit/2d5201d. Thanks!

chichio9000’s picture

chichio9000 commented

My site success with #10.

Thanks refineo

Automatically closed -- issue fixed for 2 weeks with no activity.