Drupal 7 port

I have been working on updating this for D7. I'll go ahead and post what I have but it isn't anywhere near ready yet.

Thanks for posting what you've got now. It's always good to include a patch based against the diff so that folks know what has changed.

Did you run it through Coder?

Yes I ran it through coder. I'm having to make changes to the smsframework as well as port some of the code over that they removed when they updated it to 7. I'm mostly got the user interface working along with a few tweaks/improvements to what was there and trying to keep everything in the coding standards for D7. If I'm able to work on this over the next few days I think I have have a semi-usable patch to put out for a dev/beta release.

I've attached where I have the project as of right now but again I have been working on the framework as well because most of sms user, devel, validate, and the other sub modules from the framework are broken in the release that is available.

I got a little sidetracked working on cronplus and php_errors but I'm almost done with them and back to this.

Thanks! I don't have time to test this code now, but hopefully the maintainer will be able to look at it soon.

mgifford,

Here is a patch against the 7 version. The version is there on git but it isn't listed under the module. Please take a look at this when you can and let me know if you see any other changes that need to be made. I'm still having some problems but I'm not sure if they are in this, messaging, smsframework, or some other place along the line.

I just had time to test quickly to see if this patch applies. Got a whitespace error:

sms-email-gateway-upgrade-1289928-5.patch:739: trailing whitespace.
if (in_array($carrier->domain, array_keys($carriers))) {
warning: 1 line adds whitespace errors.

Not a big deal for what is a a reasonably large patch. Thanks for putting it up.

I'm not sure if you wanted me to fix it or not but here is the same patch minus the trailing whitespace.

Thanks. I'd hoped that you would.

EDIT:
******
it applies cleanly to the git download

I applied patch to the module download in this issue queue and got the errors below.

Sorry!

ORIGINAL MESSAGE:
*******
patch doesn't apply ?
git apply sms-email-gateway-upgrade-1289928-7.patch

error: patch failed: mta_scripts/mta_process_email.php:1
error: mta_scripts/mta_process_email.php: patch does not apply
warning: mta_scripts/support.inc has type 100755, expected 100644
error: patch failed: mta_scripts/support.inc:1
error: mta_scripts/support.inc: patch does not apply
warning: mta_scripts/xmlrpc.inc has type 100755, expected 100644
error: patch failed: mta_scripts/xmlrpc.inc:2
error: mta_scripts/xmlrpc.inc: patch does not apply
warning: sms_email_gateway.info has type 100755, expected 100644
error: patch failed: sms_email_gateway.info:1
error: sms_email_gateway.info: patch does not apply
warning: sms_email_gateway.install has type 100755, expected 100644
error: patch failed: sms_email_gateway.install:1
error: sms_email_gateway.install: patch does not apply
warning: sms_email_gateway.module has type 100755, expected 100644
error: patch failed: sms_email_gateway.module:2
error: sms_email_gateway.module: patch does not apply
warning: sms_email_gateway_test_incoming.info has type 100755, expected 100644
error: patch failed: sms_email_gateway_test_incoming.info:1
error: sms_email_gateway_test_incoming.info: patch does not apply
warning: sms_email_gateway_test_incoming.module has type 100755, expected 100644
error: patch failed: sms_email_gateway_test_incoming.module:13
error: sms_email_gateway_test_incoming.module: patch does not apply

This is an error with the drupal 7 version of sms email gateway and smsframework

I applied patch to smsframework which re-introduces sms carrier.
http://drupal.org/node/1421294#comment-5620260

without the above patch I got a WSOD when smsframework was enabled

Error: Cannot redeclare sms_carriers() (previously declared in
modules/all/smsframework/sms.module:418) in
modules/all/sms_email_gateway/sms_email_gateway.module, line 459

Try this patch and see if you still get errors when applying it. Also remember that this is for the 7 branch on git not the 6 that is on d.o.

i removed the sms carrier code introduced by the patch in #10 and all is good in the world.
There is a note in the patch that the sms_carrier code should be moved to the email gateway

What versions of each module are you applying the patches to?

Doesn't it seem strange that the sms_email_gateway module is using a function that is in sms' namespace? sms_carrier should be in the sms framework module and if sms_email_gateway wants to also define carriers (which seems odd) then it should use the frameworks' or define its own in the correct namespace.

I agree with #14 and propose moving sms_carriers back into smsframework as proposed in #1421294: WSOD PHP Fatal error: Call to undefined function sms_carriers at admin/smsframework/carriers

I'm trying to use this module, and I get an error for bad arguments to the implode function from the mail system.

Warning: implode() [function.implode]: Bad arguments. in DefaultMailSystem->format() (line 23 of [drupal root]/modules/system/system.mail.inc).

I looked there and that function looked fine, and the install is sending emails properly, it's just text messages that refuse to send. Any suggestions?

Found the issue. The implode function expects an array, and it was being passed a string.
I just changed:
$message['body'] = $params['message'];

to

$params['body'] = array();
$message['body'][] = $params['message'];

and it works perfectly now. I can post a patch if anyone else needs this fix.

SMS carriers is defined in the email gateway and smsframework.

PHP Fatal error: Cannot redeclare sms_carriers() (previously declared in /smsframework/sms.module:417) in sms_email_gateway/sms_email_gateway.module on line 460

Any updates on this port?

Also wondering if there's any updates on this?

This would be great to use!
I tried patching but, it failed...
Thx

Subscribing

This module is seeking co-maintainers. Who is willing to step up and take that on.

It also doesn't have many folks using it at this point. Is there anyone willing to help fund the development?

I can take this module up so we can quickly get the 7.x-1.x and 8.x-1.x ports in. Even though it looks like very few people are still using it.

With better support, that might change... Thanks for taking up the upgrade!

Great Initiative and thanks for your Effort!

My use case is for sending messages only via email gateways. This patch works for me without incoming SMS messages.

Combinations of patches from https://www.drupal.org/project/sms_email_gateway/issues/1717252, https://www.drupal.org/project/sms_email_gateway/issues/1717260, and the fix from skriptble above.

This is against branch 7.x-1.x.