Calling it major since there is no page available at admin/smsframeowrk/carriers

PHP Fatal error: Call to undefined function sms_carriers() in /modules/all/smsframework/sms.admin.inc on line 154, referer: /admin/smsframework

doing a search in the smsframework module
grep 'function sms_carriers' *

sms.admin.inc:function sms_carriers_admin_form($form, &$form_state) {
sms.admin.inc:function sms_carriers_admin_form_submit(&$form, &$form_state) {
sms.admin.inc:function sms_carriers_edit_form($form, $form_state, $carrier = array()) {
sms.admin.inc:function sms_carriers_edit_form_submit(&$form, &$form_state) {
sms.admin.inc:function sms_carriers_delete_form($form, &$form_state, $carrier) {
sms.admin.inc:function sms_carriers_delete_form_submit($form, &$form_state) {

CommentFileSizeAuthor
#8 smsframework-sms_carriers-1421294-8.patch3.45 KBmcpuddin
#1 smsframework-sms_carriers-1421294-1.patch2.35 KBcashwilliams

Comments

cashwilliams’s picture

cashwilliams commented
Status: Active » Needs review
StatusFileSize
new smsframework-sms_carriers-1421294-1.patch2.35 KB

Moved code from 6.x-2.x branch and updated db calls

cashwilliams’s picture

cashwilliams commented
Status: Needs review » Active

and now I see this was removed on purpose - http://drupalcode.org/project/smsframework.git/commit/aeb577dc718fb78257...

But I'm not sure all of this should be pushed to email gateway

atlea’s picture

atlea commented
Status: Active » Needs review
rurri’s picture

rurri commented

If this is to be moved to e-mail gateway, then some dependencies will need to be changed.

But can't you have a carrier that doesn't use the email gateway?

socialnicheguru’s picture

socialnicheguru commented

conflict with the sms_email_gateway module for drupal 7

http://drupal.org/node/1289928#comment-5847756

soyarma’s picture

soyarma commented

Is there a resolution to this? Essentially the D7 dev version is hosed without it (at least the UI is).

Dret’s picture

Dret commented

Same problem for me on last D7 version!

Fatal error: Call to undefined function sms_carriers() in /var/wwwroot/mysite/sites/all/modules/smsframework/sms.admin.inc on line 154

I'm using Sms Framework (only the main module) with SMS Simple Gateway.

Thanks!
Bye!

mcpuddin’s picture

mcpuddin commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new smsframework-sms_carriers-1421294-8.patch3.45 KB

I went through this code and it worked for me. I'm not sure why it was removed earlier however I think the first step is getting it back to a working state before any decisions are made.

I added one clarification to add the header of "Enabled" to the carriers.

mcpuddin’s picture

mcpuddin commented
Status: Reviewed & tested by the community » Fixed

Committed

cashwilliams’s picture

cashwilliams commented

This is fixed here, but see issue for sms_email_gateway #1717252: SMS Carrier Functions conflict until it is committed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit b582bbd on 7.x-1.x, 8.x-1.x by mcpuddin: 
    Issue #1421294 by CashWilliams, mcpuddin: Fix for carrier