Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Just noting some serious accessibility problems I noticed & posted here - #1306752: Accessibility problems with the BUEditor
Probably they should belong here with the project, but they were added to d.o & so a more immediate concern for users on Drupal.
For a comparison with CKEditor's accessibility, see:
http://ckeditor.com/blog/CKEditor_and_WAI-ARIA_means_Usable_Accessibility
Comments
Comment #1
ufku CreditAttribution: ufku commentedCould you please post a more specific issue report about this?
Comment #2
MGParisi CreditAttribution: MGParisi commentedAs mentioned, and marked, Duplicate... Or should we duplicate out the infra discussion and keep this one?
Comment #3
ufku CreditAttribution: ufku commentedOk, the first and only one i can see is the missing alt attributes for input tags.
I've just committed the fix for 7.x-1.x and 6.x-2.x branches.
Please reopen if there are other issues.
Comment #4
mgiffordThanks. I'll have to look at this in more detail. I'll have to take a look at the code.
Comment #5
mgiffordAdd WAI-ARIA role="application" to tell the assistive tech to pass keys through to the browser / page and not to handle them on its own.
Some links on this:
http://www.w3.org/TR/wai-aria/roles#application
http://www.accessibleculture.org/articles/2011/02/not-all-aria-widgets-d...
Comment #6
Everett Zufelt CreditAttribution: Everett Zufelt commented@mgifford
Can you explain why we should add the application role? I don't think that it is the best idea in this scenario.
The purpose of the application role is to tell assitive tech, like screen-readers, to interact with browser UI directly, and to pass keys though to the browser, instead of trapping them.
If the editor buttons indeed have accelerator keys (not accesskey attribute) but w/ JS, then it is likely best to:
1. Wrap the entire editor (buttons and text area) in role="application" and to make sure that the accelerator keys are discoverable.
If, however, only accesskey attributes are being usd for accelerator keys then I would recommend against role="application" as most assistive tech / browser combos support this natively, w/o application role. The accelerator keys still need to be discoverable (documented) somewhere.
Comment #7
mgiffordI'll default to you here. Maybe we just need to make sure that it's clearly discoverable.
Comment #8
ufku CreditAttribution: ufku commentedHere is an example BUEditor with one image button (Bold)
It uses the accesskey attribute for buttons. The input element has a custom click event.
There is no JS key binding. (There is an add-on library that binds Ctrl+Accesskey to the textarea keydown event, but that's not the case in d.o and it does not alter the accesskeys.)
How about setting the alt attribute as e.g. "Bold (Accesskey: B)" to make it discovarable?
Comment #9
mgiffordI'm waiting to hear back form Everett on the accelerator keys.
Do you have a demo we could look at with the add-on library that binds Ctrl+Accesskey to the textarea keydown event?
Comment #10
ufku CreditAttribution: ufku commentedHere on the dev site
http login: drupal/drupal
drupal login: bananas/bananas
You can test it on the book form
Comment #11
mgiffordThat's much better.
There still needs to be some way to alert users about how to get to the '?' icon. Once you get there it tells you which control characters to use which is great.
Comment #12
ufku CreditAttribution: ufku commentedI've committed the changes Everett suggested under #1306752: Accessibility problems with the BUEditor
The changes can be observed on the demo.
Let me know if we can improve it further.
Comment #13
mgiffordAmazing! Now it's just a matter of having a stable release that will roll out to d.o & then hopefully g.d.o..
Thanks again!
Comment #14
Everett Zufelt CreditAttribution: Everett Zufelt commentedI would say that the toolbar of buttons should still be wrapped in:
<div role="toolbar"> ... buttons ... </div>
Thanks
Comment #15
ufku CreditAttribution: ufku commentedComment #16
Everett Zufelt CreditAttribution: Everett Zufelt commentedNice. Using JAWS 12 / FF7
When I am reading by line I hear 'Toolbar with 16 buttons', when tabbing through controls I hear 'Toolbar' spoken when I reach the buttons.
Comment #17
ufku CreditAttribution: ufku commentedCommitted. New releases are ready.
Thanks.
Comment #19
jhodgdonNote: for anyone still following this issue, there is a follow-up on BUEditor accessibility:
#1505324: BUEditor still has accessibility issues (in dialogs)
Comment #20
mgiffordJust as a note
role="toolbar"
is no longer in the toolbar in the demo. Is this still current?Comment #20.0
mgiffordadding link for clarification.