[D7] Youtube Derivatives

Your code got some coding standart issues (See http://ventral.org/pareview/httpgitdrupalorgsandboxcamdarley1371632git, you can use this site to re-test your self)

Your code has too feee...eew comments, please do more detailed commenting so other developers don't have to re-think your thoughts

If you got any questions on that, please ask

• Remove the 7.x branch to avoid confusion.
• media_derivatives_youtube.features.inc: @file doc block is wrong.
• media_derivatives_youtube.info: duplicate entry "core = 7.x"
• "define('YOUTUBE_AUTH_URL', 'https://www.google.com/youtube/accounts/ClientLogin');": constants should begin with your module name.
• "watchdog('Youtube Engine',...": you should use your module name for the log entry.
• "watchdog('Youtube Engine', 'Uploaded file !file to Youtube. Story id: !story_id'": why do you use the "!" placeholder here? Path variables are plain text, right? so you should use "@".
• media_derivatives_youtube.info: dependency on Libraries API is missing?

It appears that there have been multiple project applications opened under your username:

Youtube Derivatives: http://drupal.org/node/1371658
Media: Kewego: http://drupal.org/node/1348120

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue.

With this in mind, I have marked your secondary applications as 'closed(duplicate)', and left one application open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one I that I have left open, then please feel free to close the 'open' application as a duplicate, and re-open one of the other project applications which I had closed.

Thanks in advance for your patience and understanding!

sorry for the delay! too many applications too few reviewers :(
you can help out and get a review bonus to speed up you application.
See http://drupal.org/node/1410826

Removing review bonus tag, you have not done any manual review, you just posted the output of an automated review tool.

Added links to other project reviews

I would find it helpful, if you would explain what "Media Derviatives API" actually is in the project application description.

I'm not quite sure this project will suffice for full project review, as it only contains 5 functions (all implementing hooks), no user-interaction and no database-activity. But that's only a thought about what I read on other reviews.

Because no database and no user interaction I cannot imagine any "security flaws".

Pareview on ventral does not show any coding standard problems.

As the complexity of the module is very low, it's diffcult to find any "best practice" issues.

I don't see any objection on why this project should not be promoted to full project.

Removed reviews of other projects

Generally it is recommanded only submitting one project for review.
As if you get "Full Project Access" this will be for all your current and future projects.

So it would be best to cancel all but the one which shows best your programming skills, this will also make the overall review process faster for everybody.

right,
once your first application has been successfully approved, an applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue.

I'll have a deeper look into this in the next couple minutes..

1. I think your project page could still be enhanced, have a look at the tips for a great project page. Same with the README.txt, see guidelines for in-project documentation.
2. If you fixed an issue in your queue, don't forget to mark it as "fixed", if everything is okay and there's no further activity it'll be closed after a week to "closed (fixed)". Also have a look at Commit messages - providing history and credit. ( the " - from [name]" is not the accurate way to provide credit, use "Issue #[num] by [name]: [topic]")
3. .info: Missspell in you description "Youube"
4. Would be nice to have all constants documented /**/
5. Begin your comments with uppercase and and them with fullstop

6. function media_derivatives_youtube_ctools_plugin_api() {
     list($module, $api) = func_get_args();

   I don't get the point of this line, what's it good for? :o, would _plugin_api($module = NULL, $api = NULL) not do the same?

7. You should check whether Zend Gdata framework is available by hook_requirements.
8. As Derivatives API is still under "heavy" development, I'd suggest you to not create a "recommended" release until Derivatives did. (but as your the creator of derivatives api, I'm pretty sure you'd done it this way anyway)

Generally I think here are no critical issues that should be block this and even if here's not 'much' code to review I'm quite sure you know what you're doing ;-)

Therefore, thanks for your contribution and welcome to the community of project contributors on drupal.org!! :)

I've granted you the git vetted user role which will let you promote this to a full project and also create new projects as either sandbox or "full" projects depending on which you feel is best. But keep in mind that this power also brings responsibility ;-)

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

Congratulations camdarley for becoming a true Drupal developer.

I would find it a good idea explaining what "derivation engines" are on your project page.

If you don't mind and have time to spend, I would be glad for a review of my project-application "Directory based organisational layer." http://drupal.org/node/1302786 :-)