Hi there,

I've created a port for Drupal 5. It works for me. For you too? I also improved a little the coding style aligned to the current standard.

CommentFileSizeAuthor
g2_v5.patch88.45 KBaries

Comments

fgm’s picture

Status: Active » Needs work

Thanks for your port.

However, this module does not apply the Drupal coding style, which is only a requirement for core, not contrib. I've transcribed our coding syle requirements on the wiki:

http://wiki.audean.com/g2/coding

Can you reroll the patch with only the relevant Drupal 5 changes, without coding style changes ?

fgm’s picture

Version: master » 5.x-1.x-dev

Changed to D5 branch.

Note that the coding style document is now at http://wiki.audean.com/coding

vedat.kamer’s picture

here is working G2 for Drupal 5 from aries:
http://localhostr.com/files/93061c8a7315d854376f.gz

pathscollide’s picture

What is the difference between the module vkamer posted and the 5.x-1.x-dev version from May??

fgm’s picture

As explained in the release notes : This release is only a placeholder, in case a version for Drupal 5 somehow comes to be created. It is not an actual version for Drupal 5.x. See http://drupal.org/node/138027 about this.

The patch has not been committed because it does not adhere to the required module coding style, which is not drupal, as outlined on http://www.drupal.org/project/g2, but I suppose it works just fine nonetheless, whereas the 5.x.dev release does not work at all, since it is not an actual version for Drupal 5.x

pathscollide’s picture

Sorry for overlooking the release notes -- thanks for the clarification.

pathscollide’s picture

There's a bug in the version posted by vkamer. If I try to visit the g2 glossary main page I see this error: "Cannot use string offset as an array in [path to my drupal]/includes/theme.inc on line 555" (or line 552, depending on the Drupal version I guess). Apparently this has something to do with changes in link handling between 4.7 and 5.x (http://drupal.org/node/64279#handling-of-links) but I don't know how to find out where exactly the problem is coming from (nor how to fix it!).

fgm’s picture

There is indeed a problem with Drupal 5.x: the theme_links function.

In 4.7, it took preformatted, straight HTML links, which G2 prepares as absolute.

Starting with 5.0, it takes structured links. However, it misses the ability to process the "absolute" property.

This has been restored in 6.0. Anyone creating a 5.0 version should either remove the "absolute" property on alphabar links (not too good), hack includes/menu.inc (bad), or stop using theme_links

fgm’s picture

Title: G2 Drupal-5 port » G2 Drupal-6 port
Version: 5.x-1.x-dev » 6.x-1.x-dev
Status: Needs work » Fixed

A first release for Drupal 6 has been created today.

pathscollide’s picture

Ok, I have to admit I'm confused again. Changing the status of this issue to fixed and changing the version to 6 doesn't solve the problem for those of us who are going to stay with Drupal 5 (which wasn't released that long ago, after all!) Am I really the only person who wants to use this great module but isn't planning on upgrading to Drupal 6 in the foreseeable future?

Furthermore, does this mean there is no planned official release for Drupal 5? Of course, the people who do the development work have every right to define their own priorities, but I think in this case (where there's no other module with equivalent functionality) it's really a shame to leave Drupal 5 users hanging.

fgm’s picture

Please read the module description. Quoting, emphasis added: Versions: G2 is currently 4.7 only. It won't be tracking 5.0 HEAD until after 5.0 official release, if ever, unless someone sponsors it. A non-validated patch for D5 compatibility has been submitted at http://drupal.org/node/138027 in case someone wants to finalize it. The module is expected to skip directly to the Drupal 6 API.

So, yes indeed, there is no planned official release for Drupal 5, because no one created one or offered to sponsor one, The new development version is for Drupal 6, and an official release is planned for this version of core, fairly soon.

Anonymous’s picture

Status: Fixed » Closed (fixed)