Can't add menu items to an empty menu

+++ b/modules/hs_menu.module
@@ -160,7 +160,7 @@ function hs_menu_hierarchical_select_valid_item($item, $params) {
-  $valid = (in_array($parts[0], menu_get_names()));
+  $valid = (array_key_exists($parts[0], menu_get_menus()));

suppose isset() a bit better

$all_menus = menu_get_menus();
$valid = isset($all_menus[$parts[0]]);

I'm not sure that menu_get_names() returns a keyed array.

But checking for NULL inside array seems useless

Thanks for the patch Firebird I tried the patch but now I am getting

Notice: Undefined variable: parts in hs_menu_hierarchical_select_valid_item() (line 166 of C:\wamp\www\mysite\sites\all\modules\hierarchical_select\modules\hs_menu.module).

Any ideas anybody

@firebird: thanks! Perfect one-liner :) I also read #784856: Menu_get_names() is dead code, remove it and commented on menu_get_names()' docs: http://api.drupal.org/api/drupal/includes%21menu.inc/function/menu_get_n....

Commit: http://drupalcode.org/project/hierarchical_select.git/commit/4b88100.

This issue is actually still active. Sorry to reopen this but I had to manually patch the hs_menu.module file. Could the patch mentioned in #6 be committed in next release? It works great.

It has been committed. No new release has been tagged though.

Yep I realised that the moment I posted this comment :-) Though it makes it harder for us who use this great module :-) I really appreciate the work that has been made but issues as serious as this must be fixed when solution is known and agreed to. Just my opinion :-)

(I got really scared when I couldn't save any menu item)

Specified where the adding of menu links doesn't work.