whami Source Adapter

It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.
Review of the master branch:

• README.txt is missing, see the guidelines for in-project documentation.
• Remove "version" from the info file, it will be added by drupal.org packaging automatically.
• ./whami_source_adapter.module: all functions should be prefixed with your module/theme name to avoid name clashes. See http://drupal.org/node/318#naming
  

  function whami_get_information_bounding_box($bbox, $lan, $categoriesID, $sourceID, $maxRows, $titleshrink, $bodyshrink, $linkshrink, $maxRequestRows, $sessionID) {
  function whami_get_information_geopoint_radius($lat, $lon, $radius, $lan, $categoriesID, $sourceID, $maxRows, $titleshrink, $bodyshrink, $linkshrink, $maxRequestRows, $sessionID) {
  function convert_bounding_box_geopoint_radius($north, $east, $south, $west) {
  function convert_geopoint_radius_bounding_box($zLon, $zLat, $radius) {
  

• ./modules/whami_source_adapter_wikipedia/whami_source_adapter_wikipedia.inc: all functions should be prefixed with your module/theme name to avoid name clashes. See http://drupal.org/node/318#naming
  

  function whami_get_information_bounding_box_wikipedia($bbox, $lan, $max_request_rows) {
  function whami_get_information_geopoint_radius_wikipedia($lat, $lon, $radius, $lan, $max_request_rows) {
  

• ./modules/whami_source_adapter_panoramio/whami_source_adapter_panoramio.inc: all functions should be prefixed with your module/theme name to avoid name clashes. See http://drupal.org/node/318#naming
  

  function whami_get_information_panoramio_return($result) {
  function whami_get_information_bounding_box_panoramio($bbox = NULL, $lan = "", $max_request_rows = 20, $img_size = 'thumbnail') {
  function whami_get_information_geopoint_radius_panoramio($lat = 0, $lon = 0, $radius = 5, $lan = "", $max_request_rows = 20, $img_size = 'thumbnail') {
  function whami_panoramio_merge_preview_pics($result, $result_preview, $img_size_preview) {
  

• Bad line endings were found, always use unix style terminators. See http://drupal.org/coding-standards#indenting
  

  ./whami_source_adapter.info:                                                     ASCII English text, with CRLF line terminators
  ./modules/whami_source_adapter_panoramio/whami_panoramio_table.tpl.php:          ASCII text, with CRLF line terminators
  modules/whami_source_adapter_panoramio/whami_panoramio_pic.tpl.php
  modules/whami_source_adapter_panoramio/whami_panoramio_table.tpl.php
  whami_source_adapter.info
  

• Remove all old CVS $Id tags, they are not needed anymore.
  

  modules/whami_source_adapter_wikipedia/whami_source_adapter_wikipedia.info:1:; $Id:$
  modules/whami_source_adapter_panoramio/whami_source_adapter_panoramio.info:1:; $Id:$
  whami_source_adapter.info:1:; $Id:$
  

• Run coder to check your style, some issues were found (please check the Drupal coding standards). See attachment.
• Drupal Code Sniffer has found some code style issues (please check the Drupal coding standards). See attachment.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. Get a review bonus and we will come back to your application sooner.

Hi,

is there any progress on this one?

Best regards,
martin.l

Hi,
we would really like to publish this module and think that all requirements have been fulfilled in the meantime, so there is only very few left on the reviewers side to do ... we would ask in the most polite way if there is a chance to take this last step ;-)

Regards,
martin.

Hi,

I'm sorry for the delay,
as there are currently hundreds applications in the queue we need more reviewers,
so think about getting a review bonus and we will come back to your application sooner.

Hi,

okay, thanks for the answer. We´ll see, what we can do in terms of review bonus.

Still we would be grateful if this application was given some priority, since we are deeply convinced that the module could be very helpful for the community...

Regards,
martin.

Text formatting.

added first review of another module for the review bonus

added my username and a link my profile to review bonus description for clarification

add another personal review

As per http://drupal.org/node/1410826 I have added the review bonus tag. Please see the list of reviews I have done on the first post of this page.

added 3 review for review bonus

Thanks for your reviews, just make sure that you pick applications that did not get a review in a long time.

Review of the 6.x-1.x branch:

• Drupal Code Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. Get a review bonus and we will come back to your application sooner.

manual review:

• Info files contains a strange first character, see http://drupalcode.org/sandbox/vlad.k/1396508.git/blob/refs/heads/6.x-1.x...
• whami_source_adapter_convert_bbox_geopoint_radius(): doc comments should break at 80 characters, not earlier. See http://drupal.org/node/1354#general
• whami_source_adapter_wikipedia_block(): all user facing text should run through t() for translation. Same for whami_source_adapter_panoramio_block().
• whami_source_adapter_wikipedia.module: do not globally include the inc files (now they are loaded on literally every page request), include them when you actually need them.
• template_preprocess_whami_source_adapter_wikipedia_content(): do not call theme_image() directly, use theme('image', ...) instead.
• template_preprocess_whami_source_adapter_wikipedia_content(): $entry['body'] stems from an untrusted third party source, so you need to sanitize that. See http://drupalscout.com/knowledge-base/drupal-text-filtering-cheat-sheet-... Or does geonames already sanitize this?
• "t('Author: ') . l($variables['owner_name'], $variables['owner_url'], array('external' => TRUE));": do not concatentate translatable strings, use placeholders instead.
• htmlentities($logo . '<br />' . $title_link . '<br />' . $owner_link . '<br />' . $variables['panoramio_license']);: this will break the br tags, no? And you should use check_plain(), filter_xss() or whatever Drupal function is appropriate.

Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

Hi,

since all requirements have been fulfilled by now ... I would like to ask in the most polite way, if there are any obstacles left, keeping this module from being published?

Regards,
Martin.L

Sorry for the delay, indeed the biggest obstacle is the small number of reviewers :/

Please consider doing another 3 manual reviews of other projects so we can come back to you sooner.

To be honest...this is some kindda frustrating. Every time we have eliminated all visible errors, new ones are being discovered, hindering this great module from being availabe to the community. All errors have been resolved: Could you please take a final look ... and release it? Thank you so much ...

added text "Reviews of other projects" in a h2 tag for better readability

added PAReview: review bonus as per http://drupal.org/node/1410826

Review of the 6.x-1.x branch:

• ./modules/whami_source_adapter_wikipedia/whami_source_adapter_wikipedia.tpl.php: the byte order mark at the beginning of UTF-8 files is discouraged, remove it.
• ./modules/whami_source_adapter_wikipedia/whami_source_adapter_wikipedia.info: the byte order mark at the beginning of UTF-8 files is discouraged, remove it.
• Drupal Code Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. Get a review bonus and we will come back to your application sooner.

manual review:

1. whami_source_adapter_demo(): why do you check_plain() the session id, you are not printing it anywhere here? Sanitization is only necessary if you are outputting user provided input, otherwise the data passed around should be kept as is. See also http://drupal.org/node/28984
2. Same in whami_source_adapter_wikipedia_block(). And whami_source_adapter_panoramio_block().
3. whami_source_adapter_wikipedia_block(): "module_load_include('inc', 'whami_source_adapter_wikipedia');": no need to use module_load_inlcude as you are including files from your own module which you already know where they are. Use something like require_once dirname(__FILE__) . '/mymodule.inc';
4. whami_source_adapter_panoramio.module: are you sure that you need to globally include the inc files? You should include them only if you actually need them, so that they are not included on every single page request.
5. "theme_image(drupal_get_path('module', 'whami_source_adapter_panoramio') . '/panoramio-logo.png');": don't call theme_image() directly, use theme('image', ...) instead. Same for theme_table() calls.
6. "htmlentities($logo . '<br />' . $title_link . '<br />' . $owner_link . '<br />' . $variables['panoramio_license']);": you have HTML tags in that call, but you escape them afterwards?

Although you should definitively fix those issues they are not application blockers, so I guess this is RTBC. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

Thanks for your contribution and welcome to the community of project contributors on drupal.org!!

I've granted you the git vetted user role which will let you promote this to a full project and also create new projects as either sandbox or "full" projects depending on which you feel is best.

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

As you continue to work on your module, keep in mind: Commit messages - providing history and credit and Release naming conventions.

Thanks to the dedicated reviewer(s) as well.