Node Reference Selector Widget

Hello. I spent manual review of your module.

'#title' => check_plain(t('!name Image Field', array('!name' => node_type_get_name($type)))),
Use @ instead of ! then check_plan will not need.

function nodereference_selector_field_widget_form - double space between function and name.

Hello skein,

Please move your code from master repo to version specific branch. Check this for more - http://drupal.org/node/1127732

There are still files other than README.txt in the master branch, make sure to remove them. See also step 5 in http://drupal.org/node/1127732

First of all, thank you for contributing!

Automatic review of 7.x-1.x branch:
Review of the 7.x-1.x branch:

• Drupal Code Sniffer has found some code style issues (please check the Drupal coding standards). See attachment.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. Get a review bonus and we will come back to your application sooner.

FILE: ...all/modules/pareview_temp/test_candidate/css/nodereference_selector.css
--------------------------------------------------------------------------------
FOUND 5 ERROR(S) AFFECTING 5 LINE(S)
--------------------------------------------------------------------------------
 13 | ERROR | Multiple CSS properties should be listed in alphabetical order
 17 | ERROR | Multiple CSS properties should be listed in alphabetical order
 18 | ERROR | Multiple CSS properties should be listed in alphabetical order
 20 | ERROR | Multiple CSS properties should be listed in alphabetical order
 22 | ERROR | Multiple CSS properties should be listed in alphabetical order
--------------------------------------------------------------------------------

Source: http://ventral.org/pareview - PAReview.sh online service

Manual review of 7.x-1.x branch:

1. function nodereference_selector_field_widget_info() Is there a hook_widget_info() in D7? It's not listed on api.drupal.org but I am not very familiar with CCK in 7.x
2. line 84 of nodereference_selector.module: $query = db_select('node', 'n'); - Please consider using hook_query_alter as per When to use db_rewrite_sql or hook_query_alter()
3. Please consider use the placeholders for readability and security. Please have a look here.

status updated.

1. D'Oh! I must have been blind!
3. Point taken!

As far as I can tell this is good to go. Maybe a more experienced reviewer could review it and see if it is RTBC ready.

hmm..my selections are not saving...has anyone experienced this? its a multi select field

Review by Pareview:
Good.

Manual review:
Major issues:
None

Small issues:

• I can enable node types that don't have an image field. Therefore I can not complete the next settings page where I have to chose the image field. I have to go back and than it works. Maybe a check for this can be made at the first settings page.
• $(".field-widget-nodereference-selector input").hide();
  Why is this code in js file and not in css?
• You have some kind of javascript searcher of your nodes. It's better to implement this with the form API with the ajax parameters. Then your input field will also be themed correctly. It's also better if you want to extend your module with more advanced searches. With your way of doing things, you can only search the image title.

I also tested the multiple select and it works fine.

Sorry for the delay, but you have not listed any reviews of other project applications in your issue summary as strongly recommended in the application documentation.

Thanks for your contribution, skein! Welcome to the community of project contributors on drupal.org.

I've granted you the git vetted user role which will let you promote this to a full project and also create new projects as either sandbox or "full" projects depending on which you feel is best.

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

As you continue to work on your module, keep in mind: Commit messages - providing history and credit and Release naming conventions.

Thanks to the dedicated reviewer(s) as well.