OpenLayers Locator (D7)

Hello. I spent manual review of your module.

Readme.txt - max string length recomended is 80 chars . In other places also.
version = "7.x-1.0-dev" - remove version tag. Drupal.org add it automatically.

I can confirm the issues in #1 are fixed now. The only issue I see is namespacing. It looks like you've consistently prefixed the various elements you're defining (e.g. fields, content types, maps) with ol_locator_, which is great. However, that prefix doesn't match your module's machine name, openlayers_locator, so there could be conflicts with a hypothetical module named ol_locator. This is unlikely, but it's also a pain to change later (you'd need to remove and re-create everything), so I suggest changing it before this is promoted to a full project. It's probably easier to change the module name by doing a new export, rather than re-naming everything in the export.

Sorry, I should have been clearer before. Changing the project name is a little more complicated than changing the project line in the .info file. And now that I'm looking at it, that line shouldn't be there at all, since it gets added automatically by the packaging script. See: http://drupal.org/node/542202#project

Before you have releases, the project name shows up in two places: file names and function prefixes. So to change your project name to "ol_locator", you'll need to change the name of files like "openlayers_locator.info" to "ol_locator.info" and change the name of functions like "openlayers_locator_openlayers_maps" to "ol_locator_openlayers_maps". You might find this easier to do by re-exporting the feature rather than going through every function and file name.

I hate to keep moving this back to "needs work," but it looks like openlayers_locator_views_api() and openlayers_locator_views_default_views() still need name changes. Everything else looks great.

Everything now looks good to me.

There are still files other than README.txt in the master branch, make sure to remove them. See also step 5 in http://drupal.org/node/1127732

Thanks for your contribution, nicoz! Welcome to the community of project contributors on drupal.org.

I have promoted your sandbox to a full project.
http://drupal.org/project/ol_locator

Now that this experimental project has been promoted, you'll need to update the URL of your remote repository or reclone it.

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

As you continue to work on your module, keep in mind: Commit messages - providing history and credit and Release naming conventions.

Thanks to the dedicated reviewer(s) as well.

Your application got tagged with "Single project promote" what means that your project only gets promoted manually and you don't get a permission to promote on your own.

Usually we use this tag for modules with too few lines of hand-written code that can not be reviewed seriously.
In your case the problem is that this is a feature containing (as far I can see) none custom code.

This process is about reviewing the applicants coding skills for making sure that the applicant knows how to work with drupal's API in a correct and secure way.

I'm sorry this is probably disappointing for you, but you have to get through this process again with at least ~120 lines of custom code and ~5 custom functions, so we can make a serious review.

Great,
then please consider to come back with a theme soon and we'll review it and make you a vetted user.
Surely this will again take some time, but we're tending not to do exceptions as this would not be fair to others, sorry.

See you then