Rewrite token integration to be more entity generic

I see the problem, regarding the UUID token integration. I was too quick committing the token patch that was provided. I'm gonna revisit the token integration to be more generic, and fix the problem at the same time. Hopefully I can release this in a new version soon.

However, the error messages regarding update_calculate_project_update_status() and theme_status_report() doesn't seem to be related to UUID.

I'm only seeing it on Node pages where I've overridden the page template with Panels/Page Manager.

However, reverting to alpha2 for the meantime...

(*EDIT* meant to state I'm only getting the 'Notice: Undefined variable: replacements in uuid_tokens() (line 95 of uuid.tokens.inc).' error)

i am getting the error on the front page and other pages intermittently

Notice: Undefined variable: replacements in uuid_tokens() (line 95 of /var/aegir/platforms/7/modules/all/uuid/uuid.tokens.inc).

subscribing

I'm trying deploy content with the deploy module. After run cron I see error message "The website encountered an unexpected error. Please try again later."
and in the "Recent log messages" I see many messages "Notice: Undefined variable: replacements in uuid_tokens() (line 95 of /home/ecodev/public_html/sites/all/modules/uuid/uuid.tokens.inc)"

This issue is the hook method tries to return a variable but it is never declared, if none of the entity targets evaluate.

Patch applied to add the declaration for the property.

Changing status for patch.

Dixon don't assign an issue unless you intend to fix the and or are the maintainers for the module.

Sigh, bad patch let's try this one.

Changing so the patch will get evaluated.

This is ridiculous, just add this ($replacements = array();) on to line 48 of uuid.tokens.inc

47: function uuid_tokens($type, $tokens, array $data = array(), array $options = array()) {
48:   $replacements = array();
49:   switch ($type) {
50:     case 'node':
51:       $node = $data['node'];

[[Facepalm]] I just realized Dixon is the maintainer.. sorry Dixon.. (sigh)

I've rewritten the Token support to be more generic and support all entities, even those declared by other modules that support UUIDs. It's committed to 7.x-1.x. So please give the new integration a ride.

If I don't find any immediate problems, I'll probably gonna roll a new alpha release today.

I'm assuming that #17 refers to the following commit:

Universally Unique IDentifier: February 3, 2012 19:15

Commit c2bb832 on 7.x-1.x
by dixon_
 Rewrote the Token support to be more generic and support all UUID entity types.

After that commit I am now getting the following messages whenever I attempt to edit content.

Notice: Undefined index: uuid in uuid_tokens() (line 38 of ...\sites\all\modules\uuid\uuid.tokens.inc).
Notice: Undefined index: vuuid in uuid_tokens() (line 40 of ...sites\all\modules\uuid\uuid.tokens.inc).

In lines 38 and 40 of uuid.tokens.inc, $tokens has no uuid or vuuid index values.

Adding to #18, I have attached images of the local variables and call stack at the time uuid_tokens(...) is executed.

Same error here on latest dev release

Actually - only getting the uuid problem (line 38), but I've only tried editing taxonomy so far.

Same errors as #18 on latest dev. Two notices in the log for every page view, not just edits..

Errors still kicking around.

Same here:
Notice: Undefined index: uuid in uuid_tokens() (line 38 of /www/htdocs/nnn/sites/all/modules/uuid/uuid.tokens.inc).
Notice: Undefined index: vuuid in uuid_tokens() (line 40 of /www/htdocs/nnn/sites/all/modules/uuid/uuid.tokens.inc).

I'll look to some experts for confirmation. But I believe that the hook_token function is called whenever token_replace has been called. However, the tokens needing to be replaced will not always contain uuid or vuuid (or any other possible token from the UUID module). The latest change to the uuid_tokens function in uuid.tokens.inc assumes that the "uuid" or "vuuid" keys will always exist in the $tokens parameter of the function. This is not true, and is what is causing the error messages.

If it should always be true, that is another issue. But I don't think that is the case. In my case, pathauto has called token_replace and the only token key in $tokens is "title".

There may be a more efficient way to test whether or not the uuid_tokens should immediately return, but the patch that I have attached adds tests to see if the desired $token key even exists before it attempts to provide a replacement.

It has stopped the error messages. The question is have I introduced any other problems as a result?

Seems to work for me! Thanks a lot...

#24 seems to be working for me as well.

While #24 patch didn't work for me (on 7.x-1.x-dev from 02.04.2012 with patch -p0 < test_if_replacement_requested-1423542-24.patch) I did manage to apply the change manualy.

And while edit error did go out, I still get error on submit

    Warning: explode() expects parameter 2 to be string, array given in menu_node_submit() (line 723 of /home/spirid/tempus.dx.rs/modules/menu/menu.module).
    PDOException: SQLSTATE[23000]: Integrity constraint violation: 1048 Column 'menu_name' cannot be null: INSERT INTO {menu_links} (menu_name, plid, link_path, hidden, external, has_children, expanded, weight, module, link_title, options, customized, updated) VALUES (:db_insert_placeholder_0, :db_insert_placeholder_1, :db_insert_placeholder_2, :db_insert_placeholder_3, :db_insert_placeholder_4, :db_insert_placeholder_5, :db_insert_placeholder_6, :db_insert_placeholder_7, :db_insert_placeholder_8, :db_insert_placeholder_9, :db_insert_placeholder_10, :db_insert_placeholder_11, :db_insert_placeholder_12); Array ( [:db_insert_placeholder_0] => [:db_insert_placeholder_1] => 0 [:db_insert_placeholder_2] => node/107 [:db_insert_placeholder_3] => 0 [:db_insert_placeholder_4] => 0 [:db_insert_placeholder_5] => 0 [:db_insert_placeholder_6] => 0 [:db_insert_placeholder_7] => 0 [:db_insert_placeholder_8] => menu [:db_insert_placeholder_9] => Tempus projekat [:db_insert_placeholder_10] => a:0:{} [:db_insert_placeholder_11] => 0 [:db_insert_placeholder_12] => 0 ) in menu_link_save() (line 3109 of /home/spirid/tempus.dx.rs/includes/menu.inc).

#24: isset() tests should go before empty(), other than that the patch looks right by me.

#27: That error looks unrelated. As for the patch, did you try -p1?

Updated patch in #24 to do isset() checks before empty() checks; done against 7.x-1.x-dev from 02.04.2012.

@MacMladen - not getting any errors during submit on my end. Possible that your error is caused by something else?

Patch in #29 eliminates the 'Undefined variable: replacements in uuid_tokens()' errors.

Patch #29 works for me.

Patch in #29 fixed my errors:

Notice: Undefined index: uuid in uuid_tokens() (line 38 of /***/modules/uuid/uuid.tokens.inc).
Notice: Undefined index: vuuid in uuid_tokens() (line 40 of /***/modules/uuid/uuid.tokens.inc).

Thanks everyone for the work on this! Much appreciated.

Committed patch from #29 to 7.x-1.x.

Thanks @emptyvoid #14 fixed my notice problem

I am getting the same error after submit node form.

Notice: Undefined variable: replacements in uuid_tokens() (line 95 of /var/aegir/platforms/7/modules/all/uuid/uuid.tokens.inc).

I am using 7.x-1.0-alpha3 version.

sarjeet.singh - you need to download the latest dev snapshot, and report only if it does not fix the problem.

acrollet - now i am using dev version (7.x-1.0-alpha3+8-dev).
I am getting same issue.
Notice: Undefined variable: replacements in uuid_tokens() (line 95 of /var/aegir/platforms/7/modules/all/uuid/uuid.tokens.inc).

@sarjeet.singh : There are only 46 lines in this file so you may check it is not a conflict from you versionning system.

---

@all :
I made a self review of this file because I was having same notices as #32 and I found a very very tiny issue highly depending on PHP version.

You wrote

if (isset($info['uuid']) && $info['uuid'] == TRUE && isset($tokens[$info['entity keys']['uuid']]) && !empty($info['entity keys']['uuid'])) {

Instead of

if (isset($info['uuid']) && $info['uuid'] == TRUE && !empty($info['entity keys']['uuid']) && !empty($tokens[$info['entity keys']['uuid']])) {

As PHP is reading boolean statements from left to right you might inverse your last two conditions to avoid testing if there is an empty key in the $tokens array.
Moreover, you may replace the "isset" function by a "!empty" one unless you want token to replace empty string ;)

Here is a small patch

Just to clarify where things are now, what would be the way to fix this? Download the dev version, or apply the patches (and which one(s) in which order)?

Thanks

I would love to be one of the maintainers of this great module but I am not so until one of them say it is commited, you will have to apply the patch. Mine (#28) is currently applied on 3 different projects and seems to work well.

See #33 - It's committed in the 1.x-dev version

The problems still seems to be there, and the changes introduced in #38 by DuaelFr makes perfect sense. So I've committed that. So that should finally fix this.

Thanks everyone.

#11: uuid-uuid_token-1423542-7.patch queued for re-testing.

Receiving following notice on my website:

Notice: Undefined index: token type in uuid_token_info() - line 16 in uuid.tokens.inc

@mh86 Can you make sure that you are running the latest dev version? I though we fixed this...

I can actually confirm the PHP notice mentioned in #44. I'll fix this.

Fixed. Thanks for the notice!

@ comment #14 perfect. thank you.

comment #14 works! Thanks emptyvoid

@emptyvoid suggestion in #14 appears to fix the problem.

I used #14 and it fixed my problem. Now it's giving me an error for the node:

Undefined index: node in uuid_tokens():

notice: Undefined index: node in uuid_tokens() (line 52 of /xxx/sites/all/modules/uuid/uuid.tokens.inc).
Notice: Undefined index: node in uuid_tokens() (line 53 of /home/xxx/rb/sites/all/modules/uuid/uuid.tokens.inc).

i recommend rewriting the function so it checks for the array key. I'll write a patch later

Marked #1810226: Error message when deploying a site: Undefined variable: $replacements as a duplicate of this issue.