snapengage

Hello
I spent a Review of your module.
ventral.org/pareview showed no deficiencies.

There is only one comment:
function snapengage_admin_settings_form
Why do you use a blank description, if so, why should the function t: '# description' => t (''),

Hi arnested,
Module works very well, I didn't noticed any major problem during a 6.x-1.x branch manual review. The only thing I can suggest is to consider creating a .install file to delete all module's variables during module uninstall (snapengage_widget_id, snapengage_roles, etc..).

From a phpcs scanning I noticed there are some little code cleaning to do, I attach the scanning results.

Greetz

Hi arnested,

your Readme.txt should contain some more information about how to configure your module. You should also add that to your project page.

Why do you add a separate permission for the configuration? I think this is a case where the default roles should be sufficient. Maybe you can explain this.

Rest of the code looks clean to me.

Hi @arnested, I've manually reviewed the module for 7.x and It looks really good. I'd maybe add a link to https://secure.snapengage.com/widget in the description for the widget id field at admin/config/system/snapengage but that's not a blocker at all.

The module worked without problems and the code and the UI seem to comply with Drupal coding and documentation standards to the best of my knowledge.

This does seem ready for full project status IMO so marking as RTBC.

Sorry for the delay, but you have not listed any reviews of other project applications in your issue summary as strongly recommended in the application documentation.

manual review:

1. snapengage_init(): why can't you add the external javascript directly with drupal_add_js()? See http://drupal.org/node/756722
2. snapengage_init(): why do you need sprintf() and can't use the "." string concat operator?
3. "user_access('use PHP for tracking visibility');": that permission is not defined?

But that are not blockers, so ...

Thanks for your contribution, arnested! Welcome to the community of project contributors on drupal.org.

I've granted you the git vetted user role which will let you promote this to a full project and also create new projects as either sandbox or "full" projects depending on which you feel is best.

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

As you continue to work on your module, keep in mind: Commit messages - providing history and credit and Release naming conventions.

Thanks to the dedicated reviewer(s) as well.

congrats @arnested!