Id3 Tags / Metadata being trimmed

drumfreak - May 18, 2007 - 20:26
Project:Audio
Version:5.x-1.x-dev
Component:audio_getid3
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed
Description

In the latest download, anytime you do an operation which involves uploading an Mp3, the last character of each Id3 / metadata tag is trimmed off before storing in the database.

#1

schnizZzla - May 19, 2007 - 16:19
Priority:normal» minor

Having the same problem. I tested the next dev version, this seems fixed in 2.x-dev.

#2

schnizZzla - May 19, 2007 - 16:43

maybe not, i only tried genre "0123456789012345678901234567890123456789", that worked but "Funk Rock" still comes out "Funk Roc" ...

#3

schnizZzla - May 19, 2007 - 17:54
Status:active» duplicate

this seems a dupe of
http://drupal.org/node/135127

#4

schnizZzla - May 19, 2007 - 18:02
Status:duplicate» active

maybe thats two issues:

input:

FunkRock

saved db entry:

FunkRoc

saved to file:
FunkRock

#5

schnizZzla - May 19, 2007 - 18:50

I think the problem is in
function audio_clean_tag()

#6

schnizZzla - May 19, 2007 - 18:51
Component:audio_getid3» Code

i don't think this is the getid3 module

#7

schnizZzla - May 19, 2007 - 19:00

argh, I give up on that today, the last guess seems wasn't right, the tag comes in already trimmed

#8

Darren Oh - May 20, 2007 - 21:18
Status:active» won't fix

This is a getID3 library problem. The error is line 647 of module.tag.id3v2.php, version 1.7.8b1. The = should be ==.

Bug report here: http://www.getid3.org/phpBB2/viewtopic.php?t=727

#9

schnizZzla - May 31, 2007 - 13:18

worked :-) a simple typo

thanks for the support, i should have considered, that this is a getid3 problem.

#10

drewish - July 25, 2007 - 14:59

marked http://drupal.org/node/161852 as a duplicate of this... perhaps i should change the recommended version back to 1.7.7?

#11

hbar - July 25, 2007 - 15:31

Are you recommending I go back to getID3 1.7.7? Or should I edit the 'module.tag.id3v2.php' file, as suggested by Darren Oh?

#12

drewish - July 25, 2007 - 15:55
Component:Code» audio_getid3

i think either would work. editing the 1.7.8 might be best.

#13

hbar - July 25, 2007 - 19:21

I tried Darren Oh's getID3 fix on my local site:

This is a getID3 library problem. The error is line 647 of module.tag.id3v2.php, version 1.7.8b1. The = should be ==.

Bug report here: http://www.getid3.org/phpBB2/viewtopic.php?t=727

Now the Metadata tag's last character is replaced by a "?" (after I've edited the node). Hmm. Different but similar problem.

I'm going to try and go back to the previous getID3 version. Thanks for your help, anyway. :)

#14

drewish - August 1, 2007 - 04:53

marked http://drupal.org/node/163578 as a duplicate

#15

drewish - August 11, 2007 - 15:22
Status:won't fix» active

marked http://drupal.org/node/166425 as a duplicate.

making this active so it's easier for people to find. still something i'm not going to fix though.

#16

drewish - August 29, 2007 - 21:54

changing the recommended version back to 1.7.7. committing this to HEAD and DRUPAL-5.

AttachmentSize
audio_getid3_145117.patch583 bytes

#17

sgriffin - August 30, 2007 - 03:37

Audio Import is still broken.. But editing the node itself is fixed..
I tried 1.7.7 1.7.6 & 1.7.5 with Audio 5.x-1.x-dev
1.7.6 from sourceforge is really 1.7.5 btw and 1.7.5 throws errors.

#18

sgriffin - August 30, 2007 - 03:48

nevermind.. I was reimporting the same audio files, that seem to have had their tags rewritten by the bug.

#19

drewish - September 13, 2007 - 18:50
Priority:minor» normal

marked http://drupal.org/node/175322 as a duplicate

#20

pyutaros - September 19, 2007 - 18:26

@ #8 You quoted the wrong line. Here's the exact text from the forum post:

You must edit the file "module.tag.id3v2.php"
on line 646 you must put an equlity sign == double equals sign intead of the single = sign

if ($string[strlen($string)-1] = "\x00")

becomes

if ($string[strlen($string)-1] == "\x00")

That's a nasty little bug! ;)

Should be line 646 not 647.

#21

drewish - September 24, 2007 - 15:41

marked http://drupal.org/node/178067 as a duplicate

#22

Darren Oh - September 24, 2007 - 16:21

The problem is that the current release still recommends version 1.7.8b. Can we get a new release?

#23

drewish - September 24, 2007 - 23:09

-dev suggest 1.7.7 but a new release isn't a bad idea.

#24

drewish - September 24, 2007 - 23:13

#25

Darren Oh - September 25, 2007 - 00:44
Status:active» fixed

#26

Anonymous - October 9, 2007 - 00:52
Status:fixed» closed

#27

drewish - October 30, 2007 - 02:57
Status:closed» active

i marked a bunch of issues that were duplicates of this as duplicates of http://drupal.org/node/156476 . i'm going to mark this as active just so people can find it easily.

short fix is to downgrade getid3 to 1.7.7.

#28

mediafrenzy - November 1, 2007 - 22:15

Hi Drewish, you directed me to this thread from my previous one about iTunes mp3s creating question marks etc....

But unfortunately the quick fix described here is to downgrade to GetID3 1.7.7 - which is what I'm already using according to the audio.module getid3 status message?

I can supply a problem iTunes mp3 if it would help?

#29

drewish - November 2, 2007 - 05:53

if we won't get in trouble for copyright violations, post it, otherwise drop me a message and i'll hit you back with an email you can send it to... or if it's posted some place just post the link.

#30

mediafrenzy - November 8, 2007 - 20:57

Thanks Drewish - have just emailed you

#31

drewish - February 4, 2008 - 01:38

marked http://drupal.org/node/215736 as a duplicate.

#32

a great place f... - February 4, 2008 - 06:51

I'm getting the same problem although the question marks don't show up on Safari, they do on Firefox. I'm using getid3 1.7.7, audio 1.3, drupal 5.6. I can edit the question marks off but my users won't be able to do this.

#33

facelikebambi - February 23, 2008 - 18:00

I get exactly the same question marks problem - screenshot here

I can edit the content item and just delete them, but not so easy for my users.

Using Drupal 5.6, Audio 1.3 and getID3 1.7.7

Thanks!

#34

BrianJubal - March 4, 2008 - 19:34

Subscribing - same issue as facelikebambi - I am using Drupal 5.7, getID3 1.7.7, latest Dev version of audio node (5.x-1.x-dev), and firefox.

BTW - When I was zipping through the forums (I've done it 2 times to see if anyone else was having this issue) I blew right past this because mine is NOT chopping off the last character, I am getting a %00 character (I'm using pathauto, so %00 is what's showing up in the url), which if I understand correctly, is a NUL character, which is being replaced by the lovely diamond question mark (as shown in facelikebambi's screenshot). Glad I read through this whole thing to find this.

#35

mediafrenzy - March 5, 2008 - 08:22

Yup I've still got the question marks being added to certain MP3s also...

I posted an issue before, which I've reopened.
http://drupal.org/node/186801

BrianJubal - You guys might like to add to that issue page as well, to avoid others overlooking it on this page, as you and I both did initially due to the top of this page being actually about another bug altogether.

#36

deadman - May 4, 2008 - 13:59

I was having the same problem with some mp3's displaying the diamond question marks. I've solved the issue by changing the encoding of id3v2 to ISO-8859-1 (instead of UTF-8).

to do this, edit "audio_getid3.module" and edit line 254 (or thereabouts), change:

  $getID3->encoding         = 'UTF-8';

to:

  $getID3->encoding         = 'ISO-8859-1';

I'm not sure if this has any other side effects, but it seems to be working fine for me.

#37

BrianJubal - May 7, 2008 - 13:10

I don't know if your fix has any side effects, but based on the nature of what is happening (substitution strings) I can't imagine there being any side effects to the fix in http://drupal.org/node/186801.

#38

drewish - May 23, 2008 - 19:24
Status:active» fixed

i *think* this is fixed so i'm going to close this issue. please re-open if that's not the case.

#39

Anonymous (not verified) - June 6, 2008 - 19:25
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.