Posted by anni on February 23, 2012 at 11:20am
5 followers
Jump to:
| Project: | Simplenews |
| Version: | 7.x-2.x-dev |
| Component: | Miscellaneous |
| Category: | bug report |
| Priority: | major |
| Assigned: | Unassigned |
| Status: | active |
Issue Summary
After clicking on the link in the confirmation mail I get an "Access denied"
The subscriber doesn´t get confirmed.
Comments
#1
Do anonymous users have
subscribe newsletterspermission?#2
Yes.
#3
whats the URL like?
#4
Hi,
it´s "...newsletter/confirm?hash=k60TQyNwstUXYtSCn84QjbGlN670GrQMTd6efSZMOzU".
#5
hmm i have no clue as to what could cause this behavior:/
any entries in reports recent logs (dblog) ?
#6
Yes.
Type: access denied
Date: Thursday, February 23, 2012 - 12:51pm
User: Anonymous (not verified)
Location: .../newsletter/confirm?hash=k60TQyNwstUXYtSCn84QjbGlN670GrQMTd6efSZMOzU
Referrer:
Message: newsletter/confirm
Severity: warning
Hostname: ...
Operations:
#7
sorry,no idea whats causing this.maybe another module you are using?
#8
Maybe simplenews?
I´ll try a clean installation and will report back.
#9
Yes simplenews could be the cause, since it has a menu entry
newsletter/confirmjust like newsletter module does.Simplenews should use
simplenews/confirminstead.Thus i am sending this to simplenews issue queue
#10
We prefer to state "Simplenews conflicts Newsletter module".
First simplenews was first to "allocate" the /newsletter/ module namespace.
Then, simplenews provides concepts like "Newsletter" and not a "Simplenews". We decided during name cleanups to confirm this previous name also.
Also if we once will implement an entity for the Newsletter, the entity will have a name like "Newsletter" and not "Simplenews"...
Even if you think this might be wrong and a namespace in the URL should be prefixed with the module name, we won't be able to do that. Beta level guarantees API stability and the callback URL is an API relevant thing. We won't break millions of already sent links.
I still vote for a merge of those modules and i also don't see a reason to use both at the same time.
#11
Agreed on most points but
Module's name and URL here in d.o was and is the namespace.It is the best practice to use your module's namespace to avoid incompatibilities like these.
It was the wrong thing to do and still is.Just because it happened doesnt make it right:)
That said, i agree, no point to break existing links and API (especially when its highly unlikely for one to use these 2 modules together), but it should be noted as a thing to fix in the future.I would say "postponed" is the right status here
#12
Agreed with postponed, we might look into this later. I am not sure if the namespacing rules apply to menu paths like they do to function names but I also agree that newsletter doesn't belong to us just because we were here first.
And yes, would be wrong to change it now and break all existing links and integrations.
I will add a point to the known problems section.
#13
@rootatwc
So, at the time there is no chance to get a working confirm link (in newsletter module) if newsletter and simplenews is installed both?
#14
No, there isn't.
Why would you want to use both modules at the same time anyway, that makes no sense?
#15
Because I need functions from newsletter module (include Views, send newsletters after x days, etc.), but encountered bugs.
So I had to find a solution for standard newsletters and thats the good old simplenews.
#16
See http://drupal.org/project/simplenews_scheduler for recurring newsletters and inserting views can for example be done in the templates.
#17
Hmmmmm, why not. I´ll give it a try.
Thank you!
#18
great, we can come back to this and fix it once the 2.x-dev branch opens:)
#19
Im not sure how different the module is for Drupal 6, but I submitted a patch for the D6 version here: http://drupal.org/node/1801300
- I have tested it, and it seems to be working just fine.
#20
Reopening in 7.x-2.x.
We can discuss now about a new naming scheme.