The same issue exists in drupal 7 here: http://drupal.org/node/1451802

Basically, there the simplenews module is using urls with "newsletter/" which conflicts with the newsletter module. There is no reason these shouldn't be "simplenews/" instead.
Ive been testing this for a few weeks with alpha4 and now alpha5, and...

The solution is to change that in the Simplenews module file (modules/simplenews/simplenews.module) from "newsletter/" to "simplenews/" on lines 2488, 2110, 2101, 2100, 270, and 263.

Thanks!

CommentFileSizeAuthor
#5 simplenews-newsletter_path_fix-1801300-5.patch12.38 KBAbelito
#5 simplenews-newsletter_path_fix-1801300-5.patch12.38 KBAbelito
#4 simplenews-newsletter_path_fix-1801300-4.patch9.45 KBAbelito
#1 simplenews-newsletter_path_fix-1801300-1.patch2.62 KBAbelito

Comments

Abelito’s picture

Abelito commented
Status: Needs review » Patch (to be ported)
StatusFileSize
new simplenews-newsletter_path_fix-1801300-1.patch2.62 KB

Ok, I made a patch, my first one!

ParisLiakos’s picture

ParisLiakos commented
Version: 6.x-2.0-alpha5 » 6.x-2.x-dev
Status: Patch (to be ported) » Needs review

Hello and thnaks!

  • When you create patches make sure you create them against development versions.
  • When you submit a patch turn status to needs review

Status: Needs review » Needs work

The last submitted patch, simplenews-newsletter_path_fix-1801300-1.patch, failed testing.

Abelito’s picture

Abelito commented
Status: Needs work » Needs review
StatusFileSize
new simplenews-newsletter_path_fix-1801300-4.patch9.45 KB

Thanks for the tips rootatwc!
I can't be certain I have everything right this time, as it takes learning to get used to this process.
- I used 6.x-2.x under "Version to work from", which should be the dev version according to the instructions.

We'll see if it passes the test.

Abelito’s picture

Abelito commented
StatusFileSize
new simplenews-newsletter_path_fix-1801300-5.patch12.38 KB
new simplenews-newsletter_path_fix-1801300-5.patch12.38 KB

Use this revision, it updates the comments as well.

- sorry about posting it twice. the drupal site went down just before i hit submit.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Priority: Major » Normal
Status: Needs review » Closed (won't fix)

I nor accept the issue as major for 6.x-2.x nor will we change the pathes in any 6.x.

6.x-2.x is bugfixing only.
Switching pathes will break sites and persisted links as same as extensions. A path is on the same level as a function declaration change.

We use the path for historic reasons and where first.
Also i don't see reason to use both modules at once.

Help merging the newsletter module into the 7.x branch!