This little module allows people to pick up nodes in a basket (currently session-stored), so that custom operations can then be performed on these nodes by implementing a hook : print nodes, send the nodes by e-mail, create a PDF containing the nodes,...

This need has been briefly discussed here and there.

An alternative to get the same kind of functionnality might be to use the Flag and VBO modules, but with Node Basket all is packaged in a one-goal little module.

The readme says :

* Install it as any module.
* New links will appear on node pages.
* A new block will be available on the blocks configuration page.
* A menu item to the basket page can be enabled.

* Use node_basket_get_content() to list the user's picked up nodes in your own custom module.
* See API.txt for how to add operations to your node basket list.

* Link to project page : http://drupal.org/sandbox/gaelg/1378676
* Git command : git clone --branch master http://git.drupal.org/sandbox/gaelg/1378676.git node_basket
* This is a Drupal 6 project (D7 port should be quite easy though).
* Used on a production site : http://www.archipedagogie.org/en/node-basket

Comments

kongoji’s picture

kongoji commented
Assigned: gaëlg » Unassigned

Hi GaëlG,
I tested the module and it works well, I write here something I noticed during manual review
1) You did a very good job in documenting your custom hook in API.txt file, consider documenting the hook in a way more near to drupal coding standards (see http://drupal.org/node/1354#hooks)
2) I would add in README.TXT that Print module is suggested or supported (I know is written in API.TXT, I just would write it in readme file too)
3) If a user has no pick up nodes permission, he still see a "Pick up" link that brings to an "access denied" page

Automatic validation seems to pass without problems.

Greetz

gaëlg’s picture

gaëlg
he/him
Primary language French
Location Lille, France
commented
Assigned: Unassigned » gaëlg
Status: Needs review » Needs work

Thank you very much for the review, I'll work on it.

patrickd’s picture

patrickd commented
Assigned: Unassigned » gaëlg
README.txt
Please take a moment to make your README.txt follow the guidelines for in-project documentation.
project page
Please take a moment to make your project page follow tips for a great project page.

It's nice that you thought about API documentation but it rather than in a .txt file it should be in a node_basket.api.php
Have a look at other modules and how they wrote their .api.php files, eg: path.api.php (click on view source)

Get a review bonus and we will come back to your application sooner.

patrickd’s picture

patrickd commented
Assigned: gaëlg » Unassigned

Please don't assign the issue to your self, only the current reviewer should do this.

gaëlg’s picture

gaëlg
he/him
Primary language French
Location Lille, France
commented
Status: Needs work » Needs review

Thank you for the review. I tried to do the suggested changes.

musikpirat’s picture

musikpirat commented

README.txt and the project page look good. The code itselfs is well documented.

I'd really suggest you to get a review bonus, since that really speeds up the review process...

Miszel’s picture

Miszel commented
Status: Fixed » Needs review

I have just installed and tested your module on a clean D6 installation and I can confrm that it works perfectly fine. The code is clean and indeed well documented.

I could imagine that creating similar functionality with Views, Flag and VBO would be a more flexible solution but if someone needs exactly what the module does, it may be a good choice.

Miszel’s picture

Miszel commented
Status: Needs review » Reviewed & tested by the community

Changing status

gaëlg’s picture

gaëlg
he/him
Primary language French
Location Lille, France
commented

Thank you Marcin!

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Reviewed & tested by the community » Fixed

You have not listed any reviews of other project applications in your issue summary as strongly recommended in the application documentation.

manual review:

  • I could imagine that this functionality is not wanted on every node type, maybe you should add a setting to which content types it may be applied?

But that is surely no blocker, so ...

Thanks for your contribution, GaëlG! Welcome to the community of project contributors on drupal.org.

I've granted you the git vetted user role which will let you promote this to a full project and also create new projects as either sandbox or "full" projects depending on which you feel is best.

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

As you continue to work on your module, keep in mind: Commit messages - providing history and credit and Release naming conventions.

Thanks to the dedicated reviewer(s) as well.

gaëlg’s picture

gaëlg
he/him
Primary language French
Location Lille, France
commented
Status: Needs review » Fixed

Thank you klausi. Yes, I started to review some projects, but missed the time to do 3 real manual reviews.
And you're right, the per-content-type feature would be nice.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.