Hi,

This is a new module to integrate OG into the core forum module. It allow to make some forum and their topic private to a certain group.

This module is not the same as the existing "OG Forum" as this one is only for D7. It use the all new APIs and Fields added by OG in the D7 release. The old "OG Forum" is still not fixed and its code is not anymore convenient for a D7 version.

The OG Forum D7 is currently in the very first step of its life. For now, it only apply the content access system of Organic Group on the forum topics and the forum taxonomy terms. But this is enough to help many website which need this functionality.

Later, i will improve it, by adding an administration for the forum inside each group with the OG permissions system to allow some member of the group to be moderator of the group internal forum.

Hope it will please you.

Project page : http://drupal.org/sandbox/epieddy/1470508
Repo : http://drupalcode.org/sandbox/epieddy/1470508.git
Clone :

git clone --branch master epieddy@git.drupal.org:sandbox/epieddy/1470508.git

Comments

michelle’s picture

michelle
she/her
Primary language English
Location Wisconsin, USA
commented

See also: http://drupal.org/project/spaces_og_forum

patrickd’s picture

patrickd commented
Status: Needs review » Needs work

welcome,

You are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.
(At least this has to be done before switching back to needs review)

while waiting for an in-depht review of your module you can start out fixing some coding style issues detected by automated tools:
http://ventral.org/pareview/httpgitdrupalorgsandboxepieddy1470508git

Please consider to get a review bonus and we will come back to your application sooner.

regards

epieddy’s picture

epieddy commented
Status: Needs work » Needs review

I fixed all the errors reported by the automated system and i created the correct git branch, plus i added a better integration with OG Context.

Hope it is better now.

Thx

epieddy’s picture

epieddy commented

I started integrating forum_access moderator functionality with OG Forum :

I added a "forum administrator" role in OG. Each member with this role will be declared as a moderator in each forum of the group.

epieddy’s picture

epieddy commented

Hi,

The module is now in production on http://www.fondation-lamap.org/.

We didn't found any bugs so far.

Regards

patrickd’s picture

patrickd commented
Priority: Normal » Critical

Raising priority after 4 weeks without any review :(
Sorry, we do really need more hands in the application queue and highly recommend to get a review bonus so we will(/can) come back to your application sooner.

seyv’s picture

seyv commented

Hi,

I've tested this module & it works like a charm. Although I have no experience with the OG module & Forums in Durpal 7, I could configure this nicely.

Maybe you could set an extra dependency to og_context. It is in your requirements, but will not 'automatically' enable when using Drush & would lead to some frustration when wanting to configure this quick.

+1

epieddy’s picture

epieddy commented

Hi,

Actually og_context is not required, although og_forum integrate with it to provide context detection.
It also integrate with forum_access now for a fully functional OG forum.

I've updated the Requirements in the README in consequences.

Hope it will soon be released.

Regards.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Assigned: Unassigned » tim.plunkett
Priority: Critical » Normal
Status: Needs review » Reviewed & tested by the community

Sorry for the delay, but you have not listed any reviews of other project applications in your issue summary as strongly recommended in the application documentation.

manual review:

  1. "$node->group_content_access['und'][0]['value'] = 2;": do not use "und", use the constant LANGUAGE_NONE. Also elsewhere.
  2. og_forum_node_access(): a break statement directly after a return statement is unreachable code, remove it. Same in og_forum_forum_group_handler().
  3. "return (array());": no need to use additional parenthesis around the return value. Also elsewhere.

But otherwise this looks RTBC to me. Assigning to tim.plunkett as he might have time to finally approve this.

epieddy’s picture

epieddy commented

Thank you for the review.

I have modified my code following your recommendations.

Hope it will be fine.

I'm really excited because it's my first contributed module. ^^
Sorry about not having reviewed other applications.

Regards.

michelle’s picture

michelle
she/her
Primary language English
Location Wisconsin, USA
commented
Assigned: tim.plunkett » Unassigned
Status: Reviewed & tested by the community » Fixed

I granted access based on klausi's RTBC. I think that's all that needs to be done? If not, let me know.

@epieddy Thanks for taking this one. This is wonderful for the community that has been without since the security mess on OG Forum. Bit sad on a personal level as it steals my thunder, though. LOL! But I'll get over it. ;)

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented

Thanks for your contribution, epieddy! Welcome to the community of project contributors on drupal.org.

Michelle has granted you the git vetted user role which will let you promote this to a full project and also create new projects as either sandbox or "full" projects depending on which you feel is best.

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

As you continue to work on your module, keep in mind: Commit messages - providing history and credit and Release naming conventions.

Thanks to the dedicated reviewer(s) as well.

epieddy’s picture

epieddy commented

It's ok, i have been able to create a full project. Thx.

@Michelle Steals your thunder ?

michelle’s picture

michelle
she/her
Primary language English
Location Wisconsin, USA
commented

@epieddy: Artesian (my new forum module) will have tight OG integration so I had images of me riding to the rescue of all the poor OG Forum users. Now I won't have their adulation when at last I unveil my new offering. :(

(Because text isn't always clear, yes, I am totally being silly up there. :) I am so not that egotistical. LOL!)

epieddy’s picture

epieddy commented

@Michelle LOL Ok, sorry for that ^^. But your module will still help a lot of forum users (OG or not) as it seems to really improve the default system and you still can be our hero :p

michelle’s picture

michelle
she/her
Primary language English
Location Wisconsin, USA
commented

Yay, I get to be a hero!

Except that means I need to get my butt moving and put in a few hundred hours of work... Hmmm... Guess being a hero isn't all glory, eh? :)

Michelle

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.