ZeitConnect

welcome,

i've added the missing project link

you're not authenticated to git correctly, so commits won't be associated with your useraccount,
have a look at the git instructions on your project page.

You are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.
(At least this has to be done before switching back to needs review)

while waiting for an in-depht review of your module you can start out fixing some coding style issues detected by automated tools:
http://ventral.org/pareview/httpgitdrupalorgsandboxtonybuckingham1475676git

You can also get a review bonus and we will come back to your application sooner.

regards

Manual Review:
1. Write hook_uninstall() to unset your variables.
2. In zeitconnect.admin.inc > line 81 use drupal_write_record() instead of db_query();
3. Replace 'delete queries' or 'select queries' with db_delete() or db_select() respectively.
4. In zeitconnect.admin.inc > line 23 use t() function to wrap description.
5. In zeitconnect.admin.inc > line 32, if you are not using $keys, then remove it.
6. Declare the $names before the foreach statement on line 33, in zeitconnect.admin.inc.

Manual Review:
1) admin.inc line 28, t() function missing, every description and title of form element should be wrap with this function.
2) When i installed your application and visit the admin page i got the following warnings:

   Warning: file_get_contents(http://www.zeitconnect.com/api/widgets/token/) [function.file-get-contents]: failed to open stream: A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond. in zeitconnect_admin_settings_form() (line 30 of zeitconnect\zeitconnect.admin.inc).
    Warning: Invalid argument supplied for foreach() in zeitconnect_admin_settings_form() (line 33 of zeitconnect\zeitconnect.admin.inc).

3) After submit i got these messages
Notice: Trying to get property of non-object in zeitconnect_admin_settings_form_submit() (line 83 of zeitconnect\zeitconnect.admin.inc).
Notice: Trying to get property of non-object in zeitconnect_admin_settings_form_submit() (line 83 of zeitconnect\zeitconnect.admin.inc).
4) Block description is showing blank. See attached block.png file.

• I installed your module, the 'Basic YY widget' content is too long, i would suggest to use some pagination.
• 'Widget 0f06b' block doesn't show any content and keeps on loading, screenshot attached.
• zeitconnect.admin.inc - line #7,8,9 Its a menu callback function, not a hook.
• zeitconnect.admin.inc - line #28, Block link is broken.
  use l() function here as it contains link
• zeitconnect.module- line #30, wrap t() inside l().

Forgot to attach screenshot, here it is.

manual review:

• zeitconnect_menu(): indentation errors, each level should use 2 spaces, not more.
• zeitconnect_menu(): do not use t() in hook_menu().
• zeitconnect_help(): do not concatenatre translatable strings, use a placeholder for the link instead.
• zeitconnect_block_view(): do not add javascript yourself, use drupal_add_js() or #attached in a renderable array.
• zeitconnect_admin_settings_form(): do not use json_encode(), use drupal_json_encode(). Same for json_decode().
• "'#value' => ' Save Settings ',": all user facing text should run through t() for translation.
• "$types = array('1' => 'Schedule', 2 => 'Prospect', 4 => 'Enrollment');": same here. Please check all your strings.
• zeitconnect_get_widgets(): why can't you use drupal_http_request()?

Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

manual review:

• zeitconnect_admin_settings_form_submit() and zeitconnect_admin_settings_form_validate(): these are not hooks, see http://drupal.org/node/1354#forms on how to document them.
• "variable_get('zeit_' . $widget['wkey'], ''),": all variable names of your module should be prefixed with the full name of your module, i.e. zeitconnect. That avoids name collissions with other modules.

But that are just minor issues, otherwise looks RTBC to me. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

Assigning to tim.plunkett as he might have time to finally approve this.

This looks great! I've attached a patch with a few tweaks, but nothing major.

Welcome to the community of project contributors on drupal.org.

I've granted you the git vetted user role which will let you promote this to a full project and also create new projects as either sandbox or "full" projects depending on which you feel is best.

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

As you continue to work on your module, keep in mind: Commit messages - providing history and credit and Release naming conventions.