This addresses http://drupal.org/node/114988 partly as it moves _advpoll_show_cancel_form into a themable function (theme_advpoll_results). I also simplified the function's arguments by just sending the $node object, which also is used by _advpoll_show_cancel_form. Win-win?

CommentFileSizeAuthor
#2 advpoll_themes_3.module.patch1.35 KBanders.fajerson
#1 advpoll_themes_2.module.patch1.35 KBanders.fajerson
advpoll_themes_1.module.patch1.32 KBanders.fajerson

Comments

anders.fajerson’s picture

anders.fajerson commented
StatusFileSize
new advpoll_themes_2.module.patch1.35 KB

Changed $output .= to $output = in two places.

anders.fajerson’s picture

anders.fajerson commented
StatusFileSize
new advpoll_themes_3.module.patch1.35 KB

Even better: move cancel button inside div.poll.

ChrisKennedy’s picture

ChrisKennedy commented

Isn't this going to be a problem if the user has voted but can't see the results (i.e. the poll is configured to only show results after the poll has closed)? In that case they wouldn't be able to cancel their vote.

anders.fajerson’s picture

anders.fajerson commented

True. I'll look into it.

ChrisKennedy’s picture

ChrisKennedy commented

There might be a way to solve this issue and http://drupal.org/node/143194 at the same time.

ChrisKennedy’s picture

ChrisKennedy commented
Status: Needs review » Needs work
pomliane’s picture

pomliane commented
Status: Needs work » Closed (won't fix)

This version of Advanced Poll is not supported anymore. The issue is closed for this reason.
Please upgrade to a supported version and feel free to reopen the issue on the new version if applicable.

This issue has been automagically closed by a script.