Description

Cloud9 displays view results in a tagcloud like fashion.

The main difference to modules like Tagadelic and Tagadelic_views, which strongly depend on the fields being taxonomy terms, is that it can display arbitrary view results as clouds, as long as they have a counting field for weight calculation.

The usage is a little more complicated than Tagadelic for easy cases like Tagclouds, but is more flexible and allows to build clouds for a more use cases. E.g. a cloud of authors with weights depending on amount of content they produced. For both cases see the README.txt on how to set this up.

This module does not depend on Tagadelic, but uses a slightly modified version of the weight calculation algorithm. So tagclouds should look exactly the same.

Sandbox Link

Cloud9 Sandbox

Intended Drupal Version

Drupal 7

git clone link

git clone http://git.drupal.org/sandbox/xinitrc/1487930.git cloud9

CommentFileSizeAuthor
#12 drupalcs-result.txt1.82 KBklausi
#1 drupalcs-result.txt2.73 KBtargoo

Comments

xinitrc’s picture

xinitrc commented
Issue summary: View changes

I forgot to add the intended Drupal version before.

targoo’s picture

targoo commented
Status: Needs review » Needs work
StatusFileSize
new drupalcs-result.txt2.73 KB

Review of the 7.x-1.x branch:

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. Get a review bonus and we will come back to your application sooner!

targoo’s picture

targoo commented

Hi

I think that you only have to list files in the info file that contain classes or interfaces. I will test your module soon.
Try to get a review bonus. This will make the review process faster.

xinitrc’s picture

xinitrc commented
Issue summary: View changes

Typo fixed

xinitrc’s picture

xinitrc commented
Status: Needs work » Needs review

I fixed all but 6 Errors from http://ventral.org/pareview/httpgitdrupalorgsandboxxinitrc1487930git-7x-1x
the remaining 6 are camelcase vs. underscore issues which result from overriding view functions in a subclass, so I can't fix them without loosing the views functionality.

On my end the info file only contains cloud9_style_plugin.inc which is the only file containing a class definition.

xinitrc’s picture

xinitrc commented

I fixed a potential future bug, which was previously mentioned in the README. This introduced two more underscore vs. camelcase "bugs" which I can't really fix with the same rational as the six "bugs" mentioned before.

xinitrc’s picture

xinitrc commented

I could remove the two bugs introduced by last fix after all.

geertvd’s picture

geertvd commented

Great module, I was just looking for something like this recently.
Could you try to catch the error thrown when your view is not set to aggregating.
If found an issue for that here: http://drupal.org/node/1277376 Not completly sure if this is a core related issue.

Besides that this module is working for me.

xinitrc’s picture

xinitrc commented

Hi,
thanks for your Review. Could you tell me which exception is thrown? I can't produce any error messages at my end.

With best regards

geertvd’s picture

geertvd commented

Hi,

I got a "EntityMalformedException: Missing bundle property on entity of type node. in entity_extract_ids() (line 7390" popup when I select Cloud9.
Perhaps there are issues on my end, I'll reinstall my test environment and test your module again when I find some time, it's getting a little bit messy from all the testing.

xinitrc’s picture

xinitrc commented
Priority: Normal » Major

Updated Priority according to the advise in http://drupal.org/node/539608

xinitrc’s picture

xinitrc commented
Priority: Major » Critical

Updated Priority according to the advise in http://drupal.org/node/539608

Jeff Burnz’s picture

Jeff Burnz commented

I have concerns about the namespace here, while I understand that "on cloud nine" is a generic English idiom, its also the name of a large online community and IDE, and may also be trade marked: http://c9.io/

I would tend to think that if users go looking for "Drupal Cloud9" they will be looking for an integration with that service.

Just a thought and certainly not a blocker, just not so sure this is a good use case for the namespace, it might cause much confusion.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Priority: Critical » Normal
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new drupalcs-result.txt1.82 KB

Sorry for the delay, but you have not listed any reviews of other project applications in your issue summary as strongly recommended in the application documentation.

I agree with Jeff Burnz, please rename your module as the term "cloud9" is quite overloaded (IDE, company, etc.).

Review of the 7.x-1.x branch:

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. Get a review bonus and we will come back to your application sooner.

But otherwise looks RTBC to me.

patrickd’s picture

patrickd commented

I also agree that a namechange should be considered.

Also your comparing your module to tagagelic, but how does it differ to views cloud https://drupal.org/project/views_cloud ?

patrickd’s picture

patrickd commented
Status: Reviewed & tested by the community » Postponed (maintainer needs more info)
xinitrc’s picture

xinitrc commented

Hi,

thanks for your reviews. I know I could have made this process faster by reviewing other projects, but I currently got tons of work and just little spare time hence this late answer.

  • I'm completely ok with changing the name of the module.
  • Obviously I will fix the PAReview warning / bugs. (Is it possible that those changed I did several runs on fixing them beforehand and was left with 6 which I couldn't fix, as mentioned above.
  • I hopefully will find time this evening to compare this module with views_cloud. I actually didn't know it until you mentioned it. I filtered for 7.x while I was searching for a module that does this. Working hypothesis is that it is a (partial) rewrite, in which case I will look into making this into a patch for views_cloud (depending on my findings, and how easy it would be to rewrite)
patrickd’s picture

patrickd commented
Status: Postponed (maintainer needs more info) » Fixed

Okay, sounds good!

Even if your module is duplicating views_cloud, the actual target of this process (making sure YOU are RTBC) seems to be finished and it would be a waste of time not fixing this issue now for duplication reasons, therefore I've granted you the git vetted user role which will let you promote this to a full project and also create new projects as either sandbox or "full" projects depending on which you feel is best. (As you probably know duplication already is an increasing problem on d.o, therefore make sure there's really nothing else before promoting your projects).

Anyways, thanks for your contribution and welcome to the community of project contributors on drupal.org! :)

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

As you continue to work on your module, keep in mind: Commit messages - providing history and credit and Release naming conventions.

Thanks to the dedicated reviewer(s) as well.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) commented
Issue summary: View changes

Corrected git clone url