UC Estcard 6.x

Welcome!

Please take a moment to make your project page follow tips for a great project page.
Also you should create a README.txt that follows the guidelines for in-project documentation.

while waiting for an in-depht review of your module you can start out fixing some coding style issues detected by automated tools, as pointed out above.
http://ventral.org/pareview/httpgitdrupalorgsandboxkaido241506046git

regards

> Fixed these issues. :)

The content of README.txt has to follow the guidelines for in-project documentation:

README.txt
Every contributed module should provide a README.txt in the package. This file should contain a basic overview of what the module does and how someone may use it. The contents of the file may be a repeat of the synopsis on the project page. See the Module documentation guidelines for further details.

as an example see http://drupalcode.org/project/bot.git/blob/HEAD:/README.txt

Manual review:
Apart from missed README.txt content - the code of the module looks clean and secure.

Hi

You should also provide an install file in order to implement hook_uninstall so you can remove the variables you set all along your module.

You have not listed any reviews of other projects in your issue summary, as strongly recommended in http://drupal.org/node/1011698

See also #1410826: [META] Review bonus

For getting a review bonus, note that you have to do 3 manual reviews and also have to tag this application with "PAReview: review bonus" afterwards (otherwise we can't see that you applying for it). (See https://drupal.org/node/1410826)

No, you actually should be able to edit it ?!
See attachment

Ohkay, you misunderstood that point, you have to add the list of reviews into the body of the issue and set the review bonus tag by a new comment ;)

The code passes validation and everything looks correctly done in the code so for me it's ok

Your project page still looks short and unstructured, please have a look at the tips for a great project page.

Please make your commit messages contain detailed description what has been changed, ".." "..." "...()..." is not very helpful ;)

    case 'cart-details':

      return;
    case 'cart-process':
      return;

if you don't handle these cases, don't react on them.
Also note that 'cases' should end with break; and not with return;

uc_estcard_payment_method():
Your not translating t('Credit card') consequent - just once

your not using watchdog correctly, you forgot the existance of the $variable parameter see documentation

I did not test the module but it looks good enough and I could not find any security related issues, therefore

Thanks for your contribution and welcome to the community of project contributors on drupal.org!

I've granted you the git vetted user role which will let you promote this to a full project and also create new projects as either sandbox or "full" projects depending on which you feel is best - but don't forget that this power also brings responsibility ;)

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

As you continue to work on your module, keep in mind: Commit messages - providing history and credit and Release naming conventions.

Thanks to the dedicated reviewer(s) as well.