[D7] JS CDN Module

If statements should not be

  if ($cdn_ssl):
    $cdn_jquery_ui_path = str_replace('http://', 'https://', $cdn_jquery_ui_path);
    $cdn_jquery_ui_theme = str_replace('http://', 'https://', $cdn_jquery_ui_theme);
  endif;

or
if ($cdn_ssl) $cdn_jquery_path = str_replace('http://', 'https://', $cdn_jquery_path);

but should be done according to the coding standards defined at:

if (condition1 || condition2) {
  action1;
}
elseif (condition3 && condition4) {
  action2;
}
else {
  defaultaction;
}

The same for other control structures:

  foreach ($killlist as $lib => $filepart):
    if (isset($libraries[$lib])) unset($libraries[$lib]);
  endforeach;

see http://drupal.org/coding-standards#controlstruct

why did you fork the module? Have you opened an issue in the queue of that module to incorporate your enhancements? Have you contacted the maintainer of that module to get her/his opinion? Duplication is a big problem on drupal.org, we should avoid that.

Also, you have not listed any reviews of other project applications in your issue summary as strongly recommended here: http://drupal.org/node/1011698

why did you fork the module? Have you opened an issue in the queue of that module to incorporate your enhancements? Have you contacted the maintainer of that module to get her/his opinion? Duplication is a big problem on drupal.org, we should avoid that.

I had the same thoughts on reading the application description and was surprised to see that leandro713 is actually a maintainer of the original module, jquerycdn. So no need to contact the maintainer (yourself), leandro713, but it would still be good to explain why you felt this code shouldn't go into the original module.

Still no reason for duplicating a new module with same functionality, please follow the guidelines of how to take over an abandoned module.

// edit

oh, wait, you already got full git access rights, the only right you don't have is the right to administer the maintainer list.
Where's the problem ?

added reviews of other project applications