I have been using Nivo Slider on a multilingual site for some time but the description, showing on the slides is not being picked up by the Drupal translation functionality.

CommentFileSizeAuthor
#12 translate-user-submitted-slider-information-1517380-12.patch4.46 KBdevin carlson
#10 translate-user-submitted-slider-information-1517380-7.patch4.53 KBdevin carlson
#7 translate-user-submitted-slider-information-1517380-7.patch2.04 KByashadev
#6 translate-user-submitted-slider-information-1517380-6.patch1.59 KByashadev
#2 translate-user-submitted-slider-information-1517380-2.patch1.48 KBdevin carlson
#1 description_translation_not_working.patch1 KBmvantuch

Comments

mvantuch’s picture

mvantuch commented
StatusFileSize
new description_translation_not_working.patch1 KB

Created a quick patch, it will need more work though I guess.

devin carlson’s picture

devin carlson commented
Version: 7.x-1.3 » 7.x-1.x-dev
StatusFileSize
new translate-user-submitted-slider-information-1517380-2.patch1.48 KB

I believe that user-submitted text should be run through the i18nstrings function provided by the Internationalization module (see Translating user defined strings) when possible.

Can you test the attached patch (you will need the Internationalization module installed in order to translate the slider)? Please note that you will need the latest git checkout/development release of Nivo Slider.

Status: Needs review » Needs work

The last submitted patch, translate-user-submitted-slider-information-1517380-2.patch, failed testing.

chuangban2012’s picture

chuangban2012 commented
Status: Needs work » Needs review

#2: translate-user-submitted-slider-information-1517380-2.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, translate-user-submitted-slider-information-1517380-2.patch, failed testing.

yashadev’s picture

yashadev commented
Status: Needs work » Needs review
StatusFileSize
new translate-user-submitted-slider-information-1517380-6.patch1.59 KB

Modified patch based on the updated 7.x-1.x.

yashadev’s picture

yashadev commented
StatusFileSize
new translate-user-submitted-slider-information-1517380-7.patch2.04 KB

The previous patch gave some errors after applying it.
Modified patch is attached. Please review

micheleannj’s picture

micheleannj commented

I was able to apply the patch and now see the Nivo Slider group on the Translate and Import tabs of the Translation Interface, but no strings are found in that group. There's also no Nivo Slider option on the Strings page in order to refresh.

It would be great to see this functionality part of the next release, so please let me know if there's any other testing or feedback that could help.
Thanks!

devin carlson’s picture

devin carlson commented
Version: 7.x-1.x-dev » 8.x-1.x-dev
devin carlson’s picture

devin carlson commented
Version: 8.x-1.x-dev » 7.x-1.x-dev
Assigned: Unassigned » devin carlson
Category: bug » feature
StatusFileSize
new translate-user-submitted-slider-information-1517380-7.patch4.53 KB

I think I finally managed to figure this one out.

devin carlson’s picture

devin carlson commented
Version: 7.x-1.x-dev » 8.x-1.x-dev
Status: Needs review » Patch (to be ported)

Committed to 7.x-1.x.

devin carlson’s picture

devin carlson commented
Status: Patch (to be ported) » Needs review
StatusFileSize
new translate-user-submitted-slider-information-1517380-12.patch4.46 KB

D8 patch.

devin carlson’s picture

devin carlson commented
Status: Needs review » Fixed

Committed to 8.x-1.x.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

lionheart8’s picture

lionheart8 commented
Issue summary: View changes

Hi

What is the status of this issue, if I may ask? There is an implication the issue was solved as early as 2012, but ...

I have never been quite able to have the nivo slider content (currently using 7.x-1.11, 2014-Mar-18 ) being translatable, at least into German.
I consistently get such errors whenever I try to save content:

    The string nivo_slider:slide:0:description for textgroup nivo_slider is not allowed for translation because of its text format.
    The string nivo_slider:slide:1:description for textgroup nivo_slider is not allowed for translation because of its text format.
    The string nivo_slider:slide:2:description for textgroup nivo_slider is not allowed for translation because of its text format.
    The string nivo_slider:slide:3:description for textgroup nivo_slider is not allowed for translation because of its text format.
    The string nivo_slider:slide:4:description for textgroup nivo_slider is not allowed for translation because of its text format.

and wonder what I will do, when a site with fully translated content on a multilingual site is required.

I would appreciate some help/solution.

Kind regards