[D7] Flickr pull

Hi,

Automatic review :

• There are errors of indentations,
• The formatting of comments is not correct,
• README.txt is missing,
• You must work from a specific branch and not the master branch,

More details here: http://ventral.org/pareview/httpgitdrupalorgsandboxadamelleston1512132git

Manual review :

• You must add a .install file to delete variables when uninstalling with variable_del (),
• Some sentences are not translatable, it lacks the t() [flickr_pull.module L:161 205 283 292]

Hi,

FILE: ...pareview/sites/all/modules/pareview_temp/test_candidate/flickr_pull.css
--------------------------------------------------------------------------------
FOUND 11 ERROR(S) AFFECTING 3 LINE(S)
--------------------------------------------------------------------------------
1 | ERROR | Expected exactly one new line after opening brace of class
| | definition
1 | ERROR | Each style definition must be on a line by itself
1 | ERROR | Each style definition must be on a line by itself
1 | ERROR | Expected exactly one new line before closing brace of class
| | definition
2 | ERROR | Expected exactly one new line after opening brace of class
| | definition
2 | ERROR | Each style definition must be on a line by itself
2 | ERROR | Expected 1 space after colon in style definition; 0 found
2 | ERROR | Expected exactly one new line before closing brace of class
| | definition
3 | ERROR | Expected exactly one new line after opening brace of class
| | definition
3 | ERROR | Expected exactly one new line before closing brace of class
| | definition
3 | ERROR | Files must end in a single new line character
--------------------------------------------------------------------------------

Manual Review :

1. Format should be "* Implements hook_foo()." or "Implements hook_foo_BAR_ID_bar() for xyz_bar()."
2. It seems that you are not having .install file.
Define install and uninstall function in that file.
ex:

function mymodule_schema() {
  $schema['mytable1'] = array(
     // specification for mytable1
  );
  $schema['mytable2'] = array(
     // specification for mytable2
  );
  return $schema;
}

function mymodule_install() {
  // Create my tables.
  drupal_install_schema('mymodule');
}

function mymodule_uninstall() {
  // Drop my tables.
  drupal_uninstall_schema('mymodule');
}

3. I'd really suggest you to get a review bonus, since that really speeds up the review process...

welcome,

As installation and usage instructions are quite important for review, please take a moment to make your project page follow tips for a great project page. Also follows the guidelines for in-project documentation.

As it is usual, according to http://drupal.org/node/1127732 you should remove your code from the master branch and move to version specific branch.

Multiple Applications

It appears that there have been multiple project applications opened under your username:

Project 1: http://drupal.org/node/1525264
Project 2: http://drupal.org/node/1772594

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

We are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)