invite_og_plugin

Ran automatic review, found code style errors (please configure your IDE to trim whitespace at end of lines)
See http://ventral.org/pareview/httpgitdrupalorgsandboxkillerpoke1441644git-7x

Otherwise it looks good to me

As installation and usage instructions are quite important for us to review, please take a moment to make your project page follow the tips for a great project page. Also make sure your README.txt follows the guidelines for in-project documentation.

We do really need more hands in the application queue and highly recommend to get a review bonus so we can come back to your application sooner.

Tested module in sandbox environment and it is working for the prescribed use case.

Notes:

Please include a link to your git repo to make review easier.

git clone http://git.drupal.org/sandbox/killerpoke/1441644.git invite_og_plugin

README.txt has some unnecessary spaces during line breaks and and the end of a few lines, probably from your IDE.

I also suggest expanding your project page and perhaps including a working demo/screenshots.

Any word on the approval of this wonderful project?

Manual Review:

The module & code looks sound.

Automated Review:

Please try to resolve below issue.
FILE: ...al-7-pareview/sites/all/modules/pareview_temp/test_candidate/README.txt
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
14 | ERROR | Files must end in a single new line character
--------------------------------------------------------------------------------

I've found this error to actually go away by deleting the last line on README.txt in the past. This was using Vim.

Might be a PAReview bug or something we are doing wrong?

killerpoke, please do some project reviews and list them in the Issue Summary. You can then tag this with 'PAReview: review bonus' for every 3 you do. This will expedite the process of getting you full project access.

Remove all files from master branch and set default branch to your desired one. What's more there is no need to create two branches for 7.x before your module becomes full module. Consider making it one 7.x-1.x branch.

.module file

define('INVITE_OG_PLUGIN_GROUP_PERMISSION', "invite");
You have two types of parenthisis. Use one consistent method. There is no need to use "" (php parses such strings to find if there are any variables inside).

You do not need to document hook functions so well. It is known what parameters they have, but it is not a bug. I'm just sharing some thoughts.

If you alter only one form you should use hook_FORM_ID_alter rather than form_alter.

You are using $_POST, but as long as in invite_save drupal_write_record is called it probably is safe against the SQL injection.
But users can fake $_POST request, I believe you should use drupal_token function to check if there is no way of sending fake requests. Please look into http://drupalscout.com/tags/csrf.

Please place full stop at the end of each sentence in your comments.

'#required' => FALSE, is a default property. You do not need to place it, but it is not a bug.

You need not to split conditions in your if clausule into separate lines. 80 character limit applies only to comments.

I'm sending it back to needs work because of that tokens in hook_invite_send(). Although I'm not experienced in reviewing applications so if anyone thinks that it should not be needs work, please, feel free to change.

Thank you for your explanation and sorry I did not check that out.
Other issues are not RTBC blocker, so I'm changing status.

Added the git clone repo command

There is still a master branch, make sure to set the correct default branch: http://drupal.org/node/1659588 . Then remove the master branch, see also step 6 and 7 in http://drupal.org/node/1127732

manual review:

1. 7.x is not a good branch name, please rename it to 7.x-1.x
2. invite_og_plugin_form_invite_form_alter(): do not document hook parameters as they are known anyway, see http://drupal.org/node/1354#hookimpl
3. You should only document function parameters if you add a description. Otherwise it does not make sense as I can read the parameter names form the function signature anyway.
4. invite_og_plugin_invite_send(): I think you should use your own form submit callback instead of accessing $_POST here.

Although you should defintively fix that I see no security issues or other blockers here.

Thanks for your contribution, killerpoke!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.