Great module!

I am using the API within a custom theme, and I found it usefull to be able to send $attributes along to the final theming call.

This patch passes the attributes along from theme_flickr_photoset() to theme_flickr_photo().

CommentFileSizeAuthor
#3 pass_attribs_from_photoset_to_photo-1602154-3.patch1.06 KBlolandese
flickr.module.patch1.16 KBjmlavarenne

Comments

lolandese’s picture

lolandese commented
Issue summary: View changes
Status: Active » Needs review

There is a patch, so something to review.

Thanks.

lolandese’s picture

lolandese commented
Status: Needs review » Postponed (maintainer needs more info)

Can you provide a simple use case to test with?

Thanks.

lolandese’s picture

lolandese commented
Status: Postponed (maintainer needs more info) » Needs review
StatusFileSize
new pass_attribs_from_photoset_to_photo-1602154-3.patch1.06 KB

Re-rolled patch against D7. Furthermore clarified some code comments.

Even if the module itself currently does not need this, if it aspires to be used as an API (as it does) it makes sense to implement this.

lolandese’s picture

lolandese commented

Once this will go in the stable version, a note should be included about it in the documentation of Flickr Filter. Something like:

Any style and class parameters defined in a photoset tag, will be applied on each single image in the set. For example [flickr-photoset:id=72157634563269642,size=t,class=foo,style=border:solid 2px;] will result in each image having a border instead of the set itself as one might expect. Targeting with CSS is prefered over inline styling.

Probably that was just what you were after for your use case, as it might be exactly what others might want.

http://drupalcode.org/project/flickr.git/commitdiff/0708366

Once tested on D6, I'll commit it also there.

More info about the HTML structure of an embedded Flickr image and where it is generated in the code, can be found in the Flickr module's documentation at https://drupal.org/node/2170535#html.

Thanks.

  • Commit 0708366 on 7.x-1.x authored by Jupiter, committed by lolandese: 
    Issue #1602154 by Jupiter: Pass attributes along to images when theming...
lolandese’s picture

lolandese commented
Version: 6.x-1.x-dev » 7.x-1.x-dev
Status: Needs review » Fixed
lolandese’s picture

lolandese commented
Version: 7.x-1.x-dev » 6.x-1.x-dev
Status: Fixed » Needs review
lolandese’s picture

lolandese commented
Issue summary: View changes
Status: Needs review » Closed (won't fix)

On D7 this is fixed. For D6 see #2367755: D6 maintenance.

Thanks.

lolandese’s picture

lolandese commented
Version: 6.x-1.x-dev » 7.x-1.x-dev
Status: Closed (won't fix) » Closed (fixed)

Setting this back to D7 and being 'fixed (closed)'.

Main reason is the fact that links to this issue show the status on hover without revealing the version (6 or 7). This might give the impression that the mentioned issue will not be solved, while in fact it is already fixed for the D7 version. 'Fixed (closed)' reflects the current status correctly for D7. 'Closed (won't fix)' is only valid for the minimally maintained D6 version of the module.