Post

Welcome!

you have not listed any reviews of other project applications in your issue summary as strongly recommended in the application documentation.

It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.
Review of the master branch:

• README.txt is missing, see the guidelines for in-project documentation.
• Remove LICENSE.txt, it will be added by drupal.org packaging automatically.
• Run coder to check your style, some issues were found (please check the Drupal coding standards). See attachment.
• Drupal Code Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

Hi there,

Automated review:
There's still a few outstanding issues from the automated review, check them out here http://ventral.org/pareview/httpgitdrupalorgsandboxjswainst1547216git
It also looks like you've got extra files in your master branch still too. Have a read of http://drupal.org/node/1127732

Manual review:

• You don't need to specify package = other in your info file, it will default to this if no package is defined
• In post.admin.in you've got concatenation inside your t() function, use placeholders instead so that it's all one string literal. Have a look at this comment in the api docs.
• Line 172 in the same file, probably best to wrap this in a t() as well.
• For ease of reading, wrap your README.txt to 80 characters
• post.module line 57 - might be more readable to multi-line this if statement

Other than that for a first look through it looks like nice tidy code. Good stuff!

Still I can find some error with Drupal Code Sniffer, Refer to the attached file.

Very minor coding standards errors do not justify "needs work". Please provide a manual review.

Hi jswainst.

I have taken a look at your code, this is what i came up with

1. A suggestion, would be to do some cleaning in your file structure, putting css files under a css folder, and templates under a template folder & js etc.
2. post_button.tpl.php: keep in mind that i'm not familiar with the the po.st API, but is it really necessary to have a

I reviewed the module and everything looks good. I use separate tpl.php files for much of my theming and, at least for me, it seems to make things cleaner and easy to work with.

I too have reviewed the module and it looks fine by me.

I don't see the automated review messages as any major issue worth blocking this.

Thanks for your contribution, jswainst!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewers as well.