Is there any reason other than performance issues, for images not to be attached to $node->taxonomy[N]->image via hook_nodeapi?

What if that feature was wrapped in a setting turned off by default and/or turned on only for node types and/or vocabularies defined in admin/settings/taxonomy_image?

Also, it makes more sense for a usability POV to upload images via admin/content/taxonomy/edit/term/N, rather than implementing a whole new interface for it. Previews like admin/content/taxonomy/image make more sense to be implemented on admin/content/taxonomy/N.

It also makes sense to move the image resizing settings in admin/settings/taxonomy_image into their own fieldset, as they are completely unrelated to the directory name.

I also wondered if you'd considered integration with imagecache.module for image resizing?

Are there any reasons not to make the above changes? Would you object to any patches implementing them?

Thanks for the great module!

Comments

dman’s picture

dman commented

I agree the interface should be brought into the term edit page. I think the original tab dates back to pre-form-API days, and it was just easier at the time. If you can consolidate the UI, I think that would be cool.

I like the idea of adding the image to the taxonomy term, it makes sense ... but I don't yet see the big advantage apart from a modicum of code convenience.

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented

I welcome all patches. A feature request with a patch is going to get far more attention and priority than one without. I do suggest that each feature be separate - possibly with a sequencing recommendation. And they should be based on the current -dev version.

I would not automatically link the images to a "taxonomy/term/xx" link because that's not the way everyone uses them. However, the hook_nodeapi is a better way to look at this feature.

And if you can move the management into the "taxonomy/edit/term" page you may save me some heartburn on another module that needs to call TI's management functions but they don't want to go back to my other module.

BTW, look at http://drupal.org/node/172966 and feel free to comment.

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented

Jeremy wants a consolidated UI, and so do I. But it should be opened as a separate feature request. I will hold it off until I start on version 2, though. And then we have the question of whether to do it only in a 6.x version, since it will significantly complicate the upgrade.

Actually we need this split into several issues:

  1. Images attached to $node->taxonomy[N]->image via hook_nodeapi?
    http://drupal.org/node/197369
  2. Consolidated UI.
    http://drupal.org/node/70971
  3. Move the image resizing settings into their own fieldset.
    DONE: http://drupal.org/cvs?commit=99643
  4. Integration with imagecache.module for image resizing.
    DONE: http://drupal.org/node/195548
nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented
Title: Auto load, UI, settings, imagecache changes » Implement taxonomy_image in theme from module

#3 is done. #4 is done.

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented
Title: Implement taxonomy_image in theme from module » Auto load, UI, settings, imagecache changes
Status: Active » Postponed (maintainer needs more info)
nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented
Title: Implement taxonomy_image in theme from module » Auto load, UI, settings, imagecache changes
Status: Postponed (maintainer needs more info) » Closed (duplicate)

The duplicated issues are listed above.