The module provides a new commerce checkout pane, the content of which can be configured via rules. This comes useful for example when you
want to display a certain message to the user depending on the payment method and drupal_set_message is not the right / appropriate / acceptable method.

The module provides a new rules event ("Determine rules checkout pane content") and a two new actions ("Set the completition message" and "Set an entity to be displayed as completition message"). Set the completition message: allows users to display a simple messages in the rules commerce pane. Set an entity to be displayed as completition message allows users to display an entity in the rules commerce pane: a node with detailed instructions, or the active order, or user object, etc.

Project page: http://drupal.org/sandbox/primsi/1673880
Git repo: git clone http://git.drupal.org/sandbox/primsi/1673880.git commerce_rules_pane
Drupal core version: 7.x

Reviews of other projects:

Comments

Jeffrey C.’s picture

Jeffrey C. commented

Automated Review:
An automated review of your project has found some issues with your code; As coding standards make sure projects are coded in a consistent style we please you to have a look at the report and try to fix them. Anyway, note that issues found are possibly false positives and fixing all issues is not a requirement for getting through the application process.

You can find the results of the automated report at http://ventral.org/pareview/httpgitdrupalorgsandboxprimsi1673880git.

Jeffrey C.’s picture

Jeffrey C. commented
Status: Needs review » Needs work

Putting status to needs work.

primsi’s picture

primsi commented

Thx for the review. Coding standards issues are now fixed: http://ventral.org/pareview/httpgitdrupalorgsandboxprimsi1673880git

primsi’s picture

primsi commented
Status: Needs work » Needs review

Changing status.

mitchell’s picture

mitchell commented
Issue tags: +PAReview: Commerce

Adding Commerce's review tag.

dabblela’s picture

dabblela commented

Hi primsi -
Thanks for your contribution. This looks like it could be a really useful module, but I have some notes which I"ve added in an issue on your project:

#1677114: Refactor to take better advantage of Rules

I'd like to get your feedback on that before providing a comprehensive review.

dabblela’s picture

dabblela commented
Status: Needs review » Needs work
primsi’s picture

primsi commented
Status: Needs work » Needs review

Thanks for the review manatwo. I have addressed the 'storing in session' issue and provided the rules action with the commerce order context.

Although input on both issues is still welcome, I am setting this to needs review.

primsi’s picture

primsi commented

There have been some changes in the module:

slashrsm’s picture

slashrsm commented
Status: Needs review » Needs work

It looks OK to me. I just got one sniffer message left:

FILE: ...sites/DUR/modules/custom/commerce_rules_pane/commerce_rules_pane.module
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
 14 | ERROR | Closing brace indented incorrectly; expected 4 spaces, found 6
--------------------------------------------------------------------------------

I'd suggest to add CHANGELOG.txt file. You can then copy commit messages into it to track changes. You will find more info about this here: http://drupal.org/node/52287.

I'd call this passed, when you fix this things.

primsi’s picture

primsi commented
Status: Needs work » Needs review

Thx for the review. I've added CHANGELOG.txt:

http://drupalcode.org/sandbox/primsi/1673880.git/commit/2baccfb

As for the coding standards error, I don't get that one. Perhaps I have fixed this in a previous commit:

http://ventral.org/pareview/httpgitdrupalorgsandboxprimsi1673880git

slashrsm’s picture

slashrsm commented
Status: Needs review » Reviewed & tested by the community

Great. I'd then call this passed.

slashrsm’s picture

slashrsm commented
Issue summary: View changes

Adding the Drupal core version compatibility.

primsi’s picture

primsi commented
Issue summary: View changes

Adding a review.

primsi’s picture

primsi commented
Issue summary: View changes

Updated issue summary.

primsi’s picture

primsi commented
Issue summary: View changes

Fixed the Git repo line.

primsi’s picture

primsi commented
Issue summary: View changes

Fixed the git clone branch.

mitchell’s picture

mitchell commented
Status: Reviewed & tested by the community » Needs work

Could this be reworked as a patch directly in Commerce's Checkout module, for example in #1233508: Checkout display as rules event, #1122386: Allow rules to control which panes are visible during checkout, or #1645252: Allow administrators to trigger "checkout completed"?

I found those in http://drupal.org/project/issues/commerce?text=rules&component=Checkout

primsi’s picture

primsi commented
Status: Needs work » Needs review

Thank you for the review.

#1233508: Checkout display as rules event - provides a way to configure checkout page properties settings via rules, "Commerce rules pane" provides a new checkout pane, where you can display an arbitrary message or an arbitrary entity (e.g. user completes checkout, we display him the invoice, or a node with further information ).

#1122386: Allow rules to control which panes are visible during checkout - aims to control the visibility per pane: "essentially, if the customer is buying only digital products, we don't want to collect a shipping address."

#1645252: Allow administrators to trigger "checkout completed" - seems to be a usability issue, that allows store admins to easily change the order status?

primsi’s picture

primsi commented
Issue summary: View changes

Updated issue summary.

primsi’s picture

primsi commented
Issue summary: View changes

Updated issue summary.

primsi’s picture

primsi commented
Issue summary: View changes

Updated issue summary.

primsi’s picture

primsi commented
Issue summary: View changes

Updated issue summary.

primsi’s picture

primsi commented
Issue tags: +PAreview: review bonus

Applying for PAReview: review bonus.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs review » Reviewed & tested by the community
Issue tags: -PAreview: review bonus

There is still a master branch, make sure to set the correct default branch: http://drupal.org/node/1659588 . Then remove the master branch, see also step 6 and 7 in http://drupal.org/node/1127732

manual review:
"'Set the completition message'": typo: should be completion. Also elsewhere.

Othwerwise looks RTBC to me. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

patrickd’s picture

patrickd commented
Status: Reviewed & tested by the community » Fixed

Thanks for your contribution!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) commented
Issue summary: View changes

Chaging issue description.